migrate noDebugStack

Author: mtoffl01

ddtrace/tracer/option.go

@@ -231,10 +231,6 @@ type config struct {
 	// It defaults to time.Ticker; replaced in tests.
 	tickChan <-chan time.Time
 
-	// noDebugStack disables the collection of debug stack traces globally. No traces reporting
-	// errors will record a stack trace when this option is set.
-	noDebugStack bool
-
 	// enabled reports whether tracing is enabled.
 	enabled dynamicConfig[bool]
 
@@ -880,7 +876,7 @@ func WithLogger(logger Logger) StartOption {
 // FinishOption.
 func WithDebugStack(enabled bool) StartOption {
 	return func(c *config) {
-		c.noDebugStack = !enabled
+		c.internalConfig.SetDebugStack(enabled, internalconfig.OriginCode)
 	}
 }
 

ddtrace/tracer/telemetry.go

@@ -52,8 +52,8 @@ func startTelemetry(c *config) telemetry.Client {
 		{Name: "agent_hostname", Value: c.hostname},
 		{Name: "runtime_metrics_v2_enabled", Value: c.internalConfig.RuntimeMetricsV2Enabled()},
 		{Name: "dogstatsd_addr", Value: c.dogstatsdAddr},
-		{Name: "debug_stack_enabled", Value: !c.noDebugStack},
 		{Name: "profiling_endpoints_enabled", Value: c.internalConfig.ProfilerEndpoints()},
+		{Name: "debug_stack_enabled", Value: c.internalConfig.DebugStack()},
 		{Name: "profiling_hotspots_enabled", Value: c.internalConfig.ProfilerHotspotsEnabled()},
 		{Name: "trace_span_attribute_schema", Value: c.spanAttributeSchemaVersion},
 		{Name: "trace_peer_service_defaults_enabled", Value: c.peerServiceDefaultsEnabled},

ddtrace/tracer/tracer.go

@@ -764,7 +764,7 @@ func (t *tracer) StartSpan(operationName string, options ...StartSpanOption) *Sp
 	if span.service == "" {
 		span.service = t.config.serviceName
 	}
-	span.noDebugStack = t.config.noDebugStack
+	span.noDebugStack = !t.config.internalConfig.DebugStack()
 	if t.config.hostname != "" {
 		span.setMeta(keyHostname, t.config.hostname)
 	}

internal/config/config.go

@@ -79,6 +79,8 @@ type Config struct {
 	logToStdout bool
 	// isLambdaFunction, if true, indicates we are in a lambda function
 	isLambdaFunction bool
+	// debugStack enables the collection of debug stack traces globally. Error traces will not record a stack trace when this option is false.
+	debugStack bool
 }
 
 // loadConfig initializes and returns a new config by reading from all configured sources.
@@ -115,6 +117,7 @@ func loadConfig() *Config {
 	cfg.logDirectory = provider.getString("DD_TRACE_LOG_DIRECTORY", "")
 	cfg.traceRateLimitPerSecond = provider.getFloatWithValidator("DD_TRACE_RATE_LIMIT", DefaultRateLimit, validateRateLimit)
 	cfg.globalSampleRate = provider.getFloatWithValidator("DD_TRACE_SAMPLE_RATE", math.NaN(), validateSampleRate)
+	cfg.debugStack = provider.getBool("DD_TRACE_DEBUG_STACK", true)
 
 	// AWS_LAMBDA_FUNCTION_NAME being set indicates that we're running in an AWS Lambda environment.
 	// See: https://docs.aws.amazon.com/lambda/latest/dg/configuration-envvars.html
@@ -355,3 +358,16 @@ func (c *Config) SetSpanTimeout(timeout time.Duration, origin telemetry.Origin)
 	c.spanTimeout = timeout
 	telemetry.RegisterAppConfig("DD_TRACE_ABANDONED_SPAN_TIMEOUT", timeout, origin)
 }
+
+func (c *Config) DebugStack() bool {
+	c.mu.RLock()
+	defer c.mu.RUnlock()
+	return c.debugStack
+}
+
+func (c *Config) SetDebugStack(enabled bool, origin telemetry.Origin) {
+	c.mu.Lock()
+	defer c.mu.Unlock()
+	c.debugStack = enabled
+	telemetry.RegisterAppConfig("DD_TRACE_DEBUG_STACK", enabled, origin)
+}

internal/env/supported_configurations.gen.go

@@ -414,6 +414,9 @@
     "DD_TRACE_DEBUG_ABANDONED_SPANS": [
       "A"
     ],
+    "DD_TRACE_DEBUG_STACK": [
+      "A"
+    ],
     "DD_TRACE_DEBUG_SEELOG_WORKAROUND": [
       "A"
     ],