--wip-- [skip ci]

Author: eliottness

openfeature/exposure.go

@@ -106,7 +106,7 @@ type exposureWriter struct {
 }
 
 // newExposureWriter creates a new exposure writer with the given configuration
-func newExposureWriter(config *ProviderConfig) *exposureWriter {
+func newExposureWriter(config ProviderConfig) *exposureWriter {
 	flushInterval := config.ExposureFlushInterval
 	if flushInterval == 0 {
 		flushInterval = defaultExposureFlushInterval

openfeature/integration_test.go

@@ -18,7 +18,7 @@ import (
 // using the actual OpenFeature SDK client.
 func TestEndToEnd_BooleanFlag(t *testing.T) {
 	// Create provider and configuration
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EBooleanConfig()
 	provider.updateConfiguration(&config)
 
@@ -88,7 +88,7 @@ func TestEndToEnd_BooleanFlag(t *testing.T) {
 
 // TestEndToEnd_StringFlag tests string flag evaluation with the OpenFeature SDK.
 func TestEndToEnd_StringFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EStringConfig()
 	provider.updateConfiguration(config)
 
@@ -133,7 +133,7 @@ func TestEndToEnd_StringFlag(t *testing.T) {
 
 // TestEndToEnd_IntegerFlag tests integer flag evaluation.
 func TestEndToEnd_IntegerFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EIntegerConfig()
 	provider.updateConfiguration(config)
 
@@ -178,7 +178,7 @@ func TestEndToEnd_IntegerFlag(t *testing.T) {
 
 // TestEndToEnd_FloatFlag tests float flag evaluation.
 func TestEndToEnd_FloatFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EFloatConfig()
 	provider.updateConfiguration(config)
 
@@ -206,7 +206,7 @@ func TestEndToEnd_FloatFlag(t *testing.T) {
 
 // TestEndToEnd_ObjectFlag tests JSON/object flag evaluation.
 func TestEndToEnd_ObjectFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EObjectConfig()
 	provider.updateConfiguration(config)
 
@@ -252,7 +252,7 @@ func TestEndToEnd_ObjectFlag(t *testing.T) {
 
 // TestEndToEnd_DisabledFlag tests that disabled flags return defaults.
 func TestEndToEnd_DisabledFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{
@@ -297,7 +297,7 @@ func TestEndToEnd_DisabledFlag(t *testing.T) {
 
 // TestEndToEnd_MissingFlag tests error handling for non-existent flags.
 func TestEndToEnd_MissingFlag(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{
@@ -334,7 +334,7 @@ func TestEndToEnd_MissingFlag(t *testing.T) {
 
 // TestEndToEnd_ConfigurationUpdate tests that configuration updates are reflected in evaluations.
 func TestEndToEnd_ConfigurationUpdate(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	provider.updateConfiguration(&universalFlagsConfiguration{})
 	err := of.SetProviderAndWait(provider)
 	if err != nil {
@@ -368,7 +368,7 @@ func TestEndToEnd_ConfigurationUpdate(t *testing.T) {
 
 // TestEndToEnd_TrafficSharding tests that traffic distribution works correctly.
 func TestEndToEnd_TrafficSharding(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createE2EShardingConfig()
 	provider.updateConfiguration(config)
 
@@ -826,7 +826,7 @@ func TestEndToEnd_JSONSerialization(t *testing.T) {
 	}
 
 	// Use the parsed config
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	provider.updateConfiguration(&parsedConfig)
 
 	err = of.SetProviderAndWait(provider)
@@ -853,7 +853,7 @@ func TestEndToEnd_JSONSerialization(t *testing.T) {
 // TestEndToEnd_EmptyRulesAllocation tests that an allocation with no rules matches all users.
 // This covers the fix where empty rules should match everyone (no targeting restrictions).
 func TestEndToEnd_EmptyRulesAllocation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{
@@ -925,7 +925,7 @@ func TestEndToEnd_EmptyRulesAllocation(t *testing.T) {
 // TestEndToEnd_ShardCalculationWithDash tests that the shard calculation uses
 // salt + "-" + targetingKey (with dash separator) to match Eppo SDK implementation.
 func TestEndToEnd_ShardCalculationWithDash(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{
@@ -1035,7 +1035,7 @@ func TestEndToEnd_ShardCalculationWithDash(t *testing.T) {
 // TestEndToEnd_IdAttributeFallback tests that when an attribute named "id" is not
 // explicitly provided, the targeting key is used as the "id" value.
 func TestEndToEnd_IdAttributeFallback(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{
@@ -1151,7 +1151,7 @@ func TestEndToEnd_IdAttributeFallback(t *testing.T) {
 
 // TestEndToEnd_AllThreeFixes tests a complex scenario that exercises all three fixes together.
 func TestEndToEnd_AllThreeFixes(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := &universalFlagsConfiguration{
 		Format: "SERVER",
 		Environment: environment{

openfeature/provider_bench_test.go

@@ -14,7 +14,7 @@ import (
 
 // BenchmarkBooleanEvaluation benchmarks boolean flag evaluation
 func BenchmarkBooleanEvaluation(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -34,7 +34,7 @@ func BenchmarkBooleanEvaluation(b *testing.B) {
 
 // BenchmarkStringEvaluation benchmarks string flag evaluation
 func BenchmarkStringEvaluation(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -54,7 +54,7 @@ func BenchmarkStringEvaluation(b *testing.B) {
 
 // BenchmarkIntEvaluation benchmarks integer flag evaluation
 func BenchmarkIntEvaluation(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -74,7 +74,7 @@ func BenchmarkIntEvaluation(b *testing.B) {
 
 // BenchmarkFloatEvaluation benchmarks float flag evaluation
 func BenchmarkFloatEvaluation(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -94,7 +94,7 @@ func BenchmarkFloatEvaluation(b *testing.B) {
 
 // BenchmarkObjectEvaluation benchmarks object flag evaluation
 func BenchmarkEvaluation(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -126,7 +126,7 @@ func BenchmarkEvaluationWithVaryingContextSize(b *testing.B) {
 
 	for _, size := range contextSizes {
 		b.Run(size.name, func(b *testing.B) {
-			provider := newDatadogProvider(nil)
+			provider := newDatadogProvider(ProviderConfig{})
 			config := createTestConfig()
 			provider.updateConfiguration(config)
 
@@ -165,7 +165,7 @@ func BenchmarkEvaluationWithVaryingFlagCounts(b *testing.B) {
 
 	for _, count := range flagCounts {
 		b.Run(count.name, func(b *testing.B) {
-			provider := newDatadogProvider(nil)
+			provider := newDatadogProvider(ProviderConfig{})
 			config := createTestConfig()
 
 			// Add additional flags
@@ -213,7 +213,7 @@ func BenchmarkEvaluationWithVaryingFlagCounts(b *testing.B) {
 
 // BenchmarkConcurrentEvaluations benchmarks concurrent flag evaluations
 func BenchmarkConcurrentEvaluations(b *testing.B) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 

openfeature/provider_test.go

@@ -243,7 +243,7 @@ func createTestConfig() *universalFlagsConfiguration {
 }
 
 func TestNewDatadogProvider(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	if provider == nil {
 		t.Fatal("expected provider to be non-nil")
 	}
@@ -260,7 +260,7 @@ func TestNewDatadogProvider(t *testing.T) {
 }
 
 func TestBooleanEvaluation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -332,7 +332,7 @@ func TestBooleanEvaluation(t *testing.T) {
 }
 
 func TestStringEvaluation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -373,7 +373,7 @@ func TestStringEvaluation(t *testing.T) {
 }
 
 func TestIntEvaluation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -410,7 +410,7 @@ func TestIntEvaluation(t *testing.T) {
 }
 
 func TestFloatEvaluation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -448,7 +448,7 @@ func TestFloatEvaluation(t *testing.T) {
 }
 
 func TestObjectEvaluation(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 
@@ -498,7 +498,7 @@ func TestObjectEvaluation(t *testing.T) {
 }
 
 func TestProviderWithoutConfiguration(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	ctx := context.Background()
 
 	flatCtx := openfeature.FlattenedContext{
@@ -521,7 +521,7 @@ func TestProviderWithoutConfiguration(t *testing.T) {
 }
 
 func TestProviderConfigurationUpdate(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 
 	// Initially no config
 	if provider.getConfiguration() != nil {
@@ -543,7 +543,7 @@ func TestProviderConfigurationUpdate(t *testing.T) {
 }
 
 func TestConcurrentEvaluations(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	config := createTestConfig()
 	provider.updateConfiguration(config)
 

openfeature/remoteconfig.go

@@ -21,7 +21,7 @@ const (
 	ffeCapability  = 46
 )
 
-func startWithRemoteConfig(config *ProviderConfig) (*DatadogProvider, error) {
+func startWithRemoteConfig(config ProviderConfig) (*DatadogProvider, error) {
 	provider := newDatadogProvider(config)
 
 	if err := remoteconfig.Start(remoteconfig.DefaultClientConfig()); err != nil {

openfeature/remoteconfig_test.go

@@ -413,7 +413,7 @@ func TestValidateFlag(t *testing.T) {
 
 func TestProcessConfigUpdate(t *testing.T) {
 	t.Run("valid configuration update", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 
 		config := universalFlagsConfiguration{
 			CreatedAt: time.Now(),
@@ -455,7 +455,7 @@ func TestProcessConfigUpdate(t *testing.T) {
 	})
 
 	t.Run("configuration deletion", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 
 		// First set a configuration
 		config := &universalFlagsConfiguration{
@@ -487,7 +487,7 @@ func TestProcessConfigUpdate(t *testing.T) {
 	})
 
 	t.Run("invalid JSON", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 
 		invalidJSON := []byte("{invalid json")
 		status := processConfigUpdate(provider, "test-path", invalidJSON)
@@ -501,7 +501,7 @@ func TestProcessConfigUpdate(t *testing.T) {
 	})
 
 	t.Run("invalid configuration", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 
 		config := universalFlagsConfiguration{
 			Format: "INVALID",
@@ -521,7 +521,7 @@ func TestProcessConfigUpdate(t *testing.T) {
 }
 
 func TestCreateRemoteConfigCallback(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 	callback := createRemoteConfigCallback(provider)
 
 	// Create a valid configuration
@@ -579,7 +579,7 @@ func TestRemoteConfigIntegration(t *testing.T) {
 	// connect to Remote Config (would require a running agent)
 
 	t.Run("callback handles multiple updates", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 		callback := createRemoteConfigCallback(provider)
 
 		// Create two different configurations
@@ -645,7 +645,7 @@ func TestRemoteConfigIntegration(t *testing.T) {
 	})
 
 	t.Run("callback handles mixed success and failure", func(t *testing.T) {
-		provider := newDatadogProvider(nil)
+		provider := newDatadogProvider(ProviderConfig{})
 		callback := createRemoteConfigCallback(provider)
 
 		validConfig := universalFlagsConfiguration{
@@ -683,7 +683,7 @@ func TestRemoteConfigIntegration(t *testing.T) {
 }
 
 func TestConfigurationPersistence(t *testing.T) {
-	provider := newDatadogProvider(nil)
+	provider := newDatadogProvider(ProviderConfig{})
 
 	// Simulate multiple Remote Config updates
 	callback := createRemoteConfigCallback(provider)