chore: fix IDE warnings (#4049)

Co-authored-by: kakkoyun <[email protected]>
Co-authored-by: dario.castane <[email protected]>

Author: darccio

ddtrace/tracer/log.go

@@ -156,14 +156,14 @@ func logStartup(t *tracer) {
 		DataStreamsEnabled:          t.config.dataStreamsMonitoringEnabled,
 	}
 	if _, _, err := samplingRulesFromEnv(); err != nil {
-		info.SamplingRulesError = fmt.Sprintf("%s", err.Error())
+		info.SamplingRulesError = err.Error()
 	}
 	if limit, ok := t.rulesSampling.TraceRateLimit(); ok {
 		info.SampleRateLimit = fmt.Sprintf("%v", limit)
 	}
 	if !t.config.logToStdout {
 		if err := checkEndpoint(t.config.httpClient, t.config.transport.endpoint()); err != nil {
-			info.AgentError = fmt.Sprintf("%s", err.Error())
+			info.AgentError = err.Error()
 			log.Warn("DIAGNOSTICS Unable to reach agent intake: %s", err.Error())
 		}
 	}

ddtrace/tracer/option.go

@@ -1085,7 +1085,7 @@ func WithAgentURL(agentURL string) StartOption {
 					log.Warn("Fail to parse Agent URL: %s", urlErr.Err)
 					return
 				}
-				log.Warn("Fail to parse Agent URL")
+				log.Warn("Fail to parse Agent URL: %s", err.Error())
 				return
 			}
 			log.Warn("Fail to parse Agent URL: %s", err.Error())

ddtrace/tracer/rules_sampler.go

@@ -463,9 +463,10 @@ func (rs *traceRulesSampler) sampleRules(span *Span) bool {
 		if rule.match(span) {
 			matched = true
 			rate = rule.Rate
-			if rule.Provenance == Customer {
+			switch rule.Provenance {
+			case Customer:
 				sampler = samplernames.RemoteUserRule
-			} else if rule.Provenance == Dynamic {
+			case Dynamic:
 				sampler = samplernames.RemoteDynamicRule
 			}
 			break

ddtrace/tracer/span.go

@@ -970,7 +970,6 @@ const (
 	keySamplingPriority     = "_sampling_priority_v1"
 	keySamplingPriorityRate = "_dd.agent_psr"
 	keyDecisionMaker        = "_dd.p.dm"
-	keyServiceHash          = "_dd.dm.service_hash"
 	keyOrigin               = "_dd.origin"
 	keyReparentID           = "_dd.parent_id"
 	// keyHostname can be used to override the agent's hostname detection when using `WithHostname`.
@@ -1025,7 +1024,6 @@ const (
 	keyUserLogin     = "usr.login"
 	keyUserEmail     = "usr.email"
 	keyUserName      = "usr.name"
-	keyUserOrg       = "usr.org"
 	keyUserRole      = "usr.role"
 	keyUserScope     = "usr.scope"
 	keyUserSessionID = "usr.session_id"

ddtrace/tracer/tracer.go

@@ -21,7 +21,6 @@ import (
 
 	"github.com/DataDog/dd-trace-go/v2/ddtrace/ext"
 	"github.com/DataDog/dd-trace-go/v2/ddtrace/internal/tracerstats"
-	"github.com/DataDog/dd-trace-go/v2/internal"
 	globalinternal "github.com/DataDog/dd-trace-go/v2/internal"
 	"github.com/DataDog/dd-trace-go/v2/internal/appsec"
 	appsecConfig "github.com/DataDog/dd-trace-go/v2/internal/appsec/config"
@@ -290,7 +289,7 @@ func storeConfig(c *config) {
 		ServiceEnvironment: c.env,
 		ServiceVersion:     c.version,
 		ProcessTags:        processtags.GlobalTags().String(),
-		ContainerID:        internal.ContainerID(),
+		ContainerID:        globalinternal.ContainerID(),
 	}
 
 	data, _ := metadata.MarshalMsg(nil)

ddtrace/tracer/tracer_test.go

@@ -2760,25 +2760,25 @@ func TestExecutionTraceSpanTagged(t *testing.T) {
 
 func wasteA(d time.Duration) {
 	start := time.Now()
+	i := 0
 	for start.Add(d).Before(time.Now()) {
-		//lint:ignore S1039 We are intentionally creating empty prints
-		_ = fmt.Sprint("waste")
+		_ = fmt.Sprintf("waste %d", i)
 	}
 }
 
 func wasteB(d time.Duration) {
 	start := time.Now()
+	i := 0
 	for start.Add(d).Before(time.Now()) {
-		//lint:ignore S1039 We are intentionally creating empty prints
-		_ = fmt.Sprint("waste")
+		_ = fmt.Sprintf("waste %d", i)
 	}
 }
 
 func wasteC(d time.Duration) {
 	start := time.Now()
+	i := 0
 	for start.Add(d).Before(time.Now()) {
-		//lint:ignore S1039 We are intentionally creating empty prints
-		_ = fmt.Sprint("waste")
+		_ = fmt.Sprintf("waste %d", i)
 	}
 }