chore(ci): add nofilter for reviewdog (#4418)

kakkoyun · darccio · web-flow · commit f49f6702b1db · 2026-02-13T10:46:34.000Z
Co-authored-by: dario.castane &lt;dario.castane@datadoghq.com&gt;
diff --git a/.github/workflows/static-checks.yml b/.github/workflows/static-checks.yml
@@ -154,6 +154,7 @@ jobs:
           golangci_lint_version: ${{ env.GOLANGCI_LINT_VERSION }}
           fail_level: error
           reporter: github-pr-review
+          filter_mode: nofilter
 
       - name: golangci-lint (internal/orchestrion/_integration)
         uses: reviewdog/action-golangci-lint@f9bba13753278f6a73b27a56a3ffb1bfda90ed71 # v2.8.0
@@ -164,6 +165,7 @@ jobs:
           fail_level: error
           reporter: github-pr-review
           workdir: internal/orchestrion/_integration
+          filter_mode: nofilter
 
       - name: shellcheck
         uses: reviewdog/action-shellcheck@4c07458293ac342d477251099501a718ae5ef86e # v1.32.0
diff --git a/internal/orchestrion/_integration/chi.v5/chi.go b/internal/orchestrion/_integration/chi.v5/chi.go
@@ -48,6 +48,7 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/", tc.Server.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/echo.v4/echo.go b/internal/orchestrion/_integration/echo.v4/echo.go
@@ -47,11 +47,12 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get("http://" + tc.addr + "/ping")
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
 func (tc *TestCase) ExpectedTraces() trace.Traces {
-	httpUrl := "http://" + tc.addr + "/ping"
+	httpURL := "http://" + tc.addr + "/ping"
 	return trace.Traces{
 		{
 			// NB: 2 Top-level spans are from the HTTP Client/Server, which are library-side instrumented.
@@ -62,7 +63,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 				"type":     "http",
 			},
 			Meta: map[string]string{
-				"http.url":  httpUrl,
+				"http.url":  httpURL,
 				"component": "net/http",
 				"span.kind": "client",
 			},
@@ -75,7 +76,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 						"type":     "web",
 					},
 					Meta: map[string]string{
-						"http.url":  httpUrl,
+						"http.url":  httpURL,
 						"component": "net/http",
 						"span.kind": "server",
 					},
@@ -88,7 +89,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 								"type":     "web",
 							},
 							Meta: map[string]string{
-								"http.url":  httpUrl,
+								"http.url":  httpURL,
 								"component": "labstack/echo.v4",
 								"span.kind": "server",
 							},
diff --git a/internal/orchestrion/_integration/fiber.v2/fiber.go b/internal/orchestrion/_integration/fiber.v2/fiber.go
@@ -39,11 +39,12 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get("http://" + tc.addr + "/ping")
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
 func (tc *TestCase) ExpectedTraces() trace.Traces {
-	httpUrl := "http://" + tc.addr + "/ping"
+	httpURL := "http://" + tc.addr + "/ping"
 	return trace.Traces{
 		{
 			// NB: Top-level span is from the HTTP Client, which is library-side instrumented.
@@ -55,7 +56,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 				"type":     "http",
 			},
 			Meta: map[string]string{
-				"http.url":  httpUrl,
+				"http.url":  httpURL,
 				"component": "net/http",
 				"span.kind": "client",
 			},
diff --git a/internal/orchestrion/_integration/gin/base.go b/internal/orchestrion/_integration/gin/base.go
@@ -47,11 +47,12 @@ func (tc *TestCaseBase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCaseBase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get("http://" + tc.Server.Addr + "/ping")
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
 func (tc *TestCaseBase) ExpectedTraces() trace.Traces {
-	httpUrl := "http://" + tc.Server.Addr + "/ping"
+	httpURL := "http://" + tc.Server.Addr + "/ping"
 	return trace.Traces{
 		{
 			// NB: 2 Top-level spans are from the HTTP Client/Server, which are library-side instrumented.
@@ -62,7 +63,7 @@ func (tc *TestCaseBase) ExpectedTraces() trace.Traces {
 				"type":     "http",
 			},
 			Meta: map[string]string{
-				"http.url":  httpUrl,
+				"http.url":  httpURL,
 				"component": "net/http",
 				"span.kind": "client",
 			},
@@ -75,7 +76,7 @@ func (tc *TestCaseBase) ExpectedTraces() trace.Traces {
 						"type":     "web",
 					},
 					Meta: map[string]string{
-						"http.url":  httpUrl,
+						"http.url":  httpURL,
 						"component": "net/http",
 						"span.kind": "server",
 					},
@@ -89,7 +90,7 @@ func (tc *TestCaseBase) ExpectedTraces() trace.Traces {
 								"type":     "web",
 							},
 							Meta: map[string]string{
-								"http.url":  httpUrl,
+								"http.url":  httpURL,
 								"component": "gin-gonic/gin",
 								"span.kind": "server",
 							},
diff --git a/internal/orchestrion/_integration/gorilla_mux/gorilla_mux.go b/internal/orchestrion/_integration/gorilla_mux/gorilla_mux.go
@@ -52,6 +52,7 @@ func (tc *TestCaseSubrouter) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCaseSubrouter) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/sub/ping", tc.Server.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
@@ -180,6 +181,7 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/ping", tc.Server.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/graphql-go/graphql.go b/internal/orchestrion/_integration/graphql-go/graphql.go
@@ -53,7 +53,7 @@ func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 
 	resp, err := http.DefaultClient.Do(req)
 	require.NoError(t, err)
-	defer req.Body.Close()
+	defer resp.Body.Close()
 
 	body, err := io.ReadAll(resp.Body)
 	require.NoError(t, err)
diff --git a/internal/orchestrion/_integration/julienschmidt_httprouter/julienschmidt_httprouter.go b/internal/orchestrion/_integration/julienschmidt_httprouter/julienschmidt_httprouter.go
@@ -51,6 +51,7 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/ping", tc.Server.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/net_http/base.go b/internal/orchestrion/_integration/net_http/base.go
@@ -45,6 +45,7 @@ func (b *base) Setup(_ context.Context, t *testing.T) {
 func (b *base) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/", b.srv.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/net_http/client_error.go b/internal/orchestrion/_integration/net_http/client_error.go
@@ -46,6 +46,7 @@ func (b *TestCaseClientError) Setup(_ context.Context, t *testing.T) {
 func (b *TestCaseClientError) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get(fmt.Sprintf("http://%s/", b.srv.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusTeapot, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/net_http/global_functions.go b/internal/orchestrion/_integration/net_http/global_functions.go
@@ -27,18 +27,19 @@ func (tc *TestCaseGlobalFunctions) Setup(ctx context.Context, t *testing.T) {
 }
 
 func (tc *TestCaseGlobalFunctions) Run(_ context.Context, t *testing.T) {
-	cl := newHttpClient(tc.srv.Addr)
+	cl := newHTTPClient(tc.srv.Addr)
 
 	resp, err := cl.Get("/")
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
 type httpClient struct {
 	serverHost string
 }
 
-func newHttpClient(serverHost string) *httpClient {
+func newHTTPClient(serverHost string) *httpClient {
 	return &httpClient{
 		serverHost: serverHost,
 	}
diff --git a/internal/orchestrion/_integration/os/lfi.go b/internal/orchestrion/_integration/os/lfi.go
@@ -62,6 +62,7 @@ func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	tc.T = t
 	resp, err := http.Get(fmt.Sprintf("http://%s/?path=/etc/passwd", tc.Server.Addr))
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusForbidden, resp.StatusCode)
 }
 
diff --git a/internal/orchestrion/_integration/valyala_fasthttp/fasthttp.go b/internal/orchestrion/_integration/valyala_fasthttp/fasthttp.go
@@ -52,11 +52,12 @@ func (tc *TestCase) Setup(_ context.Context, t *testing.T) {
 func (tc *TestCase) Run(_ context.Context, t *testing.T) {
 	resp, err := http.Get("http://" + tc.Addr + "/ping")
 	require.NoError(t, err)
+	defer resp.Body.Close()
 	require.Equal(t, http.StatusOK, resp.StatusCode)
 }
 
 func (tc *TestCase) ExpectedTraces() trace.Traces {
-	httpUrl := "http://" + tc.Addr + "/ping"
+	httpURL := "http://" + tc.Addr + "/ping"
 	return trace.Traces{
 		{
 			// NB: 1 Top-level spans are from the HTTP Client, which are library-side instrumented.
@@ -67,7 +68,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 				"type":     "http",
 			},
 			Meta: map[string]string{
-				"http.url":  httpUrl,
+				"http.url":  httpURL,
 				"component": "net/http",
 				"span.kind": "client",
 			},
@@ -80,7 +81,7 @@ func (tc *TestCase) ExpectedTraces() trace.Traces {
 						"type":     "web",
 					},
 					Meta: map[string]string{
-						"http.url":    httpUrl,
+						"http.url":    httpURL,
 						"http.method": "GET",
 						"component":   "valyala/fasthttp",
 						"span.kind":   "server",

Original file line number	Diff line number	Diff line change
`@@ -48,6 +48,7 @@ func (tc TestCase) Setup(_ context.Context, t testing.T) {`
`48`	`48`	`func (tc TestCase) Run(_ context.Context, t testing.T) {`
`49`	`49`	`resp, err := http.Get(fmt.Sprintf("http://%s/", tc.Server.Addr))`
`50`	`50`	`require.NoError(t, err)`
	`51`	`+ defer resp.Body.Close()`
`51`	`52`	`require.Equal(t, http.StatusOK, resp.StatusCode)`
`52`	`53`	`}`
`53`	`54`
Original file line number	Diff line number	Diff line change
`@@ -52,6 +52,7 @@ func (tc TestCaseSubrouter) Setup(_ context.Context, t testing.T) {`
`52`	`52`	`func (tc TestCaseSubrouter) Run(_ context.Context, t testing.T) {`
`53`	`53`	`resp, err := http.Get(fmt.Sprintf("http://%s/sub/ping", tc.Server.Addr))`
`54`	`54`	`require.NoError(t, err)`
	`55`	`+ defer resp.Body.Close()`
`55`	`56`	`require.Equal(t, http.StatusOK, resp.StatusCode)`
`56`	`57`	`}`
`57`	`58`
`@@ -180,6 +181,7 @@ func (tc TestCase) Setup(_ context.Context, t testing.T) {`
`180`	`181`	`func (tc TestCase) Run(_ context.Context, t testing.T) {`
`181`	`182`	`resp, err := http.Get(fmt.Sprintf("http://%s/ping", tc.Server.Addr))`
`182`	`183`	`require.NoError(t, err)`
	`184`	`+ defer resp.Body.Close()`
`183`	`185`	`require.Equal(t, http.StatusOK, resp.StatusCode)`
`184`	`186`	`}`
`185`	`187`
Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,7 @@ func (tc TestCase) Setup(_ context.Context, t testing.T) {`
`51`	`51`	`func (tc TestCase) Run(_ context.Context, t testing.T) {`
`52`	`52`	`resp, err := http.Get(fmt.Sprintf("http://%s/ping", tc.Server.Addr))`
`53`	`53`	`require.NoError(t, err)`
	`54`	`+ defer resp.Body.Close()`
`54`	`55`	`require.Equal(t, http.StatusOK, resp.StatusCode)`
`55`	`56`	`}`
`56`	`57`
Original file line number	Diff line number	Diff line change
`@@ -45,6 +45,7 @@ func (b base) Setup(_ context.Context, t testing.T) {`
`45`	`45`	`func (b base) Run(_ context.Context, t testing.T) {`
`46`	`46`	`resp, err := http.Get(fmt.Sprintf("http://%s/", b.srv.Addr))`
`47`	`47`	`require.NoError(t, err)`
	`48`	`+ defer resp.Body.Close()`
`48`	`49`	`require.Equal(t, http.StatusOK, resp.StatusCode)`
`49`	`50`	`}`
`50`	`51`
Original file line number	Diff line number	Diff line change
`@@ -46,6 +46,7 @@ func (b TestCaseClientError) Setup(_ context.Context, t testing.T) {`
`46`	`46`	`func (b TestCaseClientError) Run(_ context.Context, t testing.T) {`
`47`	`47`	`resp, err := http.Get(fmt.Sprintf("http://%s/", b.srv.Addr))`
`48`	`48`	`require.NoError(t, err)`
	`49`	`+ defer resp.Body.Close()`
`49`	`50`	`require.Equal(t, http.StatusTeapot, resp.StatusCode)`
`50`	`51`	`}`
`51`	`52`