Skip to content

Commit 00f9f7f

Browse files
committed
feat(asm): Clean up blocker helper
1 parent e00f0eb commit 00f9f7f

File tree

2 files changed

+4
-23
lines changed

2 files changed

+4
-23
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,13 @@
11
package datadog.trace.instrumentation.jetty10;
22

3-
import datadog.trace.api.gateway.Flow;
4-
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
5-
import datadog.trace.bootstrap.instrumentation.api.AgentTracer;
3+
import datadog.context.Context;
64
import datadog.trace.instrumentation.jetty.JettyBlockingHelper;
75
import net.bytebuddy.asm.Advice;
86
import org.eclipse.jetty.server.HttpChannel;
97

108
public class DispatchableAdvice {
119
@Advice.OnMethodEnter(suppress = Throwable.class, skipOn = Advice.OnNonDefaultValue.class)
1210
public static boolean /* skip */ before(@Advice.FieldValue("this$0") HttpChannel channel) {
13-
AgentSpan span = AgentTracer.activeSpan();
14-
if (span == null) {
15-
return false;
16-
}
17-
Flow.Action.RequestBlockingAction rba = span.getRequestBlockingAction();
18-
if (rba == null) {
19-
return false;
20-
}
21-
22-
boolean blocked =
23-
JettyBlockingHelper.block(channel.getRequest(), channel.getResponse(), rba, span);
24-
return blocked;
11+
return JettyBlockingHelper.block(channel.getRequest(), channel.getResponse(), Context.current());
2512
}
2613
}

dd-java-agent/instrumentation/jetty-common/src/main/java/datadog/trace/instrumentation/jetty/JettyBlockingHelper.java

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -233,11 +233,6 @@ public static boolean block(Request request, Response response, Context context)
233233
if (span == null || (rba = span.getRequestBlockingAction()) == null) {
234234
return false;
235235
}
236-
return block(request, response, rba, span);
237-
}
238-
239-
public static boolean block(
240-
Request request, Response response, Flow.Action.RequestBlockingAction rba, AgentSpan span) {
241236
return block(
242237
span.getRequestContext().getTraceSegment(),
243238
request,
@@ -247,9 +242,8 @@ public static boolean block(
247242
rba.getExtraHeaders());
248243
}
249244

250-
public static void blockAndThrowOnFailure(
251-
Request request, Response response, Flow.Action.RequestBlockingAction rba, AgentSpan span) {
252-
if (!block(request, response, rba, span)) {
245+
public static void blockAndThrowOnFailure(Request request, Response response, Context context) {
246+
if (!block(request, response, context)) {
253247
throw new BlockingException("Throwing after being unable to commit blocking response");
254248
}
255249
}

0 commit comments

Comments
 (0)