Skip to content

Commit 03a5c70

Browse files
committed
Extend HttpClientTest2 for Apache, Grizzly, and Jetty 9.1
1 parent 5facb70 commit 03a5c70

File tree

10 files changed

+20
-20
lines changed

10 files changed

+20
-20
lines changed

dd-java-agent/instrumentation/apache-httpasyncclient-4/src/test/groovy/ApacheHttpAsyncClientCallbackTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpasyncclient.ApacheHttpAsyncClientDecorator
44
import org.apache.http.HttpResponse
@@ -14,7 +14,7 @@ import java.util.concurrent.CompletableFuture
1414
import java.util.concurrent.TimeUnit
1515

1616
@Timeout(5)
17-
class ApacheHttpAsyncClientCallbackTest extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0 {
17+
class ApacheHttpAsyncClientCallbackTest extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0 {
1818

1919
@Shared
2020
RequestConfig requestConfig = RequestConfig.custom()

dd-java-agent/instrumentation/apache-httpasyncclient-4/src/test/groovy/ApacheHttpAsyncClientNullCallbackTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpasyncclient.ApacheHttpAsyncClientDecorator
44
import org.apache.http.client.config.RequestConfig
@@ -11,7 +11,7 @@ import spock.lang.Timeout
1111
import java.util.concurrent.Future
1212

1313
@Timeout(5)
14-
class ApacheHttpAsyncClientNullCallbackTest extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0{
14+
class ApacheHttpAsyncClientNullCallbackTest extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0{
1515

1616
@Shared
1717
RequestConfig requestConfig = RequestConfig.custom()

dd-java-agent/instrumentation/apache-httpasyncclient-4/src/test/groovy/ApacheHttpAsyncClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import datadog.trace.agent.test.asserts.TraceAssert
2-
import datadog.trace.agent.test.base.HttpClientTest
2+
import datadog.trace.agent.test.base.HttpClientTest2
33
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
44
import datadog.trace.instrumentation.apachehttpasyncclient.ApacheHttpAsyncClientDecorator
55
import org.apache.http.HttpHost
@@ -16,7 +16,7 @@ import spock.lang.Timeout
1616
import java.util.concurrent.CountDownLatch
1717

1818
@Timeout(5)
19-
abstract class ApacheHttpAsyncClientTest extends HttpClientTest {
19+
abstract class ApacheHttpAsyncClientTest extends HttpClientTest2 {
2020

2121
@Shared
2222
RequestConfig requestConfig = RequestConfig.custom()

dd-java-agent/instrumentation/apache-httpclient-4/src/test/groovy/ApacheHttpClientResponseHandlerTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpclient.ApacheHttpClientDecorator
44
import org.apache.http.HttpResponse
@@ -11,7 +11,7 @@ import spock.lang.Shared
1111
import spock.lang.Timeout
1212

1313
@Timeout(5)
14-
class ApacheHttpClientResponseHandlerTest extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0 {
14+
class ApacheHttpClientResponseHandlerTest extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0 {
1515

1616
@Shared
1717
def client = new DefaultHttpClient()

dd-java-agent/instrumentation/apache-httpclient-4/src/test/groovy/ApacheHttpClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpclient.ApacheHttpClientDecorator
44
import org.apache.http.HttpHost
@@ -13,7 +13,7 @@ import org.apache.http.protocol.BasicHttpContext
1313
import spock.lang.Shared
1414
import spock.lang.Timeout
1515

16-
abstract class ApacheHttpClientTest<T extends HttpRequest> extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0 {
16+
abstract class ApacheHttpClientTest<T extends HttpRequest> extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0 {
1717
@Shared
1818
def client = new DefaultHttpClient()
1919

dd-java-agent/instrumentation/apache-httpclient-5/src/test/groovy/ApacheHttpAsyncClient5Test.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpclient5.ApacheHttpClientDecorator
44
import org.apache.hc.client5.http.async.methods.SimpleHttpRequests
@@ -12,7 +12,7 @@ import java.util.concurrent.TimeUnit
1212

1313
import static org.apache.hc.core5.reactor.IOReactorConfig.custom
1414

15-
abstract class ApacheHttpAsyncClient5Test<T extends HttpRequest> extends HttpClientTest {
15+
abstract class ApacheHttpAsyncClient5Test<T extends HttpRequest> extends HttpClientTest2 {
1616

1717
@Shared
1818
def ioReactorConfig = custom()

dd-java-agent/instrumentation/apache-httpclient-5/src/test/groovy/ApacheHttpClientResponseHandlerTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpclient5.ApacheHttpClientDecorator
44
import org.apache.hc.client5.http.config.RequestConfig
@@ -15,7 +15,7 @@ import spock.lang.Timeout
1515
import java.util.concurrent.TimeUnit
1616

1717
@Timeout(5)
18-
class ApacheHttpClientResponseHandlerTest extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0 {
18+
class ApacheHttpClientResponseHandlerTest extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0 {
1919

2020
@Shared
2121
def client = HttpClients.custom()

dd-java-agent/instrumentation/apache-httpclient-5/src/test/groovy/ApacheHttpClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import datadog.trace.instrumentation.apachehttpclient5.ApacheHttpClientDecorator
44
import org.apache.hc.client5.http.config.RequestConfig
@@ -16,7 +16,7 @@ import spock.lang.Timeout
1616

1717
import java.util.concurrent.TimeUnit
1818

19-
abstract class ApacheHttpClientTest<T extends HttpRequest> extends HttpClientTest implements TestingGenericHttpNamingConventions.ClientV0 {
19+
abstract class ApacheHttpClientTest<T extends HttpRequest> extends HttpClientTest2 implements TestingGenericHttpNamingConventions.ClientV0 {
2020

2121
@Shared
2222
def client = HttpClients.custom()

dd-java-agent/instrumentation/grizzly-client-1.9/src/test/groovy/GrizzlyAsyncHttpClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,15 @@ import com.ning.http.client.Request
77
import com.ning.http.client.RequestBuilder
88
import com.ning.http.client.Response
99
import com.ning.http.client.uri.Uri
10-
import datadog.trace.agent.test.base.HttpClientTest
10+
import datadog.trace.agent.test.base.HttpClientTest2
1111
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
1212
import datadog.trace.instrumentation.grizzly.client.ClientDecorator
1313
import spock.lang.AutoCleanup
1414
import spock.lang.Shared
1515

1616
import java.util.concurrent.Executors
1717

18-
abstract class GrizzlyAsyncHttpClientTest extends HttpClientTest {
18+
abstract class GrizzlyAsyncHttpClientTest extends HttpClientTest2 {
1919

2020
@AutoCleanup
2121
@Shared

dd-java-agent/instrumentation/jetty-client/jetty-client-9.1/src/test/groovy/JettyClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import datadog.trace.agent.test.base.HttpClientTest
1+
import datadog.trace.agent.test.base.HttpClientTest2
22
import datadog.trace.agent.test.naming.TestingGenericHttpNamingConventions
33
import org.eclipse.jetty.client.HttpClient
44
import org.eclipse.jetty.client.HttpProxy
@@ -13,7 +13,7 @@ import spock.lang.Subject
1313

1414
import java.util.concurrent.ExecutionException
1515

16-
abstract class JettyClientTest extends HttpClientTest {
16+
abstract class JettyClientTest extends HttpClientTest2 {
1717

1818
@Shared
1919
@Subject

0 commit comments

Comments
 (0)