Skip to content

Commit 04509c8

Browse files
Add debug logging to Android Gradle module layout logic
1 parent a69247f commit 04509c8

File tree

5 files changed

+20
-15
lines changed

5 files changed

+20
-15
lines changed

dd-java-agent/instrumentation/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/AndroidGradleUtils.groovy

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
11
package datadog.trace.instrumentation.gradle
22

3+
34
import datadog.trace.api.civisibility.domain.BuildModuleLayout
45
import datadog.trace.api.civisibility.domain.SourceSet
56
import org.gradle.api.Project
67
import org.gradle.api.file.FileTree
7-
import org.gradle.api.logging.Logger
8-
import org.gradle.api.logging.Logging
98
import org.gradle.api.tasks.testing.Test
9+
import org.slf4j.Logger
10+
import org.slf4j.LoggerFactory
1011

1112
import java.nio.file.Files
1213
import java.nio.file.Paths
1314

1415
class AndroidGradleUtils {
1516

16-
private static final Logger LOGGER = Logging.getLogger(AndroidGradleUtils)
17+
private static final Logger LOGGER = LoggerFactory.getLogger(AndroidGradleUtils.class)
1718

1819
static BuildModuleLayout getAndroidModuleLayout(Project project, Test task) {
1920
try {
@@ -22,6 +23,7 @@ class AndroidGradleUtils {
2223
return null
2324
}
2425

26+
LOGGER.debug("Found Android plugin variant: {} for task {}", variant.name, task.path)
2527
def sources = getSources(variant)
2628
def destinations = getDestinations(variant, project)
2729
return new BuildModuleLayout(Collections.singletonList(new SourceSet(SourceSet.Type.CODE, sources, destinations)))
@@ -37,6 +39,7 @@ class AndroidGradleUtils {
3739
?: project.plugins.findPlugin('com.android.application')
3840
?: project.plugins.findPlugin('com.android.library')
3941

42+
LOGGER.debug("Found Android plugin: {}", androidPlugin.getClass().getName())
4043
def variants
4144
if (androidPlugin.class.simpleName == 'LibraryPlugin') {
4245
variants = project.android.libraryVariants
@@ -88,6 +91,8 @@ class AndroidGradleUtils {
8891
} else {
8992
destinationsTree = javaTree
9093
}
94+
95+
LOGGER.debug("Using destination tree: {}", destinationsTree.sourceTrees)
9196
return destinationsTree.files
9297
}
9398

dd-java-agent/instrumentation/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/CiVisibilityGradleListenerInjector_8_10.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,17 +3,17 @@
33
import java.lang.reflect.Method;
44
import java.lang.reflect.Proxy;
55
import java.util.Arrays;
6-
import org.gradle.api.logging.Logger;
7-
import org.gradle.api.logging.Logging;
86
import org.gradle.initialization.ClassLoaderRegistry;
97
import org.gradle.internal.service.DefaultServiceRegistry;
108
import org.gradle.internal.service.ServiceRegistration;
119
import org.gradle.internal.service.ServiceRegistry;
10+
import org.slf4j.Logger;
11+
import org.slf4j.LoggerFactory;
1212

1313
public class CiVisibilityGradleListenerInjector_8_10 {
1414

1515
private static final Logger LOGGER =
16-
Logging.getLogger(CiVisibilityGradleListenerInjector_8_10.class);
16+
LoggerFactory.getLogger(CiVisibilityGradleListenerInjector_8_10.class);
1717

1818
/**
1919
* Performs listener injection for Gradle v8.10+. As the tracer currently uses v8.4, some of the

dd-java-agent/instrumentation/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/CiVisibilityGradleListenerInjector_8_3.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,16 @@
11
package datadog.trace.instrumentation.gradle;
22

33
import java.util.Arrays;
4-
import org.gradle.api.logging.Logger;
5-
import org.gradle.api.logging.Logging;
64
import org.gradle.initialization.ClassLoaderRegistry;
75
import org.gradle.internal.service.DefaultServiceRegistry;
86
import org.gradle.internal.service.ServiceRegistry;
7+
import org.slf4j.Logger;
8+
import org.slf4j.LoggerFactory;
99

1010
public class CiVisibilityGradleListenerInjector_8_3 {
1111

1212
private static final Logger LOGGER =
13-
Logging.getLogger(CiVisibilityGradleListenerInjector_8_3.class);
13+
LoggerFactory.getLogger(CiVisibilityGradleListenerInjector_8_3.class);
1414

1515
/** Performs listener injection for Gradle v8.3 - 8.9 */
1616
public static void injectCiVisibilityGradleListener(

dd-java-agent/instrumentation/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/CiVisibilityPlugin.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,18 +15,18 @@
1515
import org.gradle.api.Project;
1616
import org.gradle.api.artifacts.Configuration;
1717
import org.gradle.api.file.SourceDirectorySet;
18-
import org.gradle.api.logging.Logger;
19-
import org.gradle.api.logging.Logging;
2018
import org.gradle.api.tasks.SourceSet;
2119
import org.gradle.api.tasks.SourceSetContainer;
2220
import org.gradle.api.tasks.SourceSetOutput;
2321
import org.gradle.api.tasks.compile.JavaCompile;
2422
import org.gradle.api.tasks.testing.Test;
2523
import org.gradle.testing.jacoco.plugins.JacocoPluginExtension;
24+
import org.slf4j.Logger;
25+
import org.slf4j.LoggerFactory;
2626

2727
public abstract class CiVisibilityPlugin implements Plugin<Project> {
2828

29-
private static final Logger LOGGER = Logging.getLogger(CiVisibilityPlugin.class);
29+
private static final Logger LOGGER = LoggerFactory.getLogger(CiVisibilityPlugin.class);
3030

3131
private static final String PLUGIN_EXTENSION_NAME = "dd-ci-visibility";
3232
private static final String JACOCO_PLUGIN_ID = "jacoco";

dd-java-agent/instrumentation/gradle-8.3/src/main/groovy/datadog/trace/instrumentation/gradle/CiVisibilityPluginExtension.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import java.util.stream.Collectors;
1212
import javax.inject.Inject;
1313
import org.gradle.api.file.FileCollection;
14-
import org.gradle.api.logging.Logger;
15-
import org.gradle.api.logging.Logging;
1614
import org.gradle.api.model.ObjectFactory;
1715
import org.gradle.api.provider.Property;
1816
import org.gradle.api.services.ServiceReference;
@@ -24,10 +22,12 @@
2422
import org.gradle.jvm.toolchain.JavaLauncher;
2523
import org.gradle.process.CommandLineArgumentProvider;
2624
import org.gradle.testing.jacoco.plugins.JacocoTaskExtension;
25+
import org.slf4j.Logger;
26+
import org.slf4j.LoggerFactory;
2727

2828
public abstract class CiVisibilityPluginExtension {
2929

30-
private static final Logger LOGGER = Logging.getLogger(CiVisibilityPluginExtension.class);
30+
private static final Logger LOGGER = LoggerFactory.getLogger(CiVisibilityPluginExtension.class);
3131

3232
public static final String MODULE_LAYOUT_PROPERTY = "moduleLayout";
3333

0 commit comments

Comments
 (0)