Skip to content

Commit 0782d95

Browse files
Fix tests for the testing module
1 parent 5487517 commit 0782d95

File tree

3 files changed

+8
-16
lines changed

3 files changed

+8
-16
lines changed

dd-java-agent/testing/src/main/groovy/datadog/trace/agent/test/SpockExtension.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ public void handleTestExecutionException(ExtensionContext ctx, Throwable ex) thr
6161
throw ex;
6262
}
6363

64-
private static void fixTooManyInvocationsError(final TooManyInvocationsError error) {
64+
static void fixTooManyInvocationsError(final TooManyInvocationsError error) {
6565
final List<IMockInvocation> accepted = error.getAcceptedInvocations();
6666
for (final IMockInvocation invocation : accepted) {
6767
try {

dd-java-agent/testing/src/test/groovy/AgentTestRunnerTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import com.google.common.reflect.ClassPath
22
import datadog.trace.agent.test.AgentTestRunner
3-
import datadog.trace.agent.test.SpockRunner
3+
import datadog.trace.agent.test.BootstrapClasspathSetup
44
import datadog.trace.agent.test.utils.ClasspathUtils
55
import datadog.trace.api.GlobalTracer
66
import datadog.trace.api.Platform
@@ -37,7 +37,7 @@ class AgentTestRunnerTest extends AgentTestRunner {
3737

3838
def "spock runner bootstrap prefixes correct for test setup"() {
3939
expect:
40-
SpockRunner.BOOTSTRAP_PACKAGE_PREFIXES_COPY == Constants.BOOTSTRAP_PACKAGE_PREFIXES
40+
BootstrapClasspathSetup.BOOTSTRAP_PACKAGE_PREFIXES_COPY == Constants.BOOTSTRAP_PACKAGE_PREFIXES
4141
}
4242

4343
def "classpath setup"() {

dd-java-agent/testing/src/test/groovy/TooManyInvocationsErrorListenerTest.groovy

Lines changed: 5 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,6 @@
11
import datadog.trace.agent.test.AgentTestRunner
2-
import datadog.trace.agent.test.SpockRunner
3-
import org.junit.runner.Description
4-
import org.junit.runner.notification.Failure
5-
import org.spockframework.mock.IMockInteraction
6-
import org.spockframework.mock.IMockMethod
7-
import org.spockframework.mock.IMockObject
8-
import org.spockframework.mock.IResponseGenerator
9-
import org.spockframework.mock.TooManyInvocationsError
2+
import datadog.trace.agent.test.SpockExtension
3+
import org.spockframework.mock.*
104
import org.spockframework.mock.runtime.MockInvocation
115

126
class TooManyInvocationsErrorListenerTest extends AgentTestRunner {
@@ -19,18 +13,16 @@ class TooManyInvocationsErrorListenerTest extends AgentTestRunner {
1913
Stub(IMockMethod),
2014
[error],
2115
Stub(IResponseGenerator)))
22-
final failure = new Failure(new Description(TooManyInvocationsErrorListenerTest, 'test'), error)
2316

2417
when:
25-
failure.getMessage()
18+
error.getMessage()
2619

2720
then:
2821
thrown(StackOverflowError)
2922

3023
when:
31-
final listener = new SpockRunner.TooManyInvocationsErrorListener()
32-
listener.testFailure(failure)
33-
failure.getMessage()
24+
SpockExtension.fixTooManyInvocationsError(error)
25+
error.getMessage()
3426

3527
then:
3628
noExceptionThrown()

0 commit comments

Comments
 (0)