Add injection initialization success telemetry

Author: sarahchen6

internal-api/src/main/java/datadog/trace/api/rum/RumInjector.java

@@ -132,6 +132,10 @@ public static void enableTelemetry(datadog.trace.api.StatsDClient statsDClient)
       RumInjectorMetrics metrics = new RumInjectorMetrics(statsDClient);
       metrics.start();
       telemetryCollector = metrics;
+
+      if (INSTANCE.isEnabled()) {
+        telemetryCollector.onInitializationSucceed();
+      }
     } else {
       telemetryCollector = RumTelemetryCollector.NO_OP;
     }

internal-api/src/main/java/datadog/trace/api/rum/RumInjectorMetrics.java

@@ -24,6 +24,7 @@ public class RumInjectorMetrics implements RumTelemetryCollector {
   private final AtomicLong injectionFailed = new AtomicLong();
   private final AtomicLong injectionSkipped = new AtomicLong();
   private final AtomicLong contentSecurityPolicyDetected = new AtomicLong();
+  private final AtomicLong initializationSucceed = new AtomicLong();
 
   private final StatsDClient statsd;
   private final long interval;
@@ -62,6 +63,11 @@ public void onInjectionSkipped() {
     injectionSkipped.incrementAndGet();
   }
 
+  @Override
+  public void onInitializationSucceed() {
+    initializationSucceed.incrementAndGet();
+  }
+
   @Override
   public void onContentSecurityPolicyDetected() {
     contentSecurityPolicyDetected.incrementAndGet();
@@ -93,12 +99,14 @@ public String summary() {
         + "\ninjectionSkipped="
         + injectionSkipped.get()
         + "\ncontentSecurityPolicyDetected="
-        + contentSecurityPolicyDetected.get();
+        + contentSecurityPolicyDetected.get()
+        + "\ninitializationSucceed="
+        + initializationSucceed.get();
   }
 
   private static class Flush implements AgentTaskScheduler.Task<RumInjectorMetrics> {
 
-    private final long[] previousCounts = new long[4]; // one per counter
+    private final long[] previousCounts = new long[5]; // one per counter
     private int countIndex;
 
     @Override
@@ -113,6 +121,11 @@ public void run(RumInjectorMetrics target) {
             "rum.injection.content_security_policy",
             target.contentSecurityPolicyDetected,
             NO_TAGS);
+        reportIfChanged(
+            target.statsd,
+            "rum.injection.initialization.succeed",
+            target.initializationSucceed,
+            NO_TAGS);
       } catch (ArrayIndexOutOfBoundsException e) {
         log.warn(
             "previousCounts array needs resizing to at least {}, was {}",

internal-api/src/main/java/datadog/trace/api/rum/RumTelemetryCollector.java

@@ -18,6 +18,9 @@ public void onInjectionFailed() {}
         @Override
         public void onInjectionSkipped() {}
 
+        @Override
+        public void onInitializationSucceed() {}
+
         @Override
         public void onContentSecurityPolicyDetected() {}
 
@@ -47,6 +50,9 @@ default void start() {}
   // call when RUM injection is skipped
   void onInjectionSkipped();
 
+  // call when RUM injector initialization succeeds
+  void onInitializationSucceed();
+
   // call when a Content Security Policy header is detected
   void onContentSecurityPolicyDetected();
 

internal-api/src/test/groovy/datadog/trace/api/rum/RumInjectorMetricsTest.groovy

@@ -85,9 +85,27 @@ class RumInjectorMetricsTest extends Specification {
     metrics.close()
   }
 
+  def "test onInitializationSucceed"() {
+    setup:
+    def latch = new CountDownLatch(1)
+    def metrics = new RumInjectorMetrics(new Latched(statsD, latch), 10, TimeUnit.MILLISECONDS)
+    metrics.start()
+
+    when:
+    metrics.onInitializationSucceed()
+    latch.await(5, TimeUnit.SECONDS)
+
+    then:
+    1 * statsD.count('rum.injection.initialization.succeed', 1, _)
+    0 * _
+
+    cleanup:
+    metrics.close()
+  }
+
   def "test multiple events"() {
     setup:
-    def latch = new CountDownLatch(4) // expecting 4 metric types
+    def latch = new CountDownLatch(5) // expecting 5 metric types
     def metrics = new RumInjectorMetrics(new Latched(statsD, latch), 10, TimeUnit.MILLISECONDS)
     metrics.start()
 
@@ -96,13 +114,15 @@ class RumInjectorMetricsTest extends Specification {
     metrics.onInjectionFailed()
     metrics.onInjectionSkipped()
     metrics.onContentSecurityPolicyDetected()
+    metrics.onInitializationSucceed()
     latch.await(5, TimeUnit.SECONDS)
 
     then:
     1 * statsD.count('rum.injection.succeed', 1, _)
     1 * statsD.count('rum.injection.failed', 1, _)
     1 * statsD.count('rum.injection.skipped', 1, _)
     1 * statsD.count('rum.injection.content_security_policy', 1, _)
+    1 * statsD.count('rum.injection.initialization.succeed', 1, _)
     0 * _
 
     cleanup:
@@ -142,13 +162,15 @@ class RumInjectorMetricsTest extends Specification {
     metrics.onInjectionSucceed()
     metrics.onInjectionSkipped()
     metrics.onContentSecurityPolicyDetected()
+    metrics.onInitializationSucceed()
     def summary = metrics.summary()
 
     then:
     summary.contains("injectionSucceed=3")
     summary.contains("injectionFailed=2")
     summary.contains("injectionSkipped=1")
     summary.contains("contentSecurityPolicyDetected=2")
+    summary.contains("initializationSucceed=1")
     0 * _
   }
 
@@ -161,6 +183,7 @@ class RumInjectorMetricsTest extends Specification {
     summary.contains("injectionFailed=0")
     summary.contains("injectionSkipped=0")
     summary.contains("contentSecurityPolicyDetected=0")
+    summary.contains("initializationSucceed=0")
     0 * _
   }
 

internal-api/src/test/groovy/datadog/trace/api/rum/RumInjectorTest.groovy

@@ -118,6 +118,20 @@ class RumInjectorTest extends DDSpecification {
     RumInjector.getTelemetryCollector() == RumTelemetryCollector.NO_OP
   }
 
+  void 'content security policy HTTP response detected'() {
+    when:
+    RumInjector.enableTelemetry(mock(datadog.trace.api.StatsDClient))
+    def telemetryCollector = RumInjector.getTelemetryCollector()
+    telemetryCollector.onContentSecurityPolicyDetected()
+    def summary = telemetryCollector.summary()
+
+    then:
+    summary.contains("contentSecurityPolicyDetected=1")
+
+    cleanup:
+    RumInjector.shutdownTelemetry()
+  }
+
   void 'telemetry integration works end-to-end'() {
     when:
     // simulate CoreTracer enabling telemetry
@@ -140,6 +154,7 @@ class RumInjectorTest extends DDSpecification {
     summary.contains("injectionFailed=1")
     summary.contains("injectionSkipped=1")
     summary.contains("contentSecurityPolicyDetected=1")
+    summary.contains("initializationSucceed=0") // rum injector not initialized in test environment
 
     cleanup:
     RumInjector.shutdownTelemetry()
@@ -216,4 +231,18 @@ class RumInjectorTest extends DDSpecification {
     cleanup:
     RumInjector.shutdownTelemetry()
   }
+
+  void 'initialize rum injector successfully'() {
+    when:
+    RumInjector.enableTelemetry(mock(datadog.trace.api.StatsDClient))
+    def telemetryCollector = RumInjector.getTelemetryCollector()
+    telemetryCollector.onInitializationSucceed()
+    def summary = telemetryCollector.summary()
+
+    then:
+    summary.contains("initializationSucceed=1")
+
+    cleanup:
+    RumInjector.shutdownTelemetry()
+  }
 }