Skip to content

Commit 08c4cf3

Browse files
committed
wip
1 parent bf6c156 commit 08c4cf3

File tree

2 files changed

+32
-13
lines changed

2 files changed

+32
-13
lines changed

telemetry/src/main/java/datadog/telemetry/TelemetryRequestBody.java

Lines changed: 18 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -317,18 +317,30 @@ public void beginEndpoints() throws IOException {
317317

318318
public void writeEndpoint(final Endpoint endpoint) throws IOException {
319319
bodyWriter.beginObject();
320-
bodyWriter.name("type").value(endpoint.getType());
321-
bodyWriter.name("method").value(endpoint.getMethod());
322-
bodyWriter.name("path").value(endpoint.getPath());
323-
bodyWriter.name("operation-name").value(endpoint.getOperation());
320+
if (endpoint.getType() != null) {
321+
bodyWriter.name("type").value(endpoint.getType());
322+
}
323+
if (endpoint.getMethod() != null) {
324+
bodyWriter.name("method").value(endpoint.getMethod());
325+
}
326+
if (endpoint.getPath() != null) {
327+
bodyWriter.name("path").value(endpoint.getPath());
328+
}
329+
bodyWriter.name("operation_name").value(endpoint.getOperation());
330+
bodyWriter
331+
.name("resource_name")
332+
.value(
333+
endpoint.getMethod() != null && endpoint.getPath() != null
334+
? endpoint.getMethod() + " " + endpoint.getPath()
335+
: "UNDEFINED");
324336
if (endpoint.getRequestBodyType() != null) {
325337
bodyWriter.name("request-body-type").jsonValue(endpoint.getRequestBodyType());
326338
}
327339
if (endpoint.getResponseBodyType() != null) {
328-
bodyWriter.name("response-body-type").jsonValue(endpoint.getResponseBodyType());
340+
bodyWriter.name("response_body_type").jsonValue(endpoint.getResponseBodyType());
329341
}
330342
if (endpoint.getResponseCode() != null) {
331-
bodyWriter.name("response-code").jsonValue(endpoint.getResponseCode());
343+
bodyWriter.name("response_code").jsonValue(endpoint.getResponseCode());
332344
}
333345
if (endpoint.getAuthentication() != null) {
334346
bodyWriter.name("authentication").jsonValue(endpoint.getAuthentication());

telemetry/src/test/groovy/datadog/telemetry/TestTelemetryRouter.groovy

Lines changed: 14 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -273,22 +273,29 @@ class TestTelemetryRouter extends TelemetryRouter {
273273
def expected = []
274274
endpoints.each {
275275
final item = [
276-
'type' : it.type,
277-
'method' : it.method,
278-
'path' : it.path,
279-
'operation-name': it.operation
276+
'operation_name': it.operation,
277+
'resource_name' : it.method + ' ' + it.path,
280278
] as Map<String, Object>
279+
if (it.type) {
280+
item['type'] = it.type
281+
}
282+
if (it.method) {
283+
item['method'] = it.method
284+
}
285+
if (it.path) {
286+
item['path'] = it.path
287+
}
281288
if (it.requestBodyType) {
282-
item['request-body-type'] = it.requestBodyType
289+
item['request_body_type'] = it.requestBodyType
283290
}
284291
if (it.responseBodyType) {
285-
item['response-body-type'] = it.responseBodyType
292+
item['response_body_type'] = it.responseBodyType
286293
}
287294
if (it.authentication) {
288295
item['authentication'] = it.authentication
289296
}
290297
if (it.responseCode) {
291-
item['response-code'] = it.responseCode
298+
item['response_code'] = it.responseCode
292299
}
293300
if (it.metadata) {
294301
item['metadata'] = it.metadata

0 commit comments

Comments
 (0)