use throwStableConfigMappingException helper function

Author: mtoffl01

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Rule.java

@@ -28,16 +28,14 @@ public Rule(List<Selector> selectors, Map<String, Object> configuration) {
   public static Rule from(Map<?, ?> map) {
     Object selectorsObj = map.get("selectors");
     if (selectorsObj == null) {
-      throw new StableConfigMappingException(
-          "Missing 'selectors' in rule: " + StableConfigMappingException.safeToString(map));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "Missing 'selectors' in rule", map);
     }
 
     if (!(selectorsObj instanceof List)) {
-      throw new StableConfigMappingException(
-          "'selectors' must be a list, but got: "
-              + selectorsObj.getClass().getSimpleName()
-              + ", value: "
-              + StableConfigMappingException.safeToString(selectorsObj));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "'selectors' must be a list, but got: " + selectorsObj.getClass().getSimpleName(),
+          selectorsObj);
     }
 
     List<Selector> selectors =
@@ -50,25 +48,23 @@ public static Rule from(Map<?, ?> map) {
                           if (s instanceof Map) {
                             return Selector.from((Map<?, ?>) s);
                           }
-                          throw new StableConfigMappingException(
+                          StableConfigMappingException.throwStableConfigMappingException(
                               "Each selector must be a map, but got: "
-                                  + s.getClass().getSimpleName()
-                                  + ", value: "
-                                  + StableConfigMappingException.safeToString(s));
+                                  + s.getClass().getSimpleName(),
+                              s);
+                          return null;
                         })
                     .collect(toList()));
 
     Object configObj = map.get("configuration");
     if (configObj == null) {
-      throw new StableConfigMappingException(
-          "Missing 'configuration' in rule: " + StableConfigMappingException.safeToString(map));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "Missing 'configuration' in rule", map);
     }
     if (!(configObj instanceof Map)) {
-      throw new StableConfigMappingException(
-          "'configuration' must be a map, but got: "
-              + configObj.getClass().getSimpleName()
-              + ", value: "
-              + StableConfigMappingException.safeToString(configObj));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "'configuration' must be a map, but got: " + configObj.getClass().getSimpleName(),
+          configObj);
     }
     Map<String, Object> configuration = (Map<String, Object>) configObj;
 

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/Selector.java

@@ -20,15 +20,12 @@ public Selector(String origin, String key, List<String> matches, String operator
   public static Selector from(Map<?, ?> map) {
     Object originObj = map.get("origin");
     if (originObj == null) {
-      throw new StableConfigMappingException(
-          "Missing 'origin' in selector: " + StableConfigMappingException.safeToString(map));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "Missing 'origin' in selector", map);
     }
     if (!(originObj instanceof String)) {
-      throw new StableConfigMappingException(
-          "'origin' must be a string, but got: "
-              + originObj.getClass().getSimpleName()
-              + ", value: "
-              + StableConfigMappingException.safeToString(originObj));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "'origin' must be a string, but got: " + originObj.getClass().getSimpleName(), originObj);
     }
     String origin = (String) originObj;
 
@@ -37,27 +34,23 @@ public static Selector from(Map<?, ?> map) {
 
     Object matchesObj = map.get("matches");
     if (matchesObj != null && !(matchesObj instanceof List)) {
-      throw new StableConfigMappingException(
-          "'matches' must be a list, but got: "
-              + matchesObj.getClass().getSimpleName()
-              + ", value: "
-              + StableConfigMappingException.safeToString(matchesObj));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "'matches' must be a list, but got: " + matchesObj.getClass().getSimpleName(),
+          matchesObj);
     }
     List<String> rawMatches = (List<String>) matchesObj;
     List<String> matches =
         rawMatches != null ? Collections.unmodifiableList(rawMatches) : Collections.emptyList();
 
     Object operatorObj = map.get("operator");
     if (operatorObj == null) {
-      throw new StableConfigMappingException(
-          "Missing 'operator' in selector: " + StableConfigMappingException.safeToString(map));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "Missing 'operator' in selector", map);
     }
     if (!(operatorObj instanceof String)) {
-      throw new StableConfigMappingException(
-          "'operator' must be a string, but got: "
-              + operatorObj.getClass().getSimpleName()
-              + ", value: "
-              + StableConfigMappingException.safeToString(operatorObj));
+      StableConfigMappingException.throwStableConfigMappingException(
+          "'operator' must be a string, but got: " + operatorObj.getClass().getSimpleName(),
+          operatorObj);
     }
     String operator = (String) operatorObj;
 

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfig.java

@@ -51,12 +51,9 @@ private List<Rule> parseRules(Map<?, ?> map) {
         if (ruleObj instanceof Map) {
           rules.add(Rule.from((Map<?, ?>) ruleObj));
         } else {
-          // Log or throw with a detailed message
-          throw new StableConfigMappingException(
-              "Rule must be a map, but got: "
-                  + (ruleObj == null ? "null" : ruleObj.getClass().getSimpleName())
-                  + ", value: "
-                  + StableConfigMappingException.safeToString(ruleObj));
+          StableConfigMappingException.throwStableConfigMappingException(
+              "Rule must be a map, but got: " + ruleObj.getClass().getSimpleName(), ruleObj);
+          return emptyList();
         }
       }
       return unmodifiableList(rules);

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/stableconfig/StableConfigMappingException.java

@@ -1,18 +1,22 @@
 package datadog.trace.bootstrap.config.provider.stableconfig;
 
 public class StableConfigMappingException extends RuntimeException {
-  private static final int maxLen = 10;
+  private static final int maxLen = 100;
 
   public StableConfigMappingException(String message) {
     super(message);
   }
 
-  public static String safeToString(Object value) {
+  static String safeToString(Object value) {
     if (value == null) return "null";
     String str = value.toString();
     if (str.length() > maxLen) {
       return str.substring(0, maxLen) + "...(truncated)";
     }
     return str;
   }
+
+  public static void throwStableConfigMappingException(String message, Object value) {
+    throw new StableConfigMappingException(message + " " + safeToString(value));
+  }
 }