Skip to content

Commit 0d19785

Browse files
committed
move W3CTraceParent utility to core package instead of public API
1 parent 0dc5a8c commit 0d19785

File tree

6 files changed

+11
-8
lines changed

6 files changed

+11
-8
lines changed

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/JDBCDecorator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99

1010
import datadog.trace.api.Config;
1111
import datadog.trace.api.DDTraceId;
12-
import datadog.trace.api.W3CTraceParent;
1312
import datadog.trace.api.naming.SpanNaming;
1413
import datadog.trace.api.telemetry.LogCollector;
1514
import datadog.trace.bootstrap.ContextStore;
@@ -23,6 +22,7 @@
2322
import datadog.trace.bootstrap.instrumentation.jdbc.DBInfo;
2423
import datadog.trace.bootstrap.instrumentation.jdbc.DBQueryInfo;
2524
import datadog.trace.bootstrap.instrumentation.jdbc.JDBCConnectionUrlParser;
25+
import datadog.trace.core.propagation.W3CTraceParent;
2626
import java.nio.ByteBuffer;
2727
import java.nio.ByteOrder;
2828
import java.sql.Connection;

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,13 +17,13 @@
1717
import datadog.appsec.api.blocking.BlockingException;
1818
import datadog.trace.agent.tooling.Instrumenter;
1919
import datadog.trace.agent.tooling.InstrumenterModule;
20-
import datadog.trace.api.W3CTraceParent;
2120
import datadog.trace.bootstrap.CallDepthThreadLocalMap;
2221
import datadog.trace.bootstrap.InstrumentationContext;
2322
import datadog.trace.bootstrap.instrumentation.api.AgentScope;
2423
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
2524
import datadog.trace.bootstrap.instrumentation.api.AgentTracer;
2625
import datadog.trace.bootstrap.instrumentation.jdbc.DBInfo;
26+
import datadog.trace.core.propagation.W3CTraceParent;
2727
import java.sql.Connection;
2828
import java.sql.SQLException;
2929
import java.sql.Statement;

dd-java-agent/instrumentation/mongo/common/src/main/java/datadog/trace/instrumentation/mongo/MongoCommentInjector.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44
import static datadog.trace.bootstrap.instrumentation.api.InstrumentationTags.DBM_TRACE_INJECTED;
55

66
import datadog.trace.api.Config;
7-
import datadog.trace.api.W3CTraceParent;
87
import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
98
import datadog.trace.bootstrap.instrumentation.dbm.SharedDBCommenter;
9+
import datadog.trace.core.propagation.W3CTraceParent;
1010
import org.bson.BsonArray;
1111
import org.bson.BsonDocument;
1212
import org.bson.BsonString;

dd-trace-core/src/main/java/datadog/trace/core/propagation/W3CHttpCodec.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@
1616
import datadog.trace.api.DDTraceId;
1717
import datadog.trace.api.TraceConfig;
1818
import datadog.trace.api.TracePropagationStyle;
19-
import datadog.trace.api.W3CTraceParent;
2019
import datadog.trace.api.internal.util.LongStringUtils;
2120
import datadog.trace.api.sampling.PrioritySampling;
2221
import datadog.trace.api.sampling.SamplingMechanism;

dd-trace-api/src/main/java/datadog/trace/api/W3CTraceParent.java renamed to dd-trace-core/src/main/java/datadog/trace/core/propagation/W3CTraceParent.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
package datadog.trace.api;
1+
package datadog.trace.core.propagation;
2+
3+
import datadog.trace.api.DDSpanId;
4+
import datadog.trace.api.DDTraceId;
25

36
/**
47
* Utility class for building W3C traceparent headers.

dd-trace-api/src/test/groovy/datadog/trace/api/W3CTraceParentTest.groovy renamed to dd-trace-core/src/test/groovy/datadog/trace/core/propagation/W3CTraceParentTest.groovy

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,13 @@
1-
package datadog.trace.api
1+
package datadog.trace.core.propagation
22

3+
import datadog.trace.api.DDTraceId
34
import datadog.trace.test.util.DDSpecification
45

56
class W3CTraceParentTest extends DDSpecification {
67

78
def "build produces correct format with samplingPriority=#samplingPriority"() {
89
when:
9-
def result = W3CTraceParent.build(traceId, spanId, samplingPriority)
10+
def result = W3CTraceParent.from(traceId, spanId, samplingPriority)
1011

1112
then:
1213
result == expected
@@ -23,7 +24,7 @@ class W3CTraceParentTest extends DDSpecification {
2324

2425
def "build matches W3C traceparent format"() {
2526
when:
26-
def result = W3CTraceParent.build(DDTraceId.from(123456789L), 987654321L, 1)
27+
def result = W3CTraceParent.from(DDTraceId.from(123456789L), 987654321L, 1)
2728

2829
then:
2930
// W3C format: version-traceId(32 hex)-spanId(16 hex)-flags(2 hex)

0 commit comments

Comments
 (0)