Skip to content

Commit 0d4dc6f

Browse files
authored
Merge branch 'master' into bdu/fix-jetty-leaking-out-of-testing
2 parents 42ed9b7 + cebe04f commit 0d4dc6f

File tree

5 files changed

+5
-8
lines changed

5 files changed

+5
-8
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -565,7 +565,7 @@ muzzle-dep-report:
565565
export PROFILER_COMMAND="-XX:StartFlightRecording=settings=profile,filename=/tmp/${CI_JOB_NAME_SLUG}.jfr,dumponexit=true";
566566
fi
567567
- *prepare_test_env
568-
- export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp' -Ddatadog.forkedMaxHeapSize=1024M -Ddatadog.forkedMinHeapSize=128M"
568+
- export GRADLE_OPTS="-Dorg.gradle.jvmargs='-Xms$GRADLE_MEM -Xmx$GRADLE_MEM $PROFILER_COMMAND -XX:ErrorFile=/tmp/hs_err_pid%p.log -XX:+HeapDumpOnOutOfMemoryError -XX:HeapDumpPath=/tmp -Djava.util.prefs.userRoot=/tmp/.java/.userPrefs-${CI_JOB_ID}' -Ddatadog.forkedMaxHeapSize=1024M -Ddatadog.forkedMinHeapSize=128M"
569569
- ./gradlew --version
570570
- ./gradlew $GRADLE_TARGET $GRADLE_PARAMS -PtestJvm=$testJvm -Pslot=$CI_NODE_INDEX/$CI_NODE_TOTAL $GRADLE_ARGS --continue || $CONTINUE_ON_FAILURE
571571
after_script:

dd-java-agent/instrumentation/redisson/redisson-3.10.3/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ muzzle {
55
module = "redisson"
66
versions = "[3.10.3,)"
77
skipVersions += "0.9.0"
8-
skipVersions += "4.0.0" // FIXME: Temporary skip `4.0.0` as we need more time to support it.
98
assertInverse = true
109
}
1110
}

dd-java-agent/instrumentation/redisson/redisson-3.10.3/src/main/java/datadog/trace/instrumentation/redisson30/RedissonInstrumentation.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
import java.util.List;
1818
import java.util.concurrent.CompletionStage;
1919
import net.bytebuddy.asm.Advice;
20-
import org.redisson.api.RFuture;
20+
import org.redisson.api.RTransaction;
2121
import org.redisson.client.RedisConnection;
2222
import org.redisson.client.protocol.CommandData;
2323
import org.redisson.client.protocol.CommandsData;
@@ -86,9 +86,9 @@ public static void after(@Advice.Enter final AgentScope scope) {
8686
}
8787
}
8888

89-
public static void muzzleCheck(final RFuture<?> future) {
89+
public static void muzzleCheck(final RTransaction b) {
9090
// added on 3.10.3
91-
future.onComplete(null);
91+
b.getBuckets();
9292
}
9393
}
9494

dd-java-agent/instrumentation/spark/spark_2.13/build.gradle

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ muzzle {
1616
group = "org.apache.spark"
1717
module = "spark-sql_$scalaVersion"
1818
versions = "[4.0.0,)"
19-
skipVersions += "4.1.0" // FIXME: Temporary skip `4.1.0` as we need more time to support it.
2019
javaVersion = 17
2120
}
2221
}

dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractDatadogSparkListener.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@
5858
import org.apache.spark.sql.execution.SQLExecution;
5959
import org.apache.spark.sql.execution.SparkPlanInfo;
6060
import org.apache.spark.sql.execution.metric.SQLMetricInfo;
61-
import org.apache.spark.sql.execution.streaming.StreamExecution;
6261
import org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionEnd;
6362
import org.apache.spark.sql.execution.ui.SparkListenerSQLExecutionStart;
6463
import org.apache.spark.sql.streaming.SourceProgress;
@@ -1264,7 +1263,7 @@ private static String getStreamingBatchKey(Properties properties) {
12641263
return null;
12651264
}
12661265

1267-
Object queryId = properties.get(StreamExecution.QUERY_ID_KEY());
1266+
Object queryId = properties.get("sql.streaming.queryId");
12681267
Object batchId = properties.get("streaming.sql.batchId");
12691268

12701269
if (queryId == null || batchId == null) {

0 commit comments

Comments
 (0)