Skip to content

Commit 0d64192

Browse files
committed
Set resource name and span type correctly.
1 parent ef5481c commit 0d64192

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

dd-java-agent/src/main/java/com/datadoghq/agent/instrumentation/jdbc/PreparedStatementInstrumentation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,12 @@ public static ActiveSpan startSpan(@Advice.This final PreparedStatement statemen
5454
final ActiveSpan span =
5555
GlobalTracer.get().buildSpan(dbInfo.getType() + ".query").startActive();
5656
Tags.DB_TYPE.set(span, dbInfo.getType());
57-
Tags.DB_STATEMENT.set(span, sql);
5857
Tags.SPAN_KIND.set(span, Tags.SPAN_KIND_CLIENT);
5958
Tags.COMPONENT.set(span, "java-jdbc-prepared_statement");
6059

6160
span.setTag(DDTags.SERVICE_NAME, dbInfo.getType());
61+
span.setTag(DDTags.RESOURCE_NAME, sql);
62+
span.setTag(DDTags.SPAN_TYPE, "sql");
6263
span.setTag("span.origin.type", statement.getClass().getName());
6364
span.setTag("db.jdbc.url", dbInfo.getUrl());
6465
try {

dd-java-agent/src/main/java/com/datadoghq/agent/instrumentation/jdbc/StatementInstrumentation.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,11 +54,12 @@ public static ActiveSpan startSpan(
5454
final ActiveSpan span =
5555
GlobalTracer.get().buildSpan(dbInfo.getType() + ".query").startActive();
5656
Tags.DB_TYPE.set(span, dbInfo.getType());
57-
Tags.DB_STATEMENT.set(span, sql);
5857
Tags.SPAN_KIND.set(span, Tags.SPAN_KIND_CLIENT);
5958
Tags.COMPONENT.set(span, "java-jdbc-statement");
6059

6160
span.setTag(DDTags.SERVICE_NAME, dbInfo.getType());
61+
span.setTag(DDTags.RESOURCE_NAME, sql);
62+
span.setTag(DDTags.SPAN_TYPE, "sql");
6263
span.setTag("span.origin.type", statement.getClass().getName());
6364
span.setTag("db.jdbc.url", dbInfo.getUrl());
6465
try {

0 commit comments

Comments
 (0)