Skip to content

Commit 106c1bf

Browse files
committed
feat(testng): Migrate to JSON component
1 parent c918d4d commit 106c1bf

File tree

1 file changed

+7
-12
lines changed
  • dd-java-agent/instrumentation/testng/src/main/java/datadog/trace/instrumentation/testng

1 file changed

+7
-12
lines changed

dd-java-agent/instrumentation/testng/src/main/java/datadog/trace/instrumentation/testng/TestNGUtils.java

Lines changed: 7 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,8 @@
11
package datadog.trace.instrumentation.testng;
22

3+
import datadog.json.JsonWriter;
34
import datadog.trace.api.civisibility.config.TestIdentifier;
45
import datadog.trace.api.civisibility.events.TestSuiteDescriptor;
5-
import datadog.trace.util.Strings;
66
import java.io.InputStream;
77
import java.lang.invoke.MethodHandle;
88
import java.lang.reflect.Method;
@@ -75,19 +75,14 @@ public static String getParameters(Object[] parameters) {
7575

7676
// We build manually the JSON for test.parameters tag.
7777
// Example: {"arguments":{"0":"param1","1":"param2"}}
78-
final StringBuilder sb = new StringBuilder("{\"arguments\":{");
79-
for (int i = 0; i < parameters.length; i++) {
80-
sb.append("\"")
81-
.append(i)
82-
.append("\":\"")
83-
.append(Strings.escapeToJson(String.valueOf(parameters[i])))
84-
.append("\"");
85-
if (i != parameters.length - 1) {
86-
sb.append(",");
78+
try (JsonWriter writer = new JsonWriter()) {
79+
writer.beginObject().name("arguments").beginObject();
80+
for (int i = 0; i < parameters.length; i++) {
81+
writer.name(Integer.toString(i)).value(String.valueOf(parameters[i]));
8782
}
83+
writer.endObject().endObject();
84+
return writer.toString();
8885
}
89-
sb.append("}}");
90-
return sb.toString();
9186
}
9287

9388
public static List<String> getGroups(ITestResult result) {

0 commit comments

Comments
 (0)