Skip to content

Commit 11966a0

Browse files
author
Matt
authored
Merge pull request #7461 from DataDog/mattalp/modify-smap-parse-error-event-types
Improves info around smap parsing success/failure
2 parents 6055e41 + a8196cb commit 11966a0

File tree

1 file changed

+18
-2
lines changed
  • dd-java-agent/agent-profiling/profiling-controller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/events

1 file changed

+18
-2
lines changed

dd-java-agent/agent-profiling/profiling-controller-openjdk/src/main/java/com/datadog/profiling/controller/openjdk/events/SmapEntryFactory.java

Lines changed: 18 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,18 @@
1717
import java.util.regex.Pattern;
1818
import javax.management.MBeanServer;
1919
import javax.management.ObjectName;
20+
import jdk.jfr.Category;
2021
import jdk.jfr.Event;
2122
import jdk.jfr.Label;
23+
import jdk.jfr.Name;
24+
import jdk.jfr.StackTrace;
25+
import org.slf4j.Logger;
26+
import org.slf4j.LoggerFactory;
2227

2328
public class SmapEntryFactory {
2429

30+
private static final Logger log = LoggerFactory.getLogger(SmapEntryFactory.class);
31+
2532
private static final AtomicBoolean REGISTERED = new AtomicBoolean();
2633
private static boolean annotatedMapsAvailable;
2734
private static final Pattern SYSTEM_MAP_ENTRY_PATTERN =
@@ -37,12 +44,16 @@ private enum ErrorReason {
3744
VM_MAP_PARSING_ERROR,
3845
}
3946

47+
@Category("Datadog")
48+
@Name("datadog.SmapParseErrorEvent")
49+
@Label("Smap Parsing Error")
50+
@StackTrace(false)
4051
private static class SmapParseErrorEvent extends Event {
4152
@Label("Reason")
42-
private final ErrorReason reason;
53+
private final String reason;
4354

4455
public SmapParseErrorEvent(ErrorReason reason) {
45-
this.reason = reason;
56+
this.reason = reason.toString();
4657
}
4758
}
4859

@@ -61,6 +72,11 @@ public static void registerEvents() {
6172
annotatedMapsAvailable = false;
6273
}
6374
}
75+
if (annotatedMapsAvailable) {
76+
log.debug("Smap entry events registered successfully");
77+
} else {
78+
log.warn("Smap entry events could not be registered due to missing systemMap operation");
79+
}
6480
}
6581

6682
@SuppressForbidden

0 commit comments

Comments
 (0)