Skip to content

Commit 125744a

Browse files
committed
nits: add configId in ConfigProvider methods where it was missing; fix configId test to accommodate new ConfigCollector data structure
1 parent c62688b commit 125744a

File tree

2 files changed

+3
-1
lines changed

2 files changed

+3
-1
lines changed

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919
import java.util.LinkedHashMap;
2020
import java.util.List;
2121
import java.util.Map;
22+
import java.util.Objects;
2223
import java.util.Properties;
2324
import java.util.Set;
2425
import org.slf4j.Logger;
@@ -79,6 +80,7 @@ public <T extends Enum<T>> T getEnum(String key, Class<T> enumType, T defaultVal
7980
}
8081

8182
public String getString(String key, String defaultValue, String... aliases) {
83+
boolean toLog = (Objects.equals(key, "test.key"));
8284
if (collectConfig) {
8385
ConfigCollector.get().put(key, defaultValue, ConfigOrigin.DEFAULT, DEFAULT_SEQ_ID);
8486
}

internal-api/src/test/groovy/datadog/trace/api/ConfigCollectorTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -321,7 +321,7 @@ class ConfigCollectorTest extends DDSpecification {
321321

322322
then:
323323
// Verify the config was collected but without a config ID
324-
def setting = settings.get(key)
324+
def setting = settings.get(ConfigOrigin.JVM_PROP).get(key)
325325
setting != null
326326
setting.configId == null
327327
setting.value == value

0 commit comments

Comments
 (0)