Remove limits of 100 max probes

to be able to create more with MCP

Author: jpbempel

dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/agent/DebuggerProductChangesListener.java

@@ -29,11 +29,6 @@
 import org.slf4j.LoggerFactory;
 
 public class DebuggerProductChangesListener implements ProductListener {
-  public static final int MAX_ALLOWED_TRIGGER_PROBES = 100;
-  public static final int MAX_ALLOWED_METRIC_PROBES = 100;
-  public static final int MAX_ALLOWED_LOG_PROBES = 100;
-  public static final int MAX_ALLOWED_SPAN_PROBES = 100;
-  public static final int MAX_ALLOWED_SPAN_DECORATION_PROBES = 100;
   public static final String LOG_PROBE_PREFIX = "logProbe_";
   public static final String METRIC_PROBE_PREFIX = "metricProbe_";
   public static final String SPAN_PROBE_PREFIX = "spanProbe_";
@@ -168,46 +163,26 @@ static class DefinitionBuilder {
     private int spanDecorationProbeCount = 0;
 
     void add(MetricProbe probe) {
-      if (metricProbeCount >= MAX_ALLOWED_METRIC_PROBES) {
-        LOGGER.debug("Max allowed metric probes reached, ignoring new probe: {}", probe);
-        return;
-      }
       definitions.add(probe);
       metricProbeCount++;
     }
 
     void add(LogProbe probe) {
-      if (logProbeCount >= MAX_ALLOWED_LOG_PROBES) {
-        LOGGER.debug("Max allowed log probes reached, ignoring new probe: {}", probe);
-        return;
-      }
       definitions.add(probe);
       logProbeCount++;
     }
 
     void add(SpanProbe probe) {
-      if (spanProbeCount >= MAX_ALLOWED_SPAN_PROBES) {
-        LOGGER.debug("Max allowed span probes reached, ignoring new probe: {}", probe);
-        return;
-      }
       definitions.add(probe);
       spanProbeCount++;
     }
 
     void add(TriggerProbe probe) {
-      if (triggerProbeCount >= MAX_ALLOWED_TRIGGER_PROBES) {
-        LOGGER.debug("Max allowed trigger probes reached, ignoring new probe: {}", probe);
-        return;
-      }
       definitions.add(probe);
       triggerProbeCount++;
     }
 
     void add(SpanDecorationProbe probe) {
-      if (spanDecorationProbeCount >= MAX_ALLOWED_SPAN_DECORATION_PROBES) {
-        LOGGER.debug("Max allowed span decoration probes reached, ignoring new probe: {}", probe);
-        return;
-      }
       definitions.add(probe);
       spanDecorationProbeCount++;
     }

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/DebuggerProductChangesListenerTest.java

@@ -1,9 +1,5 @@
 package com.datadog.debugger.agent;
 
-import static com.datadog.debugger.agent.DebuggerProductChangesListener.MAX_ALLOWED_LOG_PROBES;
-import static com.datadog.debugger.agent.DebuggerProductChangesListener.MAX_ALLOWED_METRIC_PROBES;
-import static com.datadog.debugger.agent.DebuggerProductChangesListener.MAX_ALLOWED_SPAN_DECORATION_PROBES;
-import static com.datadog.debugger.agent.DebuggerProductChangesListener.MAX_ALLOWED_SPAN_PROBES;
 import static com.datadog.debugger.util.LogProbeTestHelper.parseTemplate;
 import static datadog.remoteconfig.PollingHinterNoop.NOOP;
 import static org.junit.jupiter.api.Assertions.assertDoesNotThrow;
@@ -197,74 +193,6 @@ public void badConfigIDFailsToAccept() throws IOException {
     assertNull(acceptor.definitions);
   }
 
-  @Test
-  public void maxLogProbes() {
-    SimpleAcceptor acceptor = new SimpleAcceptor();
-    DebuggerProductChangesListener listener =
-        new DebuggerProductChangesListener(tracerConfig, acceptor);
-    for (int i = 0; i < 200; i++) {
-      LogProbe probe =
-          LogProbe.builder()
-              .probeId(String.valueOf(i), 0)
-              .where("java.lang.String", "concat" + i)
-              .build();
-      acceptLogProbe(listener, probe);
-    }
-    listener.commit(NOOP);
-    assertEquals(MAX_ALLOWED_LOG_PROBES, acceptor.getDefinitions().size());
-  }
-
-  @Test
-  public void maxMetricProbes() {
-    SimpleAcceptor acceptor = new SimpleAcceptor();
-    DebuggerProductChangesListener listener =
-        new DebuggerProductChangesListener(tracerConfig, acceptor);
-    for (int i = 0; i < 200; i++) {
-      MetricProbe probe =
-          MetricProbe.builder()
-              .probeId(String.valueOf(i), 0)
-              .where("java.lang.String", "concat" + i)
-              .build();
-      acceptMetricProbe(listener, probe);
-    }
-    listener.commit(NOOP);
-    assertEquals(MAX_ALLOWED_METRIC_PROBES, acceptor.getDefinitions().size());
-  }
-
-  @Test
-  public void maxSpanProbes() {
-    SimpleAcceptor acceptor = new SimpleAcceptor();
-    DebuggerProductChangesListener listener =
-        new DebuggerProductChangesListener(tracerConfig, acceptor);
-    for (int i = 0; i < 200; i++) {
-      SpanProbe probe =
-          SpanProbe.builder()
-              .probeId(String.valueOf(i), 0)
-              .where("java.lang.String", "concat" + i)
-              .build();
-      acceptSpanProbe(listener, probe);
-    }
-    listener.commit(NOOP);
-    assertEquals(MAX_ALLOWED_SPAN_PROBES, acceptor.getDefinitions().size());
-  }
-
-  @Test
-  public void maxSpanDecorationProbes() {
-    SimpleAcceptor acceptor = new SimpleAcceptor();
-    DebuggerProductChangesListener listener =
-        new DebuggerProductChangesListener(tracerConfig, acceptor);
-    for (int i = 0; i < 200; i++) {
-      SpanDecorationProbe probe =
-          SpanDecorationProbe.builder()
-              .probeId(String.valueOf(i), 0)
-              .where("java.lang.String", "concat" + i)
-              .build();
-      acceptSpanDecorationProbe(listener, probe);
-    }
-    listener.commit(NOOP);
-    assertEquals(MAX_ALLOWED_SPAN_DECORATION_PROBES, acceptor.getDefinitions().size());
-  }
-
   @Test
   public void parsingException() throws IOException {
     SimpleAcceptor acceptor = new SimpleAcceptor();