Skip to content

Commit 18258b0

Browse files
committed
One more refactoring
1 parent 1205937 commit 18258b0

File tree

20 files changed

+139
-147
lines changed

20 files changed

+139
-147
lines changed

dd-java-agent/instrumentation/armeria/armeria-grpc-0.84/src/test/groovy/ArmeriaGrpcTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,12 +256,12 @@ abstract class ArmeriaGrpcTest extends VersionedNamingTestBase {
256256
if (isDataStreamsEnabled()) {
257257
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
258258
verifyAll(first) {
259-
tags == DataStreamsTags.fromTags("direction:in", "topic:somequeue", "type:sqs")
259+
tags.hasAllTags("direction:in", "topic:somequeue", "type:grpc")
260260
}
261261

262262
StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }
263263
verifyAll(second) {
264-
tags == DataStreamsTags.fromTags("direction:in", "type:grpc")
264+
tags.hasAllTags("direction:in", "type:grpc")
265265
}
266266
}
267267

dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/dsmTest/groovy/AWS1KinesisClientTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ abstract class AWS1KinesisClientTest extends VersionedNamingTestBase {
116116
pathwayLatencyCount += group.pathwayLatency.count
117117
edgeLatencyCount += group.edgeLatency.count
118118
verifyAll(group) {
119-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:" + streamArn, "type:kinesis")
119+
tags.hasAllTags("direction:" + dsmDirection, "topic:" + streamArn, "type:kinesis")
120120
}
121121
}
122122
verifyAll {

dd-java-agent/instrumentation/aws-java-sdk-1.11.0/src/dsmTest/groovy/AWS1SnsClientTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ abstract class AWS1SnsClientTest extends VersionedNamingTestBase {
9797
pathwayLatencyCount += group.pathwayLatency.count
9898
edgeLatencyCount += group.edgeLatency.count
9999
verifyAll(group) {
100-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:" + topicName, "type:sns")
100+
tags.hasAllTags("direction:" + dsmDirection, "topic:" + topicName, "type:sns")
101101
}
102102
}
103103
verifyAll {

dd-java-agent/instrumentation/aws-java-sdk-2.2/src/dsmTest/groovy/Aws2KinesisDataStreamsTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -157,7 +157,7 @@ abstract class Aws2KinesisDataStreamsTest extends VersionedNamingTestBase {
157157
pathwayLatencyCount += group.pathwayLatency.count
158158
edgeLatencyCount += group.edgeLatency.count
159159
verifyAll(group) {
160-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:arnprefix:stream/somestream", "type:kinesis")
160+
tags.hasAllTags("direction:" + dsmDirection, "topic:arnprefix:stream/somestream", "type:kinesis")
161161
}
162162
}
163163
verifyAll {
@@ -278,7 +278,7 @@ abstract class Aws2KinesisDataStreamsTest extends VersionedNamingTestBase {
278278
pathwayLatencyCount += group.pathwayLatency.count
279279
edgeLatencyCount += group.edgeLatency.count
280280
verifyAll(group) {
281-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:arnprefix:stream/somestream", "type:kinesis")
281+
tags.hasAllTags("direction:" + dsmDirection, "topic:arnprefix:stream/somestream", "type:kinesis")
282282
}
283283
}
284284
verifyAll {

dd-java-agent/instrumentation/aws-java-sdk-2.2/src/dsmTest/groovy/Aws2SnsDataStreamsTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ abstract class Aws2SnsDataStreamsTest extends VersionedNamingTestBase {
145145
pathwayLatencyCount += group.pathwayLatency.count
146146
edgeLatencyCount += group.edgeLatency.count
147147
verifyAll(group) {
148-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:mytopic", "type:sns")
148+
tags.hasAllTags("direction:" + dsmDirection, "topic:mytopic", "type:sns")
149149
}
150150
}
151151
verifyAll {
@@ -243,7 +243,7 @@ abstract class Aws2SnsDataStreamsTest extends VersionedNamingTestBase {
243243
pathwayLatencyCount += group.pathwayLatency.count
244244
edgeLatencyCount += group.edgeLatency.count
245245
verifyAll(group) {
246-
tags == DataStreamsTags.fromTags("direction:" + dsmDirection, "topic:mytopic", "type:sns")
246+
tags.hasAllTags("direction:" + dsmDirection, "topic:mytopic", "type:sns")
247247
}
248248
}
249249
verifyAll {

dd-java-agent/instrumentation/aws-java-sns-1.0/src/test/groovy/SnsClientTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -195,7 +195,7 @@ abstract class SnsClientTest extends VersionedNamingTestBase {
195195
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
196196

197197
verifyAll(first) {
198-
tags == DataStreamsTags.fromTags("direction:out", "topic:testtopic", "type:sns")
198+
tags.hasAllTags("direction:out", "topic:testtopic", "type:sns")
199199
}
200200
}
201201

dd-java-agent/instrumentation/aws-java-sns-2.0/src/test/groovy/SnsClientTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ abstract class SnsClientTest extends VersionedNamingTestBase {
165165
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
166166

167167
verifyAll(first) {
168-
tags == DataStreamsTags.fromTags("direction:out", "topic:testtopic", "type:sns")
168+
tags.hasAllTags("direction:out", "topic:testtopic", "type:sns")
169169
}
170170
}
171171

dd-java-agent/instrumentation/aws-java-sqs-1.0/src/test/groovy/SqsClientTest.groovy

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -173,12 +173,12 @@ abstract class SqsClientTest extends VersionedNamingTestBase {
173173
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
174174

175175
verifyAll(first) {
176-
tags == DataStreamsTags.fromTags("direction:out", "topic:somequeue", "type:sqs")
176+
tags.hasAllTags("direction:out", "topic:somequeue", "type:sqs")
177177
}
178178

179179
StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }
180180
verifyAll(second) {
181-
tags == DataStreamsTags.fromTags("direction:in", "topic:somequeue", "type:sqs")
181+
tags.hasAllTags("direction:in", "topic:somequeue", "type:sqs")
182182
}
183183
}
184184

@@ -628,7 +628,7 @@ class SqsClientV1DataStreamsForkedTest extends SqsClientTest {
628628
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == -2734507826469073289 }
629629

630630
verifyAll(first) {
631-
tags == DataStreamsTags.fromTags("direction:in", "topic:somequeue", "type:sqs")
631+
tags.hasAllTags("direction:in", "topic:somequeue", "type:sqs")
632632
}
633633

634634
cleanup:
@@ -657,7 +657,7 @@ class SqsClientV1DataStreamsForkedTest extends SqsClientTest {
657657
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
658658

659659
verifyAll(first) {
660-
tags == DataStreamsTags.fromTags("direction:in", "topic:somequeue", "type:sqs")
660+
tags.hasAllTags("direction:in", "topic:somequeue", "type:sqs")
661661
}
662662

663663
cleanup:

dd-java-agent/instrumentation/aws-java-sqs-2.0/src/test/groovy/SqsClientTest.groovy

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -174,12 +174,12 @@ abstract class SqsClientTest extends VersionedNamingTestBase {
174174
StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
175175

176176
verifyAll(first) {
177-
tags == DataStreamsTags.fromTags("direction:out", "topic:somequeue", "type:sqs")
177+
tags.hasAllTags("direction:out", "topic:somequeue", "type:sqs")
178178
}
179179

180180
StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }
181181
verifyAll(second) {
182-
tags == DataStreamsTags.fromTags("direction:in", "topic:somequeue", "type:sqs")
182+
tags.hasAllTags("direction:in", "topic:somequeue", "type:sqs")
183183
}
184184
}
185185

dd-java-agent/instrumentation/google-pubsub/src/test/groovy/PubSubTest.groovy

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -40,10 +40,6 @@ import spock.lang.Shared
4040

4141
import java.nio.charset.StandardCharsets
4242
import java.util.concurrent.CountDownLatch
43-
import java.util.function.Function
44-
import java.util.function.ToDoubleFunction
45-
import java.util.function.ToIntFunction
46-
import java.util.function.ToLongFunction
4743

4844
abstract class PubSubTest extends VersionedNamingTestBase {
4945
private static final String PROJECT_ID = "dd-trace-java"
@@ -238,11 +234,11 @@ abstract class PubSubTest extends VersionedNamingTestBase {
238234

239235
StatsGroup sendStat = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0}
240236
verifyAll (sendStat) {
241-
tags == DataStreamsTags.fromTags("direction:out" , "topic:test-topic", "type:google-pubsub")
237+
tags.hasAllTags("direction:out" , "topic:test-topic", "type:google-pubsub")
242238
}
243239
StatsGroup receiveStat = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == sendStat.hash}
244240
verifyAll(receiveStat) {
245-
tags == DataStreamsTags.fromTags("direction:in" , "subscription:my-subscription", "type:google-pubsub")
241+
tags.hasAllTags("direction:in" , "subscription:my-subscription", "type:google-pubsub")
246242
pathwayLatency.count == 1
247243
pathwayLatency.minValue > 0.0
248244
edgeLatency.count == 1

0 commit comments

Comments
 (0)