Skip to content

Commit 1855300

Browse files
committed
rebase cleanups
1 parent 4d57894 commit 1855300

File tree

3 files changed

+11
-26
lines changed

3 files changed

+11
-26
lines changed

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/agent/CapturingTestBase.java

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -343,11 +343,7 @@ public static LogProbe.Builder createProbeBuilder(
343343
}
344344

345345
protected TestSnapshotListener installProbes(Configuration configuration) {
346-
config = Config.get();
347-
setFieldInConfig(config, "debuggerEnabled", true);
348-
setFieldInConfig(config, "debuggerClassFileDumpEnabled", true);
349-
setFieldInConfig(config, "debuggerVerifyByteCode", false);
350-
setFieldInConfig(config, "debuggerCodeOriginMaxUserFrames", 20);
346+
config = getConfig();
351347
instrumentationListener = new MockInstrumentationListener();
352348
probeStatusSink = mock(ProbeStatusSink.class);
353349

@@ -384,15 +380,12 @@ protected TestSnapshotListener installProbes(Configuration configuration) {
384380
return listener;
385381
}
386382

387-
public static Config mockConfig() {
388-
Config config = mock(Config.class);
389-
when(config.isDebuggerEnabled()).thenReturn(true);
390-
when(config.isDebuggerClassFileDumpEnabled()).thenReturn(true);
391-
when(config.isDebuggerVerifyByteCode()).thenReturn(false);
392-
when(config.getFinalDebuggerSnapshotUrl())
393-
.thenReturn("http://localhost:8126/debugger/v1/input");
394-
when(config.getFinalDebuggerSymDBUrl()).thenReturn("http://localhost:8126/symdb/v1/input");
395-
when(config.getDebuggerCodeOriginMaxUserFrames()).thenReturn(20);
383+
public static Config getConfig() {
384+
Config config = Config.get();
385+
setFieldInConfig(config, "debuggerEnabled", true);
386+
setFieldInConfig(config, "debuggerClassFileDumpEnabled", true);
387+
setFieldInConfig(config, "debuggerVerifyByteCode", false);
388+
setFieldInConfig(config, "debuggerCodeOriginMaxUserFrames", 20);
396389

397390
return config;
398391
}

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/probe/LogProbeTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.datadog.debugger.probe;
22

3-
import static com.datadog.debugger.agent.CapturingTestBase.mockConfig;
3+
import static com.datadog.debugger.agent.CapturingTestBase.getConfig;
44
import static com.datadog.debugger.util.LogProbeTestHelper.parseTemplate;
55
import static java.lang.String.format;
66
import static java.lang.Thread.currentThread;
@@ -80,7 +80,7 @@ public void noDebugSession() {
8080
}
8181

8282
private boolean fillSnapshot(DebugSessionStatus status) {
83-
DebuggerAgentHelper.injectSink(new DebuggerSink(mockConfig(), mock(ProbeStatusSink.class)));
83+
DebuggerAgentHelper.injectSink(new DebuggerSink(getConfig(), mock(ProbeStatusSink.class)));
8484
TracerAPI tracer =
8585
CoreTracer.builder().idGenerationStrategy(IdGenerationStrategy.fromName("random")).build();
8686
AgentTracer.registerIfAbsent(tracer);

dd-java-agent/agent-debugger/src/test/java/com/datadog/debugger/trigger/TriggerProbeTest.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -68,11 +68,7 @@ public void cooldown() throws IOException, URISyntaxException {
6868
"()",
6969
null,
7070
new Sampling(10, 10.0));
71-
installProbes(
72-
Configuration.builder()
73-
.setService(SERVICE_NAME)
74-
.add(probe1)
75-
.build());
71+
installProbes(Configuration.builder().setService(SERVICE_NAME).add(probe1).build());
7672
Class<?> testClass = compileAndLoadClass(className);
7773
int runs = 10000;
7874
for (int i = 0; i < runs; i++) {
@@ -124,11 +120,7 @@ public void sampling() throws IOException, URISyntaxException {
124120
"()",
125121
null,
126122
new Sampling(10.0));
127-
Configuration config =
128-
Configuration.builder()
129-
.setService(SERVICE_NAME)
130-
.add(probe1)
131-
.build();
123+
Configuration config = Configuration.builder().setService(SERVICE_NAME).add(probe1).build();
132124
installProbes(config);
133125
Class<?> testClass = compileAndLoadClass(className);
134126
for (int i = 0; i < 100; i++) {

0 commit comments

Comments
 (0)