feat(env): Migrate profiling to environment component

Author: PerfectSlayer

dd-java-agent/agent-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/Arch.java

@@ -1,5 +1,6 @@
 package com.datadog.profiling.ddprof;
 
+import datadog.environment.SystemProperties;
 import java.util.Arrays;
 import java.util.EnumSet;
 import java.util.HashSet;
@@ -29,6 +30,6 @@ public static Arch of(String identifier) {
   }
 
   public static Arch current() {
-    return Arch.of(System.getProperty("os.arch"));
+    return Arch.of(SystemProperties.get("os.arch"));
   }
 }

dd-java-agent/agent-profiling/profiling-ddprof/src/main/java/com/datadog/profiling/ddprof/OperatingSystem.java

@@ -1,5 +1,6 @@
 package com.datadog.profiling.ddprof;
 
+import datadog.environment.SystemProperties;
 import java.util.Arrays;
 import java.util.EnumSet;
 import java.util.HashSet;
@@ -27,6 +28,6 @@ public static OperatingSystem of(String identifier) {
   }
 
   public static OperatingSystem current() {
-    return OperatingSystem.of(System.getProperty("os.name"));
+    return OperatingSystem.of(SystemProperties.get("os.name"));
   }
 }

dd-java-agent/agent-profiling/profiling-uploader/src/main/java/com/datadog/profiling/uploader/util/JfrCliHelper.java

@@ -3,6 +3,7 @@
 import static datadog.trace.util.AgentThreadFactory.AgentThread.PROFILER_HTTP_DISPATCHER;
 
 import datadog.environment.JavaVirtualMachine;
+import datadog.environment.SystemProperties;
 import datadog.trace.api.profiling.RecordingData;
 import datadog.trace.relocate.api.IOLogger;
 import datadog.trace.util.AgentThreadFactory;
@@ -44,7 +45,7 @@ public class JfrCliHelper {
   public static void invokeOn(final RecordingData data, final IOLogger ioLogger) {
     File tmp = null;
     try {
-      Path jfr = Paths.get(System.getProperty("java.home"), "bin", "jfr");
+      Path jfr = Paths.get(SystemProperties.get("java.home"), "bin", "jfr");
       if (JavaVirtualMachine.isJ9() || !Files.exists(jfr)) {
         ioLogger.error("Failed to gather information on recording, can't find `jfr`");
         return;

dd-java-agent/agent-profiling/profiling-uploader/src/test/java/com/datadog/profiling/uploader/util/JfrCliHelperTest.java

@@ -10,6 +10,7 @@
 import static org.mockito.Mockito.withSettings;
 
 import datadog.environment.JavaVirtualMachine;
+import datadog.environment.SystemProperties;
 import datadog.trace.api.profiling.RecordingData;
 import datadog.trace.api.profiling.RecordingInputStream;
 import datadog.trace.relocate.api.IOLogger;
@@ -75,7 +76,7 @@ public void testInvokeOn() throws Exception {
   }
 
   private boolean hasJfr() {
-    return Files.exists(Paths.get(System.getProperty("java.home"), "bin", "jfr"));
+    return Files.exists(Paths.get(SystemProperties.get("java.home"), "bin", "jfr"));
   }
 
   private RecordingData mockRecordingData() throws IOException {

dd-java-agent/agent-profiling/src/main/java/com/datadog/profiling/agent/CompositeController.java

@@ -14,6 +14,7 @@
 import com.datadog.profiling.ddprof.Arch;
 import com.datadog.profiling.ddprof.OperatingSystem;
 import datadog.environment.JavaVirtualMachine;
+import datadog.environment.SystemProperties;
 import datadog.trace.api.Config;
 import datadog.trace.api.Platform;
 import datadog.trace.api.config.ProfilingConfig;
@@ -230,9 +231,9 @@ private static String getFixProposalMessage(boolean datadogProfilerEnabled, bool
     if (!datadogProfilerEnabled && !jfrEnabled) {
       return "Profiling is disabled by configuration. Please, make sure that your configuration is correct.";
     }
-    final String javaVendor = System.getProperty("java.vendor");
-    final String javaVersion = System.getProperty("java.version");
-    final String javaRuntimeName = System.getProperty("java.runtime.name");
+    final String javaVendor = SystemProperties.getOrDefault("java.vendor", "unknown");
+    final String javaVersion = SystemProperties.getOrDefault("java.version", "unknown");
+    final String javaRuntimeName = SystemProperties.getOrDefault("java.runtime.name", "unknown");
     final String message =
         "Not enabling profiling for vendor="
             + javaVendor

dd-java-agent/agent-tooling/src/main/java/datadog/trace/agent/tooling/profiler/EnvironmentChecker.java

@@ -2,6 +2,7 @@
 
 import datadog.environment.JavaVirtualMachine;
 import datadog.environment.OperatingSystem;
+import datadog.environment.SystemProperties;
 import de.thetaphi.forbiddenapis.SuppressForbidden;
 import java.io.File;
 import java.io.IOException;
@@ -28,9 +29,9 @@ public static boolean checkEnvironment(String temp) {
         "Using Java version: "
             + JavaVirtualMachine.getRuntimeVersion()
             + " ("
-            + System.getProperty("java.home")
+            + SystemProperties.getOrDefault("java.home", "unknown")
             + ")");
-    System.out.println("Running as user: " + System.getProperty("user.name"));
+    System.out.println("Running as user: " + SystemProperties.getOrDefault("user.name", "unknown"));
     boolean result = false;
     result |= checkJFR();
     result |= checkDdprof();
@@ -46,7 +47,7 @@ public static boolean checkEnvironment(String temp) {
           "Profiler will not work properly due to issues with temp directory location.");
       return false;
     } else {
-      if (!temp.equals(System.getProperty("java.io.tmpdir"))) {
+      if (!temp.equals(SystemProperties.get("java.io.tmpdir"))) {
         System.out.println(
             "! Make sure to add '-Ddd.profiling.tempdir=" + temp + "' to your JVM command line !");
       }