Skip to content

Commit 22f9192

Browse files
committed
spotless
1 parent 01dccb0 commit 22f9192

File tree

3 files changed

+60
-53
lines changed

3 files changed

+60
-53
lines changed

dd-java-agent/src/main/java/datadog/trace/bootstrap/BootstrapInitializationTelemetry.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -205,10 +205,10 @@ public void send(JsonBuffer buffer) throws IOException {
205205
ProcessBuilder builder = new ProcessBuilder(forwarderPath);
206206

207207
Process process = builder.start();
208-
try ( OutputStream out = process.getOutputStream() ) {
209-
out.write(buffer.toByteArray());
208+
try (OutputStream out = process.getOutputStream()) {
209+
out.write(buffer.toByteArray());
210210
}
211-
211+
212212
try {
213213
process.waitFor(1, TimeUnit.SECONDS);
214214
} catch (InterruptedException e) {

dd-java-agent/src/test/groovy/datadog/trace/agent/InitializationTelemetryTest.groovy

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ class InitializationTelemetryTest extends Specification {
1212
// so the JVM is expected to terminate with an error
1313
when:
1414
def result = InitializationTelemetryCheck.runTestJvm(InitializationTelemetryCheck.BlockAgentLoading)
15-
15+
1616
then:
1717
result.exitCode != 0
1818
// JVM fails before premain, so no telemetry output
@@ -22,7 +22,7 @@ class InitializationTelemetryTest extends Specification {
2222
def "normal start-up"() {
2323
when:
2424
def result = InitializationTelemetryCheck.runTestJvm(null)
25-
25+
2626
then:
2727
result.exitCode == 0
2828
result.telemetryJson.contains('library_entrypoint.complete')
@@ -34,7 +34,7 @@ class InitializationTelemetryTest extends Specification {
3434
// to run normally.
3535
when:
3636
def result = InitializationTelemetryCheck.runTestJvm(InitializationTelemetryCheck.BlockByteBuddy)
37-
37+
3838
then:
3939
result.exitCode == 0
4040
!result.telemetryJson.contains('library_entrypoint.complete')
@@ -46,7 +46,7 @@ class InitializationTelemetryTest extends Specification {
4646
// so the tracer is unable to report initialization telemetry
4747
when:
4848
def result = InitializationTelemetryCheck.runTestJvm(InitializationTelemetryCheck.BlockForwarderEnvVar, true)
49-
49+
5050
then:
5151
result.exitCode == 0
5252
// forwarder env var unreadable, so no telemetry output
@@ -58,7 +58,7 @@ class InitializationTelemetryTest extends Specification {
5858
// unable to invoke the forwarder executable
5959
when:
6060
def result = InitializationTelemetryCheck.runTestJvm(InitializationTelemetryCheck.BlockForwarderExecution, true)
61-
61+
6262
then:
6363
result.exitCode == 0
6464
// forwarder execution is blocked, so no telemetry output

dd-java-agent/src/test/java/jvmbootstraptest/InitializationTelemetryCheck.java

Lines changed: 52 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
package jvmbootstraptest;
22

3+
import datadog.trace.agent.test.IntegrationTestUtils;
34
import java.io.File;
45
import java.io.FilePermission;
56
import java.io.IOException;
@@ -13,8 +14,6 @@
1314
import java.util.Map;
1415
import java.util.Set;
1516

16-
import datadog.trace.agent.test.IntegrationTestUtils;
17-
1817
/**
1918
* Basic sanity check that InitializationTelemetry is functioning
2019
*
@@ -78,64 +77,72 @@ public static final Result runTestJvm(Class<? extends TestSecurityManager> secur
7877
public static final Result runTestJvm(
7978
Class<? extends TestSecurityManager> securityManagerClass, boolean printStreams)
8079
throws Exception {
81-
82-
File jarFile =
80+
81+
File jarFile =
8382
IntegrationTestUtils.createJarFileWithClasses(requiredClasses(securityManagerClass));
84-
85-
File forwarderFile = createTempFile("forwarder", "sh", PosixFilePermissions.fromString("rwxr--r--"));
86-
File outputFile = new File(forwarderFile.getAbsoluteFile() + ".out");
87-
88-
write(forwarderFile,
89-
"#!/usr/bin/env bash\n",
90-
"echo \"$1 $(cat -)\" >> " + outputFile.getAbsolutePath() + "\n");
91-
83+
84+
File forwarderFile =
85+
createTempFile("forwarder", "sh", PosixFilePermissions.fromString("rwxr--r--"));
86+
File outputFile = new File(forwarderFile.getAbsoluteFile() + ".out");
87+
88+
write(
89+
forwarderFile,
90+
"#!/usr/bin/env bash\n",
91+
"echo \"$1 $(cat -)\" >> " + outputFile.getAbsolutePath() + "\n");
92+
9293
try {
93-
int exitCode = IntegrationTestUtils.runOnSeparateJvm(
94-
InitializationTelemetryCheck.class.getName(),
95-
InitializationTelemetryCheck.jvmArgs(securityManagerClass),
96-
InitializationTelemetryCheck.mainArgs(),
97-
InitializationTelemetryCheck.envVars(forwarderFile),
98-
jarFile,
99-
printStreams);
100-
94+
int exitCode =
95+
IntegrationTestUtils.runOnSeparateJvm(
96+
InitializationTelemetryCheck.class.getName(),
97+
InitializationTelemetryCheck.jvmArgs(securityManagerClass),
98+
InitializationTelemetryCheck.mainArgs(),
99+
InitializationTelemetryCheck.envVars(forwarderFile),
100+
jarFile,
101+
printStreams);
102+
101103
return new Result(exitCode, read(outputFile));
102104
} finally {
103105
delete(jarFile, forwarderFile, outputFile);
104106
}
105107
}
106-
107-
static final File createTempFile(String baseName, String extension, Set<PosixFilePermission> perms) throws IOException {
108-
Path path = Files.createTempFile(baseName + "-integration-telemetry-check", "." + extension, PosixFilePermissions.asFileAttribute(perms));
108+
109+
static final File createTempFile(
110+
String baseName, String extension, Set<PosixFilePermission> perms) throws IOException {
111+
Path path =
112+
Files.createTempFile(
113+
baseName + "-integration-telemetry-check",
114+
"." + extension,
115+
PosixFilePermissions.asFileAttribute(perms));
109116
File file = path.toFile();
110117
file.deleteOnExit();
111118
return file;
112119
}
113-
120+
114121
static final void write(File file, String... lines) throws IOException {
115-
Files.write(file.toPath(), Arrays.asList(lines));
122+
Files.write(file.toPath(), Arrays.asList(lines));
116123
}
117-
124+
118125
static final String read(File file) throws IOException {
119-
try {
120-
return new String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8);
121-
} catch ( IOException e ) {
122-
return null;
123-
}
126+
try {
127+
return new String(Files.readAllBytes(file.toPath()), StandardCharsets.UTF_8);
128+
} catch (IOException e) {
129+
return null;
130+
}
124131
}
125-
132+
126133
static final void delete(File... tempFiles) {
127-
for ( File file: tempFiles ) {
128-
file.delete();
129-
}
134+
for (File file : tempFiles) {
135+
file.delete();
136+
}
130137
}
131138

132139
public static final Class<?>[] requiredClasses(
133140
Class<? extends TestSecurityManager> securityManagerClass) {
134141

135142
if (securityManagerClass == null) {
136143
return new Class<?>[] {
137-
InitializationTelemetryCheck.class,
138-
InitializationTelemetryCheck.Result.class};
144+
InitializationTelemetryCheck.class, InitializationTelemetryCheck.Result.class
145+
};
139146
} else {
140147
return new Class<?>[] {
141148
InitializationTelemetryCheck.class,
@@ -164,14 +171,14 @@ public static final Map<String, String> envVars(File forwarderFile) {
164171
envVars.put("DD_TELEMETRY_FORWARDER_PATH", forwarderFile.getAbsolutePath());
165172
return envVars;
166173
}
167-
174+
168175
public static final class Result {
169-
public final int exitCode;
170-
public final String telemetryJson;
171-
172-
public Result(int exitCode, String telemetryJson) {
173-
this.exitCode = exitCode;
174-
this.telemetryJson = telemetryJson;
175-
}
176+
public final int exitCode;
177+
public final String telemetryJson;
178+
179+
public Result(int exitCode, String telemetryJson) {
180+
this.exitCode = exitCode;
181+
this.telemetryJson = telemetryJson;
182+
}
176183
}
177184
}

0 commit comments

Comments
 (0)