fix: ignore framework if name tag is null in span

Author: daniel-mohedano

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/utils/SpanUtils.java

@@ -32,10 +32,10 @@ public static void mergeTestFrameworks(AgentSpan span, Collection<TestFramework>
     setFrameworks(span, merged);
   }
 
-  private static Collection<TestFramework> getFrameworks(AgentSpan span) {
+  static Collection<TestFramework> getFrameworks(AgentSpan span) {
     Object nameTag = span.getTag(Tags.TEST_FRAMEWORK);
     Object versionTag = span.getTag(Tags.TEST_FRAMEWORK_VERSION);
-    if (nameTag == null && versionTag == null) {
+    if (nameTag == null) {
       return Collections.emptyList();
     }
 
@@ -45,9 +45,10 @@ private static Collection<TestFramework> getFrameworks(AgentSpan span) {
 
     } else if (nameTag instanceof Collection) {
       Iterator<String> names = ((Collection<String>) nameTag).iterator();
-      Iterator<String> versions = ((Collection<String>) versionTag).iterator();
+      Iterator<String> versions =
+          versionTag != null ? ((Collection<String>) versionTag).iterator() : null;
       while (names.hasNext()) {
-        frameworks.add(new TestFramework(names.next(), versions.next()));
+        frameworks.add(new TestFramework(names.next(), versions != null ? versions.next() : null));
       }
 
     } else {

dd-java-agent/agent-ci-visibility/src/test/groovy/datadog/trace/civisibility/utils/SpanUtilsTest.groovy

@@ -0,0 +1,33 @@
+package datadog.trace.civisibility.utils
+
+import datadog.trace.bootstrap.instrumentation.api.Tags
+import datadog.trace.civisibility.ipc.TestFramework
+import datadog.trace.core.DDSpan
+import spock.lang.Specification
+
+class SpanUtilsTest extends Specification {
+  def "test getFrameworks"() {
+    when:
+    def span = createSpanWithFrameworks(frameworkTag, frameworkVersionTag)
+    def frameworks = SpanUtils.getFrameworks(span)
+
+    then:
+    frameworks == expected
+
+    where:
+    frameworkTag       | frameworkVersionTag      | expected
+    "name"             | "version"                | [new TestFramework("name", "version")]
+    "name"             | null                     | [new TestFramework("name", null)]
+    null               | "version"                | []
+    ["nameA", "nameB"] | ["versionA", "versionB"] | [new TestFramework("nameA", "versionA"), new TestFramework("nameB", "versionB")]
+    ["nameA", "nameB"] | null                     | [new TestFramework("nameA", null), new TestFramework("nameB", null)]
+    ["nameA", "nameB"] | ["versionA", null]       | [new TestFramework("nameA", "versionA"), new TestFramework("nameB", null)]
+  }
+
+  DDSpan createSpanWithFrameworks(Object frameworkTag, Object frameworkVersionTag) {
+    def span = Stub(DDSpan)
+    span.getTag(Tags.TEST_FRAMEWORK) >> frameworkTag
+    span.getTag(Tags.TEST_FRAMEWORK_VERSION) >> frameworkVersionTag
+    return span
+  }
+}