Skip to content

Commit 24ccbaa

Browse files
Improve system tests execution (#7752)
* fix: Make sure to always upload parametric tests logs and results * fix: Remove system test retries
1 parent 38d8106 commit 24ccbaa

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

.circleci/config.continue.yml.j2

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -971,19 +971,20 @@ jobs:
971971
cd system-tests
972972
set +e
973973
RUN_ATTEMPTS=1
974-
while [ $RUN_ATTEMPTS -le 3 ]; do
974+
MAX_ATTEMPTS=1 # Disable retries as the runner is supposed to be stable. Revert to 3 if needed.
975+
while [ $RUN_ATTEMPTS -le $MAX_ATTEMPTS ]; do
975976
echo "Running parametric test attempt $RUN_ATTEMPTS"
976-
timeout 20m ./run.sh PARAMETRIC -L java --log-cli-level=DEBUG --durations=30 -vv
977+
timeout 20m ./run.sh PARAMETRIC --library java --durations=30 -vv
977978
status=$?
978-
#timneout returns 124 if it times out
979-
#if the return code is not 124, then we exit with the status
979+
# timeout returns 124 if it times out
980+
# if the return code is not 124, then we exit with the status
980981
if [ $status -ne 124 ]; then
981982
exit $status
982983
break
983984
fi
984985
RUN_ATTEMPTS=$((RUN_ATTEMPTS+1))
985-
if [ $RUN_ATTEMPTS -eq 4 ]; then
986-
#Max attempts reached, exit with 124
986+
if [ $RUN_ATTEMPTS -gt $MAX_ATTEMPTS ]; then
987+
# Max attempts reached, exit with 124
987988
exit 124
988989
fi
989990
done
@@ -994,9 +995,11 @@ jobs:
994995
- run:
995996
name: Collect artifacts
996997
command: tar -cvzf logs_java_parametric_dev.tar.gz -C system-tests logs_parametric
998+
when: always
997999
9981000
- store_artifacts:
9991001
path: logs_java_parametric_dev.tar.gz
1002+
when: always
10001003
10011004
10021005
build_test_jobs: &build_test_jobs

0 commit comments

Comments
 (0)