Skip to content

Commit 2533add

Browse files
Yoonena-ji
authored andcommitted
Attempt to fix SQL injection tests
1 parent 7515a3f commit 2533add

File tree

3 files changed

+8
-4
lines changed

3 files changed

+8
-4
lines changed

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/DBMCompatibleConnectionInstrumentation.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ public DBMCompatibleConnectionInstrumentation() {
7878
@Override
7979
public String[] helperClassNames() {
8080
return new String[] {
81-
packageName + ".JDBCDecorator", packageName + ".SQLCommenter",
81+
packageName + ".JDBCDecorator",
82+
packageName + ".SQLCommenter",
83+
"datadog.trace.core.database.SharedDBCommenter",
8284
};
8385
}
8486

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/StatementInstrumentation.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,11 @@ public Map<String, String> contextStore() {
5858

5959
@Override
6060
public String[] helperClassNames() {
61-
return new String[] {packageName + ".JDBCDecorator", packageName + ".SQLCommenter"};
61+
return new String[] {
62+
packageName + ".JDBCDecorator",
63+
packageName + ".SQLCommenter",
64+
"datadog.trace.core.database.SharedDBCommenter",
65+
};
6266
}
6367

6468
@Override

dd-smoke-tests/appsec/src/main/groovy/datadog/smoketest/appsec/AbstractAppSecServerSmokeTest.groovy

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,6 @@ abstract class AbstractAppSecServerSmokeTest extends AbstractServerSmokeTest {
5656
"-Ddd.appsec.trace.rate.limit=-1",
5757
// disable http client sampling
5858
"-Ddd.api-security.downstream.request.analysis.sample_rate=1"
59-
// enable DBM propagation for RASP SQL injection detection
60-
"-Ddd.dbm.propagation.mode=service"
6159
] + (System.getProperty('smoke_test.appsec.enabled') == 'inactive' ?
6260
// enable remote config so that appsec is partially enabled (rc is now enabled by default)
6361
[

0 commit comments

Comments
 (0)