chore: remove unused getAuthor..., getCommitter..., and getFullMessage

Author: daniel-mohedano

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/GitClientGitInfoBuilder.java

@@ -39,20 +39,7 @@ public GitInfo build(@Nullable String repositoryPath) {
       List<String> tags = gitClient.getTags(GitClient.HEAD);
       String tag = !tags.isEmpty() ? tags.iterator().next() : null;
 
-      String currentCommitSha = gitClient.getSha(GitClient.HEAD);
-      String fullMessage = gitClient.getFullMessage(GitClient.HEAD);
-
-      String authorName = gitClient.getAuthorName(GitClient.HEAD);
-      String authorEmail = gitClient.getAuthorEmail(GitClient.HEAD);
-      String authorDate = gitClient.getAuthorDate(GitClient.HEAD);
-      PersonInfo author = new PersonInfo(authorName, authorEmail, authorDate);
-
-      String committerName = gitClient.getCommitterName(GitClient.HEAD);
-      String committerEmail = gitClient.getCommitterEmail(GitClient.HEAD);
-      String committerDate = gitClient.getCommitterDate(GitClient.HEAD);
-      PersonInfo committer = new PersonInfo(committerName, committerEmail, committerDate);
-
-      CommitInfo commitInfo = new CommitInfo(currentCommitSha, author, committer, fullMessage);
+      CommitInfo commitInfo = gitClient.getCommitInfo(GitClient.HEAD);
       return new GitInfo(remoteUrl, branch, tag, commitInfo);
 
     } catch (Exception e) {

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/GitClient.java

@@ -41,28 +41,6 @@ void unshallow(@Nullable String remoteCommitReference, boolean onlyFetchCommit)
   @Nullable
   String getSha(String reference) throws IOException, TimeoutException, InterruptedException;
 
-  @Nullable
-  String getFullMessage(String commit) throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getAuthorName(String commit) throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getAuthorEmail(String commit) throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getAuthorDate(String commit) throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getCommitterName(String commit) throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getCommitterEmail(String commit)
-      throws IOException, TimeoutException, InterruptedException;
-
-  @Nullable
-  String getCommitterDate(String commit) throws IOException, TimeoutException, InterruptedException;
-
   @Nonnull
   CommitInfo getCommitInfo(String commit)
       throws IOException, TimeoutException, InterruptedException;

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/NoOpGitClient.java

@@ -67,48 +67,6 @@ public String getSha(String reference) {
     return null;
   }
 
-  @Nullable
-  @Override
-  public String getFullMessage(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getAuthorName(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getAuthorEmail(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getAuthorDate(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getCommitterName(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getCommitterEmail(String commit) {
-    return null;
-  }
-
-  @Nullable
-  @Override
-  public String getCommitterDate(String commit) {
-    return null;
-  }
-
   @Nonnull
   @Override
   public CommitInfo getCommitInfo(String commit) {

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/git/tree/ShellGitClient.java

@@ -318,181 +318,6 @@ public String getSha(String reference)
                 .trim());
   }
 
-  /**
-   * Returns full message of the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return full message of the provided commit
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getFullMessage(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%B", commit)
-                .trim());
-  }
-
-  /**
-   * Returns author name for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return author name for the provided commit
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getAuthorName(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%an", commit)
-                .trim());
-  }
-
-  /**
-   * Returns author email for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return author email for the provided commit
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getAuthorEmail(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%ae", commit)
-                .trim());
-  }
-
-  /**
-   * Returns author date in strict ISO 8601 format for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return author date in strict ISO 8601 format
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getAuthorDate(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%aI", commit)
-                .trim());
-  }
-
-  /**
-   * Returns committer name for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return committer name for the provided commit
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getCommitterName(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%cn", commit)
-                .trim());
-  }
-
-  /**
-   * Returns committer email for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return committer email for the provided commit
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getCommitterEmail(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%ce", commit)
-                .trim());
-  }
-
-  /**
-   * Returns committer date in strict ISO 8601 format for the provided commit
-   *
-   * @param commit Commit SHA or reference (HEAD, branch name, etc) to check
-   * @return committer date in strict ISO 8601 format
-   * @throws IOException If an error was encountered while writing command input or reading output
-   * @throws TimeoutException If timeout was reached while waiting for Git command to finish
-   * @throws InterruptedException If current thread was interrupted while waiting for Git command to
-   *     finish
-   */
-  @Nullable
-  @Override
-  public String getCommitterDate(String commit)
-      throws IOException, TimeoutException, InterruptedException {
-    if (GitUtils.isNotValidCommit(commit)) {
-      return null;
-    }
-    return executeCommand(
-        Command.OTHER,
-        () ->
-            commandExecutor
-                .executeCommand(IOUtils::readFully, "git", "log", "-n", "1", "--format=%cI", commit)
-                .trim());
-  }
-
   /**
    * Returns commit information for the provided commit
    *

dd-java-agent/agent-ci-visibility/src/test/groovy/datadog/trace/civisibility/CiVisibilityRepoServicesTest.groovy

@@ -59,13 +59,7 @@ class CiVisibilityRepoServicesTest extends Specification {
 
     def gitClient = Stub(GitClient)
     gitClient.getMergeBase("targetSha", "sourceSha") >> expectedInfo.getPullRequestBaseBranchSha()
-    gitClient.getAuthorName("sourceSha") >> expectedInfo.getGitCommitHead().getAuthor().getName()
-    gitClient.getAuthorEmail("sourceSha") >> expectedInfo.getGitCommitHead().getAuthor().getEmail()
-    gitClient.getAuthorDate("sourceSha") >> expectedInfo.getGitCommitHead().getAuthor().getIso8601Date()
-    gitClient.getCommitterName("sourceSha") >> expectedInfo.getGitCommitHead().getCommitter().getName()
-    gitClient.getCommitterEmail("sourceSha") >> expectedInfo.getGitCommitHead().getCommitter().getEmail()
-    gitClient.getCommitterDate("sourceSha") >> expectedInfo.getGitCommitHead().getCommitter().getIso8601Date()
-    gitClient.getFullMessage("sourceSha") >> expectedInfo.getGitCommitHead().getFullMessage()
+    gitClient.getCommitInfo("sourceSha") >> expectedInfo.getGitCommitHead()
 
     expect:
     CiVisibilityRepoServices.buildPullRequestInfo(config, environment, ciProviderInfo, gitClient, repoUnshallow) == expectedInfo