Skip to content

Commit 25f42de

Browse files
committed
fix: Fix local runs, reduce warmup duration
1 parent 037f753 commit 25f42de

File tree

4 files changed

+24
-26
lines changed

4 files changed

+24
-26
lines changed

benchmark/load/insecure-bank/k6.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ export const options = {
99
[`load--insecure-bank--${__ENV.VARIANT}--warmup`]: {
1010
executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors
1111
vus: 5,
12-
duration: '15s',
13-
gracefulStop: '5s',
12+
duration: '10s',
13+
gracefulStop: '2s',
1414
},
1515
[`load--insecure-bank--${__ENV.VARIANT}--high_load`]: {
1616
executor: 'constant-vus',
1717
vus: 5,
18-
startTime: '15s',
18+
startTime: '12s',
1919
duration: '20s',
20-
gracefulStop: '5s',
20+
gracefulStop: '2s',
2121
},
2222
}
2323
};

benchmark/load/petclinic/benchmark.json

Lines changed: 6 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -9,49 +9,37 @@
99
"${NO_AGENT_VARIANT}": {
1010
"env": {
1111
"VARIANT": "${NO_AGENT_VARIANT}",
12-
"JAVA_OPTS": "",
13-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
14-
"CPU_AFFINITY_APP": "taskset -c 31-32 "
12+
"JAVA_OPTS": ""
1513
}
1614
},
1715
"tracing": {
1816
"env": {
1917
"VARIANT": "tracing",
20-
"JAVA_OPTS": "-javaagent:${TRACER}",
21-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
22-
"CPU_AFFINITY_APP": "taskset -c 33-34 "
18+
"JAVA_OPTS": "-javaagent:${TRACER}"
2319
}
2420
},
2521
"profiling": {
2622
"env": {
2723
"VARIANT": "profiling",
28-
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.profiling.enabled=true",
29-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
30-
"CPU_AFFINITY_APP": "taskset -c 35-36 "
24+
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.profiling.enabled=true"
3125
}
3226
},
3327
"appsec": {
3428
"env": {
3529
"VARIANT": "appsec",
36-
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.appsec.enabled=true",
37-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
38-
"CPU_AFFINITY_APP": "taskset -c 37-38 "
30+
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.appsec.enabled=true"
3931
}
4032
},
4133
"iast": {
4234
"env": {
4335
"VARIANT": "iast",
44-
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.iast.enabled=true",
45-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
46-
"CPU_AFFINITY_APP": "taskset -c 39-40 "
36+
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.iast.enabled=true"
4737
}
4838
},
4939
"code_origins": {
5040
"env": {
5141
"VARIANT": "code_origins",
52-
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.code.origin.for.spans.enabled=true",
53-
"CPU_AFFINITY_K6": "taskset -c 24-30 ",
54-
"CPU_AFFINITY_APP": "taskset -c 41-42 "
42+
"JAVA_OPTS": "-javaagent:${TRACER} -Ddd.code.origin.for.spans.enabled=true"
5543
}
5644
}
5745
}

benchmark/load/petclinic/k6.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,15 +9,15 @@ export const options = {
99
[`load--petclinic--${__ENV.VARIANT}--warmup`]: {
1010
executor: 'constant-vus', // https://grafana.com/docs/k6/latest/using-k6/scenarios/executors/#all-executors
1111
vus: 5,
12-
duration: '15s',
13-
gracefulStop: '5s',
12+
duration: '10s',
13+
gracefulStop: '2s',
1414
},
1515
[`load--petclinic--${__ENV.VARIANT}--high_load`]: {
1616
executor: 'constant-vus',
1717
vus: 5,
18-
startTime: '15s',
18+
startTime: '12s',
1919
duration: '20s',
20-
gracefulStop: '5s',
20+
gracefulStop: '2s',
2121
},
2222
}
2323
};

benchmark/load/run.sh

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,15 @@
11
#!/usr/bin/env bash
22
set -eu
33

4+
if [ -n "$CI_JOB_TOKEN" ]; then
5+
# Inside BP, so we can assume 24 CPU cores available and set CPU affinity
6+
export CPU_AFFINITY_K6="taskset -c 24-30 "
7+
export CPU_AFFINITY_APP="taskset -c 31-32 "
8+
else
9+
export CPU_AFFINITY_K6=""
10+
export CPU_AFFINITY_APP=""
11+
fi
12+
13+
414
source "${UTILS_DIR}/update-java-version.sh" 17
515
"${UTILS_DIR}/run-sirun-benchmarks.sh" "$@"

0 commit comments

Comments
 (0)