Skip to content

Commit 27afb3a

Browse files
committed
fix tests, fix NPE in ConfigSetting.equals, include configId in telemetryrequestbody when nonnull
1 parent 53b46a3 commit 27afb3a

File tree

2 files changed

+5
-1
lines changed

2 files changed

+5
-1
lines changed

internal-api/src/main/java/datadog/trace/api/ConfigSetting.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ public final class ConfigSetting {
1111
public final String key;
1212
public final Object value;
1313
public final ConfigOrigin origin;
14+
/** The config ID associated with this setting, or {@code null} if not applicable. */
1415
public final String configId;
1516

1617
private static final Set<String> CONFIG_FILTER_LIST =
@@ -108,7 +109,7 @@ public boolean equals(Object o) {
108109
return key.equals(that.key)
109110
&& Objects.equals(value, that.value)
110111
&& origin == that.origin
111-
&& configId.equals(that.configId);
112+
&& Objects.equals(configId, that.configId);
112113
}
113114

114115
@Override

telemetry/src/main/java/datadog/telemetry/TelemetryRequestBody.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,9 @@ public void writeConfiguration(ConfigSetting configSetting) throws IOException {
230230
bodyWriter.name("value").value(configSetting.stringValue());
231231
bodyWriter.setSerializeNulls(false);
232232
bodyWriter.name("origin").value(configSetting.origin.value);
233+
if (configSetting.configId != null) {
234+
bodyWriter.name("configId").value(configSetting.configId);
235+
}
233236
bodyWriter.endObject();
234237
}
235238

0 commit comments

Comments
 (0)