Skip to content

Commit 297ae9b

Browse files
committed
Pin spock version in lockfile instead
1 parent 75f00b1 commit 297ae9b

File tree

2 files changed

+6
-10
lines changed

2 files changed

+6
-10
lines changed

dd-java-agent/instrumentation/junit/junit-5.3/spock-junit-5/build.gradle

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,9 @@ configurations.matching({ it.name.startsWith('test') }).configureEach({
4040
})
4141

4242
configurations.matching({ it.name.startsWith('latestDepTest') }).configureEach({
43-
// it.resolutionStrategy.componentSelection.all { ComponentSelection selection ->
44-
// if (selection.candidate.group == 'org.spockframework' && selection.candidate.module == 'spock-core' && !selection.candidate.version.endsWith("-groovy-${spockGroovyVersion}")) {
45-
// selection.reject('Spock groovy version mismatch')
46-
// }
47-
// TODO: `org.spockframework.lang.SpecInternals` was moved to `org.spockframework.runtime.SpecInternals` in the latest M7 release: https://github.com/spockframework/spock/pull/2209
48-
// Pinning to 2.4-M6 until we update the instrumentation to use the new class and fall back to the old one.
49-
it.resolutionStrategy {
50-
force "org.spockframework:spock-core:2.4-M6-groovy-${spockGroovyVersion}"
43+
it.resolutionStrategy.componentSelection.all { ComponentSelection selection ->
44+
if (selection.candidate.group == 'org.spockframework' && selection.candidate.module == 'spock-core' && !selection.candidate.version.endsWith("-groovy-${spockGroovyVersion}")) {
45+
selection.reject('Spock groovy version mismatch')
46+
}
5147
}
5248
})

dd-java-agent/instrumentation/junit/junit-5.3/spock-junit-5/gradle.lockfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -187,10 +187,10 @@ org.slf4j:slf4j-api:1.7.36=latestDepTestRuntimeClasspath,testRuntimeClasspath
187187
org.slf4j:slf4j-api:2.0.17=spotbugs,spotbugsSlf4j
188188
org.slf4j:slf4j-simple:2.0.17=spotbugsSlf4j
189189
org.snakeyaml:snakeyaml-engine:2.9=instrumentPluginClasspath,latestDepTestRuntimeClasspath,muzzleTooling,runtimeClasspath,testRuntimeClasspath
190-
org.spockframework:spock-bom:2.4-M7-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath
190+
org.spockframework:spock-bom:2.4-M6-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath
191191
org.spockframework:spock-core:2.0-groovy-3.0=compileClasspath
192192
org.spockframework:spock-core:2.2-groovy-3.0=testCompileClasspath,testRuntimeClasspath
193-
org.spockframework:spock-core:2.4-M7-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath
193+
org.spockframework:spock-core:2.4-M6-groovy-3.0=latestDepTestCompileClasspath,latestDepTestRuntimeClasspath
194194
org.testng:testng:7.5.1=latestDepTestRuntimeClasspath,testRuntimeClasspath
195195
org.webjars:jquery:3.5.1=latestDepTestRuntimeClasspath,testRuntimeClasspath
196196
org.xmlresolver:xmlresolver:5.3.3=spotbugs

0 commit comments

Comments
 (0)