Skip to content

Commit 2b04db3

Browse files
Tweaking Groovy setup.
1 parent ba98146 commit 2b04db3

File tree

6 files changed

+35
-8
lines changed

6 files changed

+35
-8
lines changed

dd-java-agent/agent-ci-visibility/civisibility-test-fixtures/build.gradle

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,5 +11,7 @@ dependencies {
1111
api libs.jackson.databind
1212
api group: 'org.msgpack', name: 'jackson-dataformat-msgpack', version: '0.9.6'
1313
api group: 'org.xmlunit', name: 'xmlunit-core', version: '2.10.3'
14+
15+
compileOnly libs.bundles.spock
1416
}
1517

dd-java-agent/testing/build.gradle

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,6 @@ dependencies {
3535
api libs.bytebuddy
3636
api libs.bytebuddyagent
3737
api libs.slf4j
38-
api libs.bundles.spock
3938
api libs.bundles.test.logging
4039
api libs.guava
4140

@@ -50,6 +49,8 @@ dependencies {
5049

5150
api libs.groovy
5251

52+
compileOnly libs.bundles.spock
53+
5354
implementation "org.junit.platform:junit-platform-runner:${libs.versions.junit.platform.get()}"
5455
implementation project(':dd-java-agent:appsec')
5556
}

dd-smoke-tests/gradle/build.gradle

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,28 @@ apply from: "$rootDir/gradle/java.gradle"
66
description = 'Gradle Daemon Instrumentation Smoke Tests.'
77

88
dependencies {
9+
testImplementation 'org.codehaus.groovy:groovy-all:3.0.24'
10+
testImplementation 'org.spockframework:spock-core:2.4-M6-groovy-3.0'
11+
testImplementation 'org.objenesis:objenesis:3.3'
12+
913
testImplementation gradleTestKit()
1014
testImplementation project(':dd-smoke-tests:backend-mock')
1115
testImplementation project(':internal-api')
12-
testImplementation project(':dd-java-agent:agent-ci-visibility:civisibility-test-fixtures')
16+
testImplementation(project(':dd-java-agent:agent-ci-visibility:civisibility-test-fixtures')) {
17+
exclude group: "org.spockframework", module: "spock-core"
18+
}
19+
}
20+
21+
configurations {
22+
testImplementation {
23+
exclude group: 'org.apache.groovy'
24+
}
25+
}
26+
27+
configurations.named('testImplementation') {
28+
resolutionStrategy {
29+
force 'org.spockframework:spock-core:2.4-M6-groovy-3.0'
30+
}
1331
}
1432

1533
tasks.named("test", Test) {

gradle/java_deps.gradle

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,8 +1,15 @@
11
apply plugin: 'groovy'
22

33
dependencies {
4-
testImplementation libs.bundles.spock
5-
testImplementation libs.groovy
4+
if ((project.name == "gradle" && project.parent.name == "dd-smoke-tests") ||
5+
(project.name == "spock-junit-5")
6+
) {
7+
logger.info("Skip Groovy 4 setup for module: `:${project.parent.name}:${project.name}`")
8+
} else {
9+
testImplementation libs.bundles.spock
10+
testImplementation libs.groovy
11+
}
12+
613
testImplementation libs.bundles.test.logging
714

815
// JUnit and Mockito compatible with Spock 2.4.0

settings.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -167,7 +167,7 @@ include(
167167
":dd-smoke-tests:custom-systemloader",
168168
":dd-smoke-tests:dynamic-config",
169169
":dd-smoke-tests:field-injection",
170-
// ":dd-smoke-tests:gradle", TODO fix incompatibility with Groovy 4.x: gradle uses Groovy 3.
170+
":dd-smoke-tests:gradle",
171171
":dd-smoke-tests:grpc-1.5",
172172
":dd-smoke-tests:java9-modules",
173173
":dd-smoke-tests:jersey-2",

utils/test-utils/build.gradle.kts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,14 @@ plugins {
55
apply(from = "$rootDir/gradle/java.gradle")
66

77
dependencies {
8-
api(libs.groovy)
9-
api(libs.bundles.spock)
10-
118
api(libs.bytebuddy)
129
api(libs.bytebuddyagent)
1310

1411
api(project(":components:environment"))
1512
api(group = "commons-fileupload", name = "commons-fileupload", version = "1.5")
1613

14+
compileOnly(libs.groovy)
15+
compileOnly(libs.bundles.spock)
1716
compileOnly(libs.logback.core)
1817
compileOnly(libs.logback.classic)
1918
}

0 commit comments

Comments
 (0)