Skip to content

Commit 3882881

Browse files
author
Cecile Terpin
committed
Adapt JSON keys to DD LOG UI
1 parent 4ff3266 commit 3882881

File tree

2 files changed

+21
-7
lines changed
  • dd-java-agent

2 files changed

+21
-7
lines changed

dd-java-agent/agent-bootstrap/src/main/java/datadog/trace/bootstrap/Agent.java

Lines changed: 17 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,8 @@ public class Agent {
7171
"datadog.slf4j.simpleLogger.showDateTime";
7272
private static final String SIMPLE_LOGGER_JSON_ENABLED_PROPERTY =
7373
"datadog.slf4j.simpleLogger.json.enabled";
74+
private static final String SIMPLE_LOGGER_DATE_TIME_FORMAT_JSON_DEFAULT =
75+
"yyyy-MM-dd'T'HH:mm:ss.SSSZ";
7476
private static final String SIMPLE_LOGGER_DATE_TIME_FORMAT_PROPERTY =
7577
"datadog.slf4j.simpleLogger.dateTimeFormat";
7678
private static final String SIMPLE_LOGGER_DATE_TIME_FORMAT_DEFAULT =
@@ -1104,9 +1106,21 @@ private static synchronized void startDebuggerAgent(
11041106

11051107
private static void configureLogger() {
11061108
setSystemPropertyDefault(SIMPLE_LOGGER_SHOW_DATE_TIME_PROPERTY, "true");
1107-
setSystemPropertyDefault(
1108-
SIMPLE_LOGGER_DATE_TIME_FORMAT_PROPERTY, SIMPLE_LOGGER_DATE_TIME_FORMAT_DEFAULT);
1109-
setSystemPropertyDefault(SIMPLE_LOGGER_JSON_ENABLED_PROPERTY, "false");
1109+
1110+
String simpleLoggerJsonInSystemPropertySetByUser =
1111+
System.getProperty(SIMPLE_LOGGER_JSON_ENABLED_PROPERTY);
1112+
String simpleLoggerJsonInEnvVarSetByUser = ddGetEnv(SIMPLE_LOGGER_JSON_ENABLED_PROPERTY);
1113+
if ((simpleLoggerJsonInSystemPropertySetByUser != null
1114+
&& simpleLoggerJsonInSystemPropertySetByUser.equalsIgnoreCase("true"))
1115+
|| (simpleLoggerJsonInEnvVarSetByUser != null
1116+
&& simpleLoggerJsonInEnvVarSetByUser.equalsIgnoreCase("true"))) {
1117+
setSystemPropertyDefault(
1118+
SIMPLE_LOGGER_DATE_TIME_FORMAT_PROPERTY, SIMPLE_LOGGER_DATE_TIME_FORMAT_JSON_DEFAULT);
1119+
} else {
1120+
setSystemPropertyDefault(
1121+
SIMPLE_LOGGER_DATE_TIME_FORMAT_PROPERTY, SIMPLE_LOGGER_DATE_TIME_FORMAT_DEFAULT);
1122+
setSystemPropertyDefault(SIMPLE_LOGGER_JSON_ENABLED_PROPERTY, "false");
1123+
}
11101124

11111125
String logLevel;
11121126
if (isDebugMode()) {

dd-java-agent/agent-logging/src/main/java/datadog/trace/logging/simplelogger/SLCompatHelper.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,6 @@ public void log(LogLevel level, Marker marker, String message, Throwable t) {
3636
if (settings.showDateTime) {
3737
timeMillis = System.currentTimeMillis();
3838
}
39-
System.out.println("CTE settings.jsonEnabled: " + settings.jsonEnabled);
4039
if (settings.jsonEnabled) {
4140
logJson(level, marker, SLCompatFactory.START_TIME, timeMillis, message, t);
4241
} else {
@@ -147,15 +146,16 @@ void logJson(
147146
StringBuilder buf = new StringBuilder(32);
148147

149148
buf.append("{");
149+
embedJson(buf, "origin", "dd.trace", true);
150150

151151
if (timeMillis >= 0 && settings.showDateTime) {
152-
embedJsonKey(buf, "time");
152+
embedJsonKey(buf, "date");
153153
settings.dateTimeFormatter.appendFormattedDate(buf, timeMillis, startTimeMillis);
154154
buf.append("\",");
155155
}
156156

157157
if (settings.showThreadName && threadName != null) {
158-
embedJson(buf, "threadName", threadName, true);
158+
embedJson(buf, "logger.thread_name", threadName, true);
159159
}
160160

161161
embedJsonKey(buf, "level");
@@ -169,7 +169,7 @@ void logJson(
169169
}
170170

171171
if (!logName.isEmpty()) {
172-
embedJson(buf, "loggerName", logName, true);
172+
embedJson(buf, "logger.name", logName, true);
173173
}
174174
embedJson(buf, "message", message, false);
175175

0 commit comments

Comments
 (0)