verify extracted SpanID is valid before creating span link

mhlidd · mhlidd · commit 38c4abd0e09c · 2024-11-22T12:13:14.000-08:00
diff --git a/dd-trace-core/src/main/java/datadog/trace/core/propagation/HttpCodec.java b/dd-trace-core/src/main/java/datadog/trace/core/propagation/HttpCodec.java
@@ -239,7 +239,7 @@ public <C> TagContext extract(
               if (comingFromTraceContext) {
                 applyTraceContextToFirstContext(context, extractedContext, extractionCache);
               }
-            } else {
+            } else if (extractedContext.getSpanId() != 0) { // Check that SpanID of secondary extracted context is valid
               // Terminate extracted context and add it as span link
               context.addTerminatedContextLink(
                   DDSpanLink.from(

Original file line number	Diff line number	Diff line change
`@@ -239,7 +239,7 @@ public <C> TagContext extract(`
`239`	`239`	`if (comingFromTraceContext) {`
`240`	`240`	`applyTraceContextToFirstContext(context, extractedContext, extractionCache);`
`241`	`241`	`}`
`242`		`- } else {`
	`242`	`+ } else if (extractedContext.getSpanId() != 0) { // Check that SpanID of secondary extracted context is valid`
`243`	`243`	`// Terminate extracted context and add it as span link`
`244`	`244`	`context.addTerminatedContextLink(`
`245`	`245`	`DDSpanLink.from(`