relaxing restraint on rereportToCollector

Author: mhlidd

internal-api/src/main/java/datadog/trace/bootstrap/config/provider/ConfigProvider.java

@@ -653,7 +653,8 @@ static <T> ConfigValueResolver<T> of(T value, ConfigOrigin origin, int seqId, St
 
     /** Re-reports this resolved value to ConfigCollector with the specified seqId */
     void reReportToCollector(String key, int finalSeqId) {
-      if (value != null && origin != null) {
+      // Source and value should never be null if there is an initialized ConfigValueResolver
+      if (origin != null) {
         ConfigCollector.get().put(key, value, origin, finalSeqId, configId);
       }
     }

internal-api/src/test/groovy/datadog/trace/bootstrap/config/provider/ConfigProviderTest.groovy

@@ -139,40 +139,6 @@ class ConfigProviderTest extends DDSpecification {
     "getDouble"  | "test.double" | "DD_TEST_DOUBLE"| "42.75"    | "notADouble" | 2.71         | 42.75          | { configProvider, key, defVal -> configProvider.getDouble(key, defVal) }
   }
 
-  def "ConfigProvider does not report final result when conditions are not met"() {
-    setup:
-    ConfigCollector.get().collect() // clear previous state
-
-    // Set up different combinations that should NOT trigger re-reporting
-    if (injectEnv) {
-      injectEnvConfig("DD_TEST_MAP", envValue)
-    }
-    if (injectJvm) {
-      injectSysConfig("test.map", jvmValue)
-    }
-
-    def provider = ConfigProvider.createDefault()
-
-    when:
-    def result = provider.getMergedMap("test.map")
-    def collected = ConfigCollector.get().collect()
-
-    then:
-    // Should NOT have a CALCULATED entry because conditions to re-report have not been met:
-    def calculatedSettings = collected.get(ConfigOrigin.CALCULATED)
-    calculatedSettings == null || !calculatedSettings.containsKey("test.map")
-
-    // Verify the result matches expectations
-    result == [:]
-
-    where:
-    injectEnv | injectJvm | envValue | jvmValue
-    false     | false     | null     | null
-    true      | false     | ""       | null
-    false     | true      | null     | "   "
-    true      | true      | ""       | ""
-  }
-
   def "ConfigProvider transforms invalid values for getBoolean to false with CALCULATED origin"() {
     // Booleans are a special case; we currently treat all invalid boolean configurations as false rather than falling back to a lower precedence setting.
     setup: