Move NonBlockingSemaphore to internal-api

Author: smola

dd-java-agent/agent-iast/src/main/java/com/datadog/iast/overhead/OverheadContext.java

@@ -2,7 +2,7 @@
 
 import static datadog.trace.api.iast.IastDetectionMode.UNLIMITED;
 
-import com.datadog.iast.util.NonBlockingSemaphore;
+import datadog.trace.util.NonBlockingSemaphore;
 
 public class OverheadContext {
 

dd-java-agent/agent-iast/src/main/java/com/datadog/iast/overhead/OverheadController.java

@@ -4,7 +4,7 @@
 
 import com.datadog.iast.IastRequestContext;
 import com.datadog.iast.IastSystem;
-import com.datadog.iast.util.NonBlockingSemaphore;
+import datadog.trace.util.NonBlockingSemaphore;
 import datadog.trace.api.Config;
 import datadog.trace.api.gateway.RequestContext;
 import datadog.trace.api.gateway.RequestContextSlot;

…adog/iast/util/NonBlockingSemaphore.java …dog/trace/util/NonBlockingSemaphore.javadd-java-agent/agent-iast/src/main/java/com/datadog/iast/util/NonBlockingSemaphore.java renamed to internal-api/src/main/java/datadog/trace/util/NonBlockingSemaphore.java dd-java-agent/agent-iast/src/main/java/com/datadog/iast/util/NonBlockingSemaphore.java renamed to internal-api/src/main/java/datadog/trace/util/NonBlockingSemaphore.java

@@ -1,4 +1,4 @@
-package com.datadog.iast.util;
+package datadog.trace.util;
 
 import java.util.concurrent.atomic.AtomicBoolean;
 import java.util.concurrent.atomic.AtomicInteger;

…ast/util/NonBlockingSemaphoreTest.groovy …ace/util/NonBlockingSemaphoreTest.groovydd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/util/NonBlockingSemaphoreTest.groovy renamed to internal-api/src/test/groovy/datadog/trace/util/NonBlockingSemaphoreTest.groovy dd-java-agent/agent-iast/src/test/groovy/com/datadog/iast/util/NonBlockingSemaphoreTest.groovy renamed to internal-api/src/test/groovy/datadog/trace/util/NonBlockingSemaphoreTest.groovy

@@ -1,4 +1,4 @@
-package com.datadog.iast.util
+package datadog.trace.util
 
 import datadog.trace.test.util.DDSpecification
 import groovy.transform.CompileDynamic
@@ -97,24 +97,16 @@ class NonBlockingSemaphoreTest extends DDSpecification {
     given:
     final int threads = 100
     final semaphore = NonBlockingSemaphore.unlimited()
-    final latch = new CountDownLatch(threads)
-    final executors = Executors.newFixedThreadPool(threads)
 
     when:
     final acquired = (1..threads).collect {
-      executors.submit({
-        latch.countDown()
-        if (semaphore.acquire()) {
-          TimeUnit.MILLISECONDS.sleep(100)
-          semaphore.release()
-          return 1
-        }
-        return 0
-      } as Callable<Integer>)
-    }.collect { it.get() }.sum()
+      semaphore.acquire()? 1 : 0
+    }.collect { it }.sum()
 
     then:
     acquired == threads
     semaphore.available() == Integer.MAX_VALUE
+
+
   }
 }