Log a warning when profiling enablement is misconfigured. (#7511)

Author: jbachorik

dd-java-agent/instrumentation/graal/native-image/src/main/java/datadog/trace/instrumentation/graal/nativeimage/NativeImageGeneratorRunnerInstrumentation.java

@@ -81,6 +81,7 @@ public static void onEnter(@Advice.Argument(value = 0, readOnly = false) String[
               + "datadog.trace.api.MethodFilterConfigParser:build_time,"
               + "datadog.trace.api.WithGlobalTracer:build_time,"
               + "datadog.trace.api.PropagationStyle:build_time,"
+              + "datadog.trace.api.profiling.ProfilingEnablement:build_time,"
               + "datadog.trace.bootstrap.config.provider.ConfigConverter:build_time,"
               + "datadog.trace.bootstrap.config.provider.ConfigProvider:build_time,"
               + "datadog.trace.bootstrap.config.provider.ConfigProvider$Singleton:build_time,"

internal-api/src/main/java/datadog/trace/api/Config.java

@@ -1522,11 +1522,14 @@ private Config(final ConfigProvider configProvider, final InstrumenterConfig ins
     // the profiler was enabled at build time or not.
     // Otherwise just do the standard config lookup by key.
     // An extra step is needed to properly handle the 'auto' value for profiling enablement via SSI.
-    profilingEnabled =
-        ProfilingEnablement.of(
-            configProvider.getString(
-                ProfilingConfig.PROFILING_ENABLED,
-                String.valueOf(instrumenterConfig.isProfilingEnabled())));
+    String value =
+        configProvider.getString(
+            ProfilingConfig.PROFILING_ENABLED,
+            String.valueOf(instrumenterConfig.isProfilingEnabled()));
+    // Run a validator that will emit a warning if the value is not a valid ProfilingEnablement
+    // We don't want it to run in each call to ProfilingEnablement.of(value) not to flood the logs
+    ProfilingEnablement.validate(value);
+    profilingEnabled = ProfilingEnablement.of(value);
     profilingAgentless =
         configProvider.getBoolean(PROFILING_AGENTLESS, PROFILING_AGENTLESS_DEFAULT);
     isDatadogProfilerEnabled =

internal-api/src/main/java/datadog/trace/api/profiling/ProfilingEnablement.java

@@ -1,10 +1,15 @@
 package datadog.trace.api.profiling;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 public enum ProfilingEnablement {
   ENABLED(true),
   DISABLED(false),
   AUTO(true);
 
+  private static final Logger logger = LoggerFactory.getLogger(Profiling.class);
+
   private final boolean active;
 
   ProfilingEnablement(boolean active) {
@@ -29,4 +34,24 @@ public static ProfilingEnablement of(String value) {
         return DISABLED;
     }
   }
+
+  public static void validate(String value) {
+    if (value == null) {
+      return;
+    }
+    switch (value.toLowerCase()) {
+      case "false":
+      case "true":
+      case "auto":
+        return;
+        // values 1 and 0 are accepted for backwards compatibility
+      case "1":
+      case "0":
+        return;
+      default:
+        logger.warn(
+            "Invalid value for 'dd.profiling.enabled' (DD_PROFILING_ENABLED) detected: {}. Valid values are 'true', 'false' and 'auto'.",
+            value);
+    }
+  }
 }