Address jacoco coverage and injectingpipeoutstream interface updates

Author: sarahchen6

dd-java-agent/agent-bootstrap/src/jmh/java/datadog/trace/bootstrap/instrumentation/buffer/InjectingPipeOutputStreamBenchmark.java

@@ -51,7 +51,8 @@ public class InjectingPipeOutputStreamBenchmark {
   public void withPipe() throws Exception {
     try (final PrintWriter out =
         new PrintWriter(
-            new InjectingPipeOutputStream(new ByteArrayOutputStream(), marker, content, null))) {
+            new InjectingPipeOutputStream(
+                new ByteArrayOutputStream(), marker, content, null, null))) {
       htmlContent.forEach(out::println);
     }
   }

internal-api/build.gradle.kts

@@ -250,6 +250,8 @@ val excludedClassesBranchCoverage by extra(
     "datadog.trace.api.env.CapturedEnvironment.ProcessInfo",
     "datadog.trace.util.TempLocationManager",
     "datadog.trace.util.TempLocationManager.*",
+    // Branches depend on RUM injector state that cannot be reliably controlled in unit tests
+    "datadog.trace.api.rum.RumInjectorMetrics",
   )
 )
 

internal-api/src/main/java/datadog/trace/api/rum/RumTelemetryCollector.java

@@ -36,22 +36,58 @@ public String summary() {
         }
       };
 
+  /**
+   * Reports successful RUM injection.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   */
   void onInjectionSucceed(String integrationVersion);
 
+  /**
+   * Reports failed RUM injection.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   * @param contentEncoding The content encoding of the response that was injected.
+   */
   void onInjectionFailed(String integrationVersion, String contentEncoding);
 
+  /**
+   * Reports skipped RUM injection.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   */
   void onInjectionSkipped(String integrationVersion);
 
+  /** Reports successful RUM injector initialization. */
   void onInitializationSucceed();
 
+  /**
+   * Reports content security policy detected in the response header to be injected.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   */
   void onContentSecurityPolicyDetected(String integrationVersion);
 
+  /**
+   * Reports the size of the response before injection.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   * @param bytes The size of the response before injection.
+   */
   void onInjectionResponseSize(String integrationVersion, long bytes);
 
+  /**
+   * Reports the time taken to inject the RUM SDK.
+   *
+   * @param integrationVersion The version of the integration that was injected.
+   * @param milliseconds The time taken to inject the RUM SDK.
+   */
   void onInjectionTime(String integrationVersion, long milliseconds);
 
+  /** Closes the telemetry collector. */
   default void close() {}
 
+  /** Returns a human-readable summary of the telemetry collected. */
   default String summary() {
     return "";
   }

internal-api/src/test/groovy/datadog/trace/api/rum/RumTelemetryCollectorTest.groovy

@@ -0,0 +1,106 @@
+package datadog.trace.api.rum
+
+import spock.lang.Specification
+
+class RumTelemetryCollectorTest extends Specification {
+
+  def "test default NO_OP does not throw exception"() {
+    when:
+    RumTelemetryCollector.NO_OP.onInjectionSucceed("3")
+    RumTelemetryCollector.NO_OP.onInjectionSucceed("5")
+    RumTelemetryCollector.NO_OP.onInjectionFailed("3", "gzip")
+    RumTelemetryCollector.NO_OP.onInjectionFailed("5", "none")
+    RumTelemetryCollector.NO_OP.onInjectionSkipped("3")
+    RumTelemetryCollector.NO_OP.onInjectionSkipped("5")
+    RumTelemetryCollector.NO_OP.onInitializationSucceed()
+    RumTelemetryCollector.NO_OP.onContentSecurityPolicyDetected("3")
+    RumTelemetryCollector.NO_OP.onContentSecurityPolicyDetected("5")
+    RumTelemetryCollector.NO_OP.onInjectionResponseSize("3", 256L)
+    RumTelemetryCollector.NO_OP.onInjectionResponseSize("5", 512L)
+    RumTelemetryCollector.NO_OP.onInjectionTime("3", 10L)
+    RumTelemetryCollector.NO_OP.onInjectionTime("5", 20L)
+    RumTelemetryCollector.NO_OP.close()
+
+    then:
+    noExceptionThrown()
+  }
+
+  def "test default NO_OP summary returns an empty string"() {
+    when:
+    def summary = RumTelemetryCollector.NO_OP.summary()
+
+    then:
+    summary == ""
+  }
+
+  def "test default NO_OP close method does not throw exception"() {
+    when:
+    RumTelemetryCollector.NO_OP.close()
+
+    then:
+    noExceptionThrown()
+  }
+
+  def "test defining a custom implementation does not throw exception"() {
+    setup:
+    def customCollector = new RumTelemetryCollector() {
+        @Override
+        void onInjectionSucceed(String integrationVersion) {
+        }
+
+        @Override
+        void onInjectionFailed(String integrationVersion, String contentEncoding) {
+        }
+
+        @Override
+        void onInjectionSkipped(String integrationVersion) {
+        }
+
+        @Override
+        void onInitializationSucceed() {
+        }
+
+        @Override
+        void onContentSecurityPolicyDetected(String integrationVersion) {
+        }
+
+        @Override
+        void onInjectionResponseSize(String integrationVersion, long bytes) {
+        }
+
+        @Override
+        void onInjectionTime(String integrationVersion, long milliseconds) {
+        }
+      }
+
+    when:
+    customCollector.close()
+    def summary = customCollector.summary()
+
+    then:
+    noExceptionThrown()
+    summary == ""
+  }
+
+  def "test multiple close calls do not throw exception"() {
+    when:
+    RumTelemetryCollector.NO_OP.close()
+    RumTelemetryCollector.NO_OP.close()
+    RumTelemetryCollector.NO_OP.close()
+
+    then:
+    noExceptionThrown()
+  }
+
+  def "test multiple summary calls return the same empty string"() {
+    when:
+    def summary1 = RumTelemetryCollector.NO_OP.summary()
+    def summary2 = RumTelemetryCollector.NO_OP.summary()
+    def summary3 = RumTelemetryCollector.NO_OP.summary()
+
+    then:
+    summary1 == ""
+    summary1 == summary2
+    summary2 == summary3
+  }
+}