Remove duplicate test: we already test unloading of an injected class-loader in this class

Author: mcculls

dd-java-agent/agent-tooling/src/test/groovy/datadog/trace/agent/test/HelperInjectionTest.groovy

@@ -3,9 +3,6 @@ package datadog.trace.agent.test
 import datadog.trace.agent.tooling.HelperInjector
 import datadog.trace.agent.tooling.Utils
 import datadog.trace.test.util.DDSpecification
-import net.bytebuddy.description.type.TypeDescription
-import net.bytebuddy.dynamic.ClassFileLocator
-import net.bytebuddy.dynamic.loading.ClassInjector
 
 import java.lang.ref.WeakReference
 import java.util.concurrent.atomic.AtomicReference
@@ -16,7 +13,6 @@ import static datadog.trace.test.util.GCUtils.awaitGC
 class HelperInjectionTest extends DDSpecification {
   static final String HELPER_CLASS_NAME = 'datadog.trace.agent.test.HelperClass'
 
-  //@Flaky("awaitGC usage is flaky")
   def "helpers injected to non-delegating classloader"() {
     setup:
     HelperInjector injector = new HelperInjector(false, "test", HELPER_CLASS_NAME)
@@ -45,39 +41,4 @@ class HelperInjectionTest extends DDSpecification {
     then: "HelperInjector doesn't prevent it from being collected"
     null == ref.get()
   }
-
-  //@Flaky("awaitGC usage is flaky")
-  def "check hard references on class injection"() {
-    setup:
-
-    // Copied from HelperInjector:
-    final ClassFileLocator locator =
-      ClassFileLocator.ForClassLoader.of(Utils.getAgentClassLoader())
-    final byte[] classBytes = locator.locate(HELPER_CLASS_NAME).resolve()
-    final TypeDescription typeDesc =
-      new TypeDescription.Latent(
-      HELPER_CLASS_NAME, 0, null, Collections.<TypeDescription.Generic> emptyList())
-
-    AtomicReference<URLClassLoader> emptyLoader = new AtomicReference<>(new URLClassLoader(new URL[0], (ClassLoader) null))
-    AtomicReference<ClassInjector> injector = new AtomicReference<>(new ClassInjector.UsingReflection(emptyLoader.get()))
-    injector.get().inject([(typeDesc): classBytes])
-
-    when:
-    def injectorRef = new WeakReference(injector.get())
-    injector.set(null)
-
-    awaitGC(injectorRef)
-
-    then:
-    null == injectorRef.get()
-
-    when:
-    def loaderRef = new WeakReference(emptyLoader.get())
-    emptyLoader.set(null)
-
-    awaitGC(loaderRef)
-
-    then:
-    null == loaderRef.get()
-  }
 }