Skip to content

Commit 486e238

Browse files
Yoonena-ji
authored andcommitted
Fixed containsTraceComment for test cases
1 parent 5df1948 commit 486e238

File tree

2 files changed

+15
-11
lines changed

2 files changed

+15
-11
lines changed

dd-java-agent/instrumentation/jdbc/src/main/java/datadog/trace/instrumentation/jdbc/SQLCommenter.java

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -109,18 +109,17 @@ private static boolean hasDDComment(String sql, boolean appendComment) {
109109
}
110110

111111
private static String extractCommentContent(String sql, boolean appendComment) {
112+
int startIdx;
113+
int endIdx;
112114
if (appendComment) {
113-
int startIdx = sql.lastIndexOf(OPEN_COMMENT);
114-
int endIdx = sql.lastIndexOf(CLOSE_COMMENT);
115-
if (startIdx != -1 && endIdx != -1 && endIdx > startIdx) {
116-
return sql.substring(startIdx + OPEN_COMMENT_LEN, endIdx);
117-
}
115+
startIdx = sql.lastIndexOf(OPEN_COMMENT);
116+
endIdx = sql.lastIndexOf(CLOSE_COMMENT);
118117
} else {
119-
int startIdx = sql.indexOf(OPEN_COMMENT);
120-
int endIdx = sql.indexOf(CLOSE_COMMENT);
121-
if (startIdx != -1 && endIdx != -1 && endIdx > startIdx) {
122-
return sql.substring(startIdx + OPEN_COMMENT_LEN, endIdx);
123-
}
118+
startIdx = sql.indexOf(OPEN_COMMENT);
119+
endIdx = sql.indexOf(CLOSE_COMMENT);
120+
}
121+
if (startIdx != -1 && endIdx != -1 && endIdx > startIdx) {
122+
return sql.substring(startIdx + OPEN_COMMENT_LEN, endIdx);
124123
}
125124
return "";
126125
}

dd-trace-core/src/main/java/datadog/trace/core/database/SharedDBCommenter.java

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,13 @@ public class SharedDBCommenter {
3636
public static boolean containsTraceComment(String commentContent) {
3737
return commentContent.contains(PARENT_SERVICE + "=")
3838
|| commentContent.contains(DATABASE_SERVICE + "=")
39+
|| commentContent.contains(DD_HOSTNAME + "=")
40+
|| commentContent.contains(DD_DB_NAME + "=")
41+
|| commentContent.contains(DD_PEER_SERVICE + "=")
3942
|| commentContent.contains(DD_ENV + "=")
40-
|| commentContent.contains(TRACEPARENT + "=");
43+
|| commentContent.contains(DD_VERSION + "=")
44+
|| commentContent.contains(TRACEPARENT + "=")
45+
|| commentContent.contains(DD_SERVICE_HASH + "=");
4146
}
4247

4348
// Build database comment content without comment delimiters such as /* */

0 commit comments

Comments
 (0)