Skip to content

Commit 4d58aa0

Browse files
committed
Use static object mapper
1 parent 320e6cd commit 4d58aa0

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

dd-java-agent/instrumentation/spark/src/main/java/datadog/trace/instrumentation/spark/AbstractDatadogSparkListener.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,6 +65,7 @@
6565
*/
6666
public abstract class AbstractDatadogSparkListener extends SparkListener {
6767
private static final Logger log = LoggerFactory.getLogger(AbstractDatadogSparkListener.class);
68+
private static final ObjectMapper objectMapper = new ObjectMapper();
6869
public static volatile AbstractDatadogSparkListener listener = null;
6970
public static volatile boolean finishTraceOnApplicationEnd = true;
7071
public static volatile boolean isPysparkShell = false;
@@ -1200,7 +1201,6 @@ private static void reportKafkaOffsets(
12001201
// check if this is a kafka source
12011202
if (progress.description().toLowerCase().startsWith("kafka")) {
12021203
try {
1203-
ObjectMapper objectMapper = new ObjectMapper();
12041204
// parse offsets from endOffsets json, reported in a format:
12051205
// "topic" -> ["partition":value]
12061206
JsonNode jsonNode = objectMapper.readTree(progress.endOffset());
@@ -1227,7 +1227,7 @@ private static void reportKafkaOffsets(
12271227
.trackBacklog(sortedTags, topicNode.get(partition).asLong());
12281228
}
12291229
}
1230-
} catch (Exception e) {
1230+
} catch (Throwable e) {
12311231
log.debug("Failed to parse kafka offsets", e);
12321232
}
12331233
}
@@ -1242,7 +1242,6 @@ private static String getDatabricksRunName(SparkConf conf) {
12421242
try {
12431243
// Using the jackson JSON lib used by spark
12441244
// https://mvnrepository.com/artifact/org.apache.spark/spark-core_2.12/3.5.0
1245-
ObjectMapper objectMapper = new ObjectMapper();
12461245
JsonNode jsonNode = objectMapper.readTree(allTags);
12471246

12481247
for (JsonNode node : jsonNode) {

0 commit comments

Comments
 (0)