Skip to content

Commit 4f1db26

Browse files
committed
Clean test code
1 parent b1e0a9a commit 4f1db26

File tree

1 file changed

+6
-20
lines changed

1 file changed

+6
-20
lines changed

.gitlab-ci.yml

Lines changed: 6 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -884,18 +884,15 @@ package-oci:
884884
verify_maven_central_deployment:
885885
image: registry.ddbuild.io/images/base/gbi-ubuntu_2204:release
886886
stage: publish
887-
# needs: [ deploy_to_maven_central ]
887+
needs: [ deploy_to_maven_central ]
888888
rules:
889889
- if: '$POPULATE_CACHE'
890890
when: never
891-
- when: manual
892-
allow_failure: true
893-
# - if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+$/'
894-
# when: on_success
891+
- if: '$CI_COMMIT_TAG =~ /^v[0-9]+\.[0-9]+\.[0-9]+$/'
892+
when: on_success
895893
script:
896894
- |
897-
export VERSION=1.51.2
898-
# export VERSION=${CI_COMMIT_TAG##v}
895+
export VERSION=${CI_COMMIT_TAG##v}
899896
ARTIFACT_URLS=(
900897
"https://repo1.maven.org/maven2/com/datadoghq/dd-java-agent/${VERSION}/dd-java-agent-${VERSION}.jar"
901898
"https://repo1.maven.org/maven2/com/datadoghq/dd-trace-api/${VERSION}/dd-trace-api-${VERSION}.jar"
@@ -923,22 +920,11 @@ verify_maven_central_deployment:
923920
exit 1
924921
fi
925922
done
926-
# TODO: remove this
927-
echo "The job was successful, but what does test-job do if this job fails?"
928-
exit 1
929923
930-
test-job:
931-
stage: publish
924+
publishing-gate:
932925
needs:
933926
- job: verify_maven_central_deployment
934-
optional: true
935-
script:
936-
- echo "Hello, world!"
937-
938-
# publishing-gate:
939-
# needs:
940-
# - job: verify_maven_central_deployment
941-
# optional: true
927+
optional: true # Allow job to run even if the verify_maven_central_deployment job fails
942928

943929
configure_system_tests:
944930
variables:

0 commit comments

Comments
 (0)