Skip to content

Commit 545829f

Browse files
Set correct subdomain when sending intake requests via EVP proxy (#9517)
1 parent 12c02b6 commit 545829f

File tree

4 files changed

+13
-5
lines changed

4 files changed

+13
-5
lines changed

communication/src/main/java/datadog/communication/BackendApiFactory.java

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,14 @@ public BackendApiFactory(Config config, SharedCommunicationObjects sharedCommuni
4949
String traceId = config.getIdGenerationStrategy().generateTraceId().toString();
5050
String evpProxyEndpoint = featuresDiscovery.getEvpProxyEndpoint();
5151
HttpUrl evpProxyUrl = sharedCommunicationObjects.agentUrl.resolve(evpProxyEndpoint);
52+
String subdomain = intake.getUrlPrefix();
5253
return new EvpProxyApi(
53-
traceId, evpProxyUrl, retryPolicyFactory, sharedCommunicationObjects.okHttpClient, true);
54+
traceId,
55+
evpProxyUrl,
56+
subdomain,
57+
retryPolicyFactory,
58+
sharedCommunicationObjects.okHttpClient,
59+
true);
5460
}
5561

5662
log.warn(

communication/src/main/java/datadog/communication/EvpProxyApi.java

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,23 +25,25 @@ public class EvpProxyApi implements BackendApi {
2525
private static final String X_DATADOG_PARENT_ID_HEADER = "x-datadog-parent-id";
2626
private static final String ACCEPT_ENCODING_HEADER = "Accept-Encoding";
2727
private static final String CONTENT_ENCODING_HEADER = "Content-Encoding";
28-
private static final String API_SUBDOMAIN = "api";
2928
private static final String GZIP_ENCODING = "gzip";
3029

3130
private final String traceId;
3231
private final HttpRetryPolicy.Factory retryPolicyFactory;
3332
private final HttpUrl evpProxyUrl;
33+
private final String subdomain;
3434
private final OkHttpClient httpClient;
3535
private final boolean responseCompression;
3636

3737
public EvpProxyApi(
3838
String traceId,
3939
HttpUrl evpProxyUrl,
40+
String subdomain,
4041
HttpRetryPolicy.Factory retryPolicyFactory,
4142
OkHttpClient httpClient,
4243
boolean responseCompression) {
4344
this.traceId = traceId;
4445
this.evpProxyUrl = evpProxyUrl.resolve(String.format("api/%s/", API_VERSION));
46+
this.subdomain = subdomain;
4547
this.retryPolicyFactory = retryPolicyFactory;
4648
this.httpClient = httpClient;
4749
this.responseCompression = responseCompression;
@@ -60,7 +62,7 @@ public <T> T post(
6062
Request.Builder requestBuilder =
6163
new Request.Builder()
6264
.url(url)
63-
.addHeader(X_DATADOG_EVP_SUBDOMAIN_HEADER, API_SUBDOMAIN)
65+
.addHeader(X_DATADOG_EVP_SUBDOMAIN_HEADER, subdomain)
6466
.addHeader(X_DATADOG_TRACE_ID_HEADER, traceId)
6567
.addHeader(X_DATADOG_PARENT_ID_HEADER, traceId);
6668

dd-java-agent/agent-ci-visibility/src/test/groovy/datadog/trace/civisibility/config/ConfigurationApiImplTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ class ConfigurationApiImplTest extends Specification {
273273
HttpUrl proxyUrl = HttpUrl.get(address)
274274
HttpRetryPolicy.Factory retryPolicyFactory = new HttpRetryPolicy.Factory(5, 100, 2.0)
275275
OkHttpClient client = OkHttpUtils.buildHttpClient(proxyUrl, REQUEST_TIMEOUT_MILLIS)
276-
return new EvpProxyApi(traceId, proxyUrl, retryPolicyFactory, client, responseCompression)
276+
return new EvpProxyApi(traceId, proxyUrl, "api", retryPolicyFactory, client, responseCompression)
277277
}
278278

279279
private BackendApi givenIntakeApi(URI address, boolean responseCompression) {

dd-java-agent/agent-ci-visibility/src/test/groovy/datadog/trace/civisibility/git/tree/GitDataApiTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ class GitDataApiTest extends Specification {
121121
HttpUrl proxyUrl = HttpUrl.get(intakeServer.address)
122122
HttpRetryPolicy.Factory retryPolicyFactory = new HttpRetryPolicy.Factory(5, 100, 2.0)
123123
OkHttpClient client = OkHttpUtils.buildHttpClient(proxyUrl, REQUEST_TIMEOUT_MILLIS)
124-
return new EvpProxyApi(traceId, proxyUrl, retryPolicyFactory, client, true)
124+
return new EvpProxyApi(traceId, proxyUrl, "api", retryPolicyFactory, client, true)
125125
}
126126

127127
private Path givenPackFile() {

0 commit comments

Comments
 (0)