Skip to content

Commit 545c928

Browse files
committed
Test now uses clearThreadServiceName
1 parent 5c484ed commit 545c928

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

dd-trace-core/src/main/java/datadog/trace/core/datastreams/DefaultDataStreamsMonitoring.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,12 @@ public void setProduceCheckpoint(String type, String target) {
189189

190190
@Override
191191
public void setThreadServiceName(Long threadId, String serviceName) {
192+
// setting service name to null == removing the value
193+
if (serviceName == null) {
194+
clearThreadServiceName(threadId);
195+
return;
196+
}
197+
192198
threadServiceNames.put(threadId, serviceName);
193199
}
194200

dd-trace-core/src/test/groovy/datadog/trace/core/datastreams/DataStreamsWritingTest.groovy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,10 +83,10 @@ class DataStreamsWritingTest extends DDCoreSpecification {
8383
dataStreams.add(new StatsPoint([], 9, 0, 10, timeSource.currentTimeNanos, 0, 0, 0, serviceNameOverride))
8484
dataStreams.trackBacklog(new LinkedHashMap<>(["partition": "1", "topic": "testTopic", "type": "kafka_produce"]), 130)
8585
timeSource.advance(DEFAULT_BUCKET_DURATION_NANOS)
86-
dataStreams.setThreadServiceName(Thread.currentThread().getId(), null)
8786
// force flush
8887
dataStreams.report()
8988
dataStreams.close()
89+
dataStreams.clearThreadServiceName(Thread.currentThread().getId())
9090
then:
9191
conditions.eventually {
9292
assert requestBodies.size() == 1

0 commit comments

Comments
 (0)