File tree Expand file tree Collapse file tree 1 file changed +5
-0
lines changed
remote-config/remote-config-core/src/main/java/datadog/remoteconfig/state Expand file tree Collapse file tree 1 file changed +5
-0
lines changed Original file line number Diff line number Diff line change @@ -90,6 +90,8 @@ public boolean apply(
9090 }
9191
9292 // Step 3: Remove obsolete configurations (for all products)
93+ // For ASM_DD, this is critical: removes MUST happen before applies to prevent
94+ // duplicate rule warnings from the ddwaf rule parser and causing memory spikes.
9395 List <ParsedConfigKey > keysToRemove =
9496 cachedTargetFiles .keySet ().stream ()
9597 .filter (configKey -> !configBeenUsedByProduct .contains (configKey ))
@@ -101,6 +103,9 @@ public boolean apply(
101103 }
102104
103105 // Step 4: For ASM_DD, apply changes AFTER removes
106+ // TODO: This is a temporary solution. The proper fix requires better synchronization
107+ // between remove and add/update operations. This should be discussed
108+ // with the guild to determine the best long-term design approach.
104109 if (product == Product .ASM_DD ) {
105110 for (ParsedConfigKey configKey : changedKeys ) {
106111 try {
You can’t perform that action at this time.
0 commit comments