remove sampling priority argument from the trace parent util

Author: na-ji

dd-trace-core/src/main/java/datadog/trace/core/propagation/W3CTraceParent.java

@@ -23,26 +23,26 @@ private W3CTraceParent() {}
    *
    * @param traceId the trace id
    * @param spanId the span id
-   * @param samplingPriority the sampling priority (positive values result in sampled flag set)
+   * @param isSampled whether the trace was sampled or not
    * @return the W3C traceparent header value
    */
-  public static String from(DDTraceId traceId, long spanId, int samplingPriority) {
+  public static String from(DDTraceId traceId, long spanId, boolean isSampled) {
     StringBuilder sb = new StringBuilder(TRACE_PARENT_LENGTH);
     sb.append("00-");
     sb.append(traceId.toHexString());
     sb.append('-');
     sb.append(DDSpanId.toHexStringPadded(spanId));
-    sb.append(samplingPriority > 0 ? "-01" : "-00");
+    sb.append(isSampled ? "-01" : "-00");
 
     return sb.toString();
   }
 
   public static String from(AgentSpan span) {
-    return from(span.getTraceId(), span.getSpanId(), span.context().getSamplingPriority());
+    return from(span.getTraceId(), span.getSpanId(), span.context().getSamplingPriority() > 0);
   }
 
   public static String from(DDSpanContext spanContext) {
     return from(
-        spanContext.getTraceId(), spanContext.getSpanId(), spanContext.getSamplingPriority());
+        spanContext.getTraceId(), spanContext.getSpanId(), spanContext.getSamplingPriority() > 0);
   }
 }

dd-trace-core/src/test/groovy/datadog/trace/core/propagation/W3CTraceParentTest.groovy

@@ -5,26 +5,25 @@ import datadog.trace.test.util.DDSpecification
 
 class W3CTraceParentTest extends DDSpecification {
 
-  def "build produces correct format with samplingPriority=#samplingPriority"() {
+  def "build produces correct format with isSampled=#isSampled"() {
     when:
-    def result = W3CTraceParent.from(traceId, spanId, samplingPriority)
+    def result = W3CTraceParent.from(traceId, spanId, isSampled)
 
     then:
     result == expected
 
     where:
-    traceId                                               | spanId              | samplingPriority | expected
-    DDTraceId.from(1)                                     | 2                   | 1                | "00-00000000000000000000000000000001-0000000000000002-01"
-    DDTraceId.from(1)                                     | 2                   | 0                | "00-00000000000000000000000000000001-0000000000000002-00"
-    DDTraceId.from(1)                                     | 2                   | -1               | "00-00000000000000000000000000000001-0000000000000002-00"
-    DDTraceId.from(1)                                     | 2                   | 2                | "00-00000000000000000000000000000001-0000000000000002-01"
-    DDTraceId.fromHex("0af7651916cd43dd8448eb211c80319c") | 0x00f067aa0ba902b7L | 1                | "00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-01"
-    DDTraceId.from(Long.MAX_VALUE)                        | Long.MAX_VALUE      | 1                | "00-00000000000000007fffffffffffffff-7fffffffffffffff-01"
+    traceId                                               | spanId              | isSampled | expected
+    DDTraceId.from(1)                                     | 2                   | true      | "00-00000000000000000000000000000001-0000000000000002-01"
+    DDTraceId.from(1)                                     | 2                   | false     | "00-00000000000000000000000000000001-0000000000000002-00"
+    DDTraceId.from(1)                                     | 2                   | true      | "00-00000000000000000000000000000001-0000000000000002-01"
+    DDTraceId.fromHex("0af7651916cd43dd8448eb211c80319c") | 0x00f067aa0ba902b7L | true      | "00-0af7651916cd43dd8448eb211c80319c-00f067aa0ba902b7-01"
+    DDTraceId.from(Long.MAX_VALUE)                        | Long.MAX_VALUE      | true      | "00-00000000000000007fffffffffffffff-7fffffffffffffff-01"
   }
 
   def "build matches W3C traceparent format"() {
     when:
-    def result = W3CTraceParent.from(DDTraceId.from(123456789L), 987654321L, 1)
+    def result = W3CTraceParent.from(DDTraceId.from(123456789L), 987654321L, true)
 
     then:
     // W3C format: version-traceId(32 hex)-spanId(16 hex)-flags(2 hex)