Skip to content

Commit 625b8c3

Browse files
committed
spotless
1 parent cd6affc commit 625b8c3

File tree

4 files changed

+140
-120
lines changed

4 files changed

+140
-120
lines changed

components/native-loader/src/main/java/datadog/nativeloader/CompositeLibraryLoadingListener.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,9 +125,9 @@ public CompositeLibraryLoadingListener join(LibraryLoadingListener... listeners)
125125
combinedListeners.addAll(Arrays.asList(listeners));
126126
return new CompositeLibraryLoadingListener(combinedListeners);
127127
}
128-
128+
129129
@Override
130130
public String toString() {
131-
return this.getClass().getSimpleName() + ":" + this.listeners.toString();
131+
return this.getClass().getSimpleName() + ":" + this.listeners.toString();
132132
}
133133
}

components/native-loader/src/main/java/datadog/nativeloader/NativeLoader.java

Lines changed: 8 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -266,11 +266,12 @@ public LibFile resolveDynamic(PlatformSpec platformSpec, String libName)
266266
return this.resolveDynamicImpl(platformSpec, null, libName);
267267
}
268268

269-
public LibFile resolveDynamic(PlatformSpec platformSpec, String libName, LibraryLoadingListener... scopedListeners)
269+
public LibFile resolveDynamic(
270+
PlatformSpec platformSpec, String libName, LibraryLoadingListener... scopedListeners)
270271
throws LibraryLoadException {
271272
return this.resolveDynamicImpl(platformSpec, null, libName, scopedListeners);
272273
}
273-
274+
274275
/**
275276
* Resolves a library with an associated component with a different {@link PlatformSpec} than the
276277
* default
@@ -336,7 +337,7 @@ private LibFile resolveDynamicImpl(
336337

337338
private static LibFile toLibFile(
338339
Path tempDir,
339-
PlatformSpec platformSpec,
340+
PlatformSpec platformSpec,
340341
String optionalComponent,
341342
String libName,
342343
URL url,
@@ -357,14 +358,14 @@ private static LibFile toLibFile(
357358
}
358359

359360
allListeners.onTempFileCreated(platformSpec, optionalComponent, libName, tempFile);
360-
361+
361362
return LibFile.fromTempFile(
362363
platformSpec, optionalComponent, libName, tempFile.toFile(), allListeners);
363-
364+
364365
} catch (Throwable t) {
365-
allListeners.onTempFileCreationFailure(
366+
allListeners.onTempFileCreationFailure(
366367
platformSpec, optionalComponent, libName, tempDir, libExt, tempFile, t);
367-
368+
368369
throw new LibraryLoadException(libName, t);
369370
}
370371
}

components/native-loader/src/test/java/datadog/nativeloader/NativeLoaderTest.java

Lines changed: 30 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -4,12 +4,12 @@
44
import static datadog.nativeloader.TestPlatformSpec.LINUX;
55
import static datadog.nativeloader.TestPlatformSpec.UNSUPPORTED_ARCH;
66
import static datadog.nativeloader.TestPlatformSpec.UNSUPPORTED_OS;
7-
import static org.junit.jupiter.api.Assumptions.assumeTrue;
87
import static org.junit.jupiter.api.Assertions.assertFalse;
98
import static org.junit.jupiter.api.Assertions.assertNotNull;
109
import static org.junit.jupiter.api.Assertions.assertNull;
1110
import static org.junit.jupiter.api.Assertions.assertThrows;
1211
import static org.junit.jupiter.api.Assertions.assertTrue;
12+
import static org.junit.jupiter.api.Assumptions.assumeTrue;
1313

1414
import java.io.File;
1515
import java.io.IOException;
@@ -175,33 +175,34 @@ public void fromDir() throws LibraryLoadException {
175175
@Test
176176
public void fromDir_override_windows() throws LibraryLoadException {
177177
TestLibraryLoadingListener sharedListener = new TestLibraryLoadingListener();
178-
179-
NativeLoader loader = NativeLoader.builder().fromDir("test-data").addListener(sharedListener).build();
180-
178+
179+
NativeLoader loader =
180+
NativeLoader.builder().fromDir("test-data").addListener(sharedListener).build();
181+
181182
sharedListener.expectResolveDynamic(TestPlatformSpec.windows(), "dummy");
182-
183+
183184
try (LibFile lib = loader.resolveDynamic(TestPlatformSpec.windows(), "dummy")) {
184185
// loaded directly from directory, so no clean-up required
185186
assertRegularFile(lib);
186187
assertTrue(lib.getAbsolutePath().endsWith("dummy.dll"));
187188
}
188-
189+
189190
sharedListener.assertDone();
190191
}
191192

192193
@Test
193194
public void fromDir_override_mac() throws LibraryLoadException {
194195
NativeLoader loader = NativeLoader.builder().fromDir("test-data").build();
195-
196-
TestLibraryLoadingListener scopedListener = new TestLibraryLoadingListener().
197-
expectResolveDynamic(TestPlatformSpec.mac(), "dummy");
196+
197+
TestLibraryLoadingListener scopedListener =
198+
new TestLibraryLoadingListener().expectResolveDynamic(TestPlatformSpec.mac(), "dummy");
198199

199200
try (LibFile lib = loader.resolveDynamic(TestPlatformSpec.mac(), "dummy", scopedListener)) {
200201
// loaded directly from directory, so no clean-up required
201202
assertRegularFile(lib);
202203
assertTrue(lib.getAbsolutePath().endsWith("libdummy.dylib"));
203204
}
204-
205+
205206
scopedListener.assertDone();
206207
}
207208

@@ -228,26 +229,27 @@ public void fromDirList() throws LibraryLoadException {
228229

229230
@Test
230231
public void fromDir_with_component() throws LibraryLoadException {
231-
TestLibraryLoadingListener sharedListener = new TestLibraryLoadingListener();
232-
233-
NativeLoader loader = NativeLoader.builder().fromDir("test-data").addListener(sharedListener).build();
234-
232+
TestLibraryLoadingListener sharedListener = new TestLibraryLoadingListener();
233+
234+
NativeLoader loader =
235+
NativeLoader.builder().fromDir("test-data").addListener(sharedListener).build();
236+
235237
sharedListener.expectResolveDynamic("comp1", "dummy");
236238

237239
try (LibFile lib = loader.resolveDynamic("comp1", "dummy")) {
238240
assertRegularFile(lib);
239241
assertTrue(lib.getAbsolutePath().contains("comp1"));
240242
}
241-
243+
242244
sharedListener.assertDone();
243-
245+
244246
sharedListener.expectResolveDynamic("comp2", "dummy");
245247

246248
try (LibFile lib = loader.resolveDynamic("comp2", "dummy")) {
247249
assertRegularFile(lib);
248250
assertTrue(lib.getAbsolutePath().contains("comp2"));
249251
}
250-
252+
251253
sharedListener.assertDone();
252254
}
253255

@@ -320,19 +322,20 @@ public void fromJarBackedClassLoader() throws IOException, LibraryLoadException
320322
Path jar = jar("test-data");
321323
try {
322324
try (URLClassLoader classLoader = createClassLoader(jar)) {
323-
NativeLoader loader = NativeLoader.builder().fromClassLoader(classLoader).build();
324-
325-
TestLibraryLoadingListener scopedListener = new TestLibraryLoadingListener().
326-
expectResolveDynamic("dummy").
327-
expectTempFileCreated("dummy").
328-
expectTempFileCleanup("dummy");
329-
330-
try (LibFile lib = loader.resolveDynamic("dummy", scopedListener)) {
325+
NativeLoader loader = NativeLoader.builder().fromClassLoader(classLoader).build();
326+
327+
TestLibraryLoadingListener scopedListener =
328+
new TestLibraryLoadingListener()
329+
.expectResolveDynamic("dummy")
330+
.expectTempFileCreated("dummy")
331+
.expectTempFileCleanup("dummy");
332+
333+
try (LibFile lib = loader.resolveDynamic("dummy", scopedListener)) {
331334
// loaded from a jar, so copied to temp file
332335
assertTempFile(lib);
333336
}
334-
335-
scopedListener.assertDone();
337+
338+
scopedListener.assertDone();
336339
}
337340
} finally {
338341
deleteHelper(jar);

0 commit comments

Comments
 (0)