Merge branch 'master' into alejandro.gonzalez/endpoint-discovery-update

Author: jandro996

.gitlab-ci.yml

@@ -255,7 +255,7 @@ build:
     CACHE_TYPE: lib
     DEPENDENCY_CACHE_POLICY: pull
   script:
-    - if [ $CI_PIPELINE_SOURCE == "schedule" ] ; then ./gradlew resolveAndLockAll --write-locks; fi
+    - if [ $CI_PIPELINE_SOURCE == "schedule" ] ; then ./gradlew resolveAndLockAll --write-locks $GRADLE_ARGS; fi
     - ./gradlew clean :dd-java-agent:shadowJar :dd-trace-api:jar :dd-trace-ot:shadowJar -PskipTests $GRADLE_ARGS
     - echo UPSTREAM_TRACER_VERSION=$(java -jar workspace/dd-java-agent/build/libs/*.jar) >> upstream.env
     - echo "BUILD_JOB_NAME=$CI_JOB_NAME" >> build.env

build.gradle

@@ -0,0 +1,144 @@
+import com.diffplug.gradle.spotless.SpotlessExtension
+
+plugins {
+  id("datadog.gradle-debug")
+  id("datadog.dependency-locking")
+
+  id("com.diffplug.spotless") version "6.13.0"
+  id("com.github.spotbugs") version "5.0.14"
+  id("de.thetaphi.forbiddenapis") version "3.8"
+
+  id("org.shipkit.shipkit-auto-version") version "2.1.2"
+  id("io.github.gradle-nexus.publish-plugin") version "2.0.0"
+
+  id("com.gradleup.shadow") version "8.3.6" apply false
+  id("me.champeau.jmh") version "0.7.3" apply false
+  id("org.gradle.playframework") version "0.13" apply false
+  id("info.solidsoft.pitest") version "1.9.11" apply false
+}
+
+description = "dd-trace-java"
+
+val isCI = providers.environmentVariable("CI")
+
+apply(from = rootDir.resolve("gradle/repositories.gradle"))
+
+spotless {
+  // only resolve the spotless dependencies once in the build
+  predeclareDeps()
+}
+
+with(extensions["spotlessPredeclare"] as SpotlessExtension) {
+  // these need to align with the types and versions in gradle/spotless.gradle
+  java {
+    removeUnusedImports()
+
+    // This is the last Google Java Format version that supports Java 8
+    googleJavaFormat("1.7")
+  }
+  groovyGradle {
+    greclipse()
+  }
+  groovy {
+    greclipse()
+  }
+  kotlinGradle {
+    ktlint("0.41.0")
+  }
+  kotlin {
+    ktlint("0.41.0")
+  }
+  scala {
+    scalafmt("2.7.5")
+  }
+}
+apply(from = rootDir.resolve("gradle/spotless.gradle"))
+
+val compileTask = tasks.register("compile")
+
+val repoVersion = version
+
+allprojects {
+  group = "com.datadoghq"
+  version = repoVersion
+
+  if (isCI.isPresent) {
+    layout.buildDirectory = providers.provider {
+      val newProjectCIPath = projectDir.path.replace(
+        rootDir.path,
+        ""
+      )
+      rootDir.resolve("workspace/$newProjectCIPath/build/")
+    }
+  }
+
+  apply(from = rootDir.resolve("gradle/dependencies.gradle"))
+  apply(from = rootDir.resolve("gradle/util.gradle"))
+
+  compileTask.configure {
+    dependsOn(tasks.withType<AbstractCompile>())
+  }
+
+  tasks.configureEach {
+    if (this is JavaForkOptions) {
+      maxHeapSize = System.getProperty("datadog.forkedMaxHeapSize")
+      minHeapSize = System.getProperty("datadog.forkedMinHeapSize")
+      jvmArgs(
+        "-XX:ErrorFile=/tmp/hs_err_pid%p.log",
+        "-XX:+HeapDumpOnOutOfMemoryError",
+        "-XX:HeapDumpPath=/tmp"
+      )
+    }
+  }
+}
+
+tasks.register("latestDepTest")
+
+nexusPublishing {
+  repositories {
+    val forceLocal = providers.gradleProperty("forceLocal").getOrElse("false").toBoolean()
+    if (forceLocal && !isCI.isPresent) {
+      // For testing, use with https://hub.docker.com/r/sonatype/nexus
+      // $ docker run --rm -d -p 8081:8081 --name nexus sonatype/nexus:oss
+      // $ ./gradlew publishToLocal -PforceLocal=true
+      // Doesn't work for testing releases though... (due to staging),
+      // however, it's possible to explore http://localhost:8081/nexus/
+      register("local") {
+        nexusUrl = uri("http://localhost:8081/nexus/content/repositories/releases/")
+        snapshotRepositoryUrl = uri("http://localhost:8081/nexus/content/repositories/snapshots/")
+        username = "admin"
+        password = "admin123"
+        allowInsecureProtocol = true
+      }
+    } else {
+      // see https://github.com/gradle-nexus/publish-plugin#publishing-to-maven-central-via-sonatype-central
+      // For official documentation:
+      // staging repo publishing https://central.sonatype.org/publish/publish-portal-ossrh-staging-api/#configuration
+      // snapshot publishing https://central.sonatype.org/publish/publish-portal-snapshots/#publishing-via-other-methods
+      sonatype {
+        nexusUrl = uri("https://ossrh-staging-api.central.sonatype.com/service/local/")
+        snapshotRepositoryUrl = uri("https://central.sonatype.com/repository/maven-snapshots/")
+        username = providers.environmentVariable("MAVEN_CENTRAL_USERNAME")
+        password = providers.environmentVariable("MAVEN_CENTRAL_PASSWORD")
+      }
+    }
+  }
+}
+
+val writeMainVersionFileTask = tasks.register("writeMainVersionFile") {
+  val versionFile = rootProject.layout.buildDirectory.file("main.version")
+  inputs.property("version", project.version)
+  outputs.file(versionFile)
+  doFirst {
+    require(versionFile.get().asFile.parentFile.mkdirs() || versionFile.get().asFile.parentFile.isDirectory)
+    versionFile.get().asFile.writeText(project.version.toString())
+  }
+}
+
+allprojects {
+  tasks.withType<PublishToMavenLocal>().configureEach {
+    finalizedBy(writeMainVersionFileTask)
+  }
+}
+
+apply(from = "$rootDir/gradle/ci_jobs.gradle")

build.gradle.kts

@@ -47,7 +47,7 @@ dependencies {
   implementation("org.ow2.asm", "asm-tree", "9.8")
 
   testImplementation(libs.spock.core)
-  testImplementation("org.codehaus.groovy", "groovy-all", "3.0.17")
+  testImplementation(libs.groovy)
 }
 
 tasks.compileKotlin {

buildSrc/build.gradle.kts

@@ -39,7 +39,7 @@ dependencies {
   testImplementation("net.bytebuddy", "byte-buddy", "1.17.5")
   testImplementation(libs.spock.core)
   testImplementation("org.objenesis", "objenesis", "3.0.1")
-  testImplementation("org.codehaus.groovy", "groovy-all", "3.0.17")
+  testImplementation(libs.groovy)
   testImplementation("javax.servlet", "javax.servlet-api", "3.0.1")
   testImplementation("com.github.spotbugs", "spotbugs-annotations", "4.2.0")
 }

buildSrc/call-site-instrumentation-plugin/build.gradle.kts

@@ -63,7 +63,7 @@ idea {
 }
 
 jmh {
-  jmhVersion = '1.32'
+  jmhVersion = libs.versions.jmh.get()
   duplicateClassesStrategy = DuplicatesStrategy.EXCLUDE
 }
 

dd-java-agent/agent-bootstrap/build.gradle

@@ -41,6 +41,9 @@ class GitLabInfo implements CIProviderInfo {
   public static final String GITLAB_CI_RUNNER_TAGS = "CI_RUNNER_TAGS";
   public static final String GITLAB_PULL_REQUEST_BASE_BRANCH =
       "CI_MERGE_REQUEST_TARGET_BRANCH_NAME";
+  public static final String GITLAB_PULL_REQUEST_BASE_SHA = "CI_MERGE_REQUEST_DIFF_BASE_SHA";
+  public static final String GITLAB_PULL_REQUEST_BASE_HEAD_SHA =
+      "CI_MERGE_REQUEST_TARGET_BRANCH_SHA";
   public static final String GITLAB_PULL_REQUEST_COMMIT_HEAD_SHA =
       "CI_MERGE_REQUEST_SOURCE_BRANCH_SHA";
   public static final String GITLAB_PULL_REQUEST_NUMBER = "CI_MERGE_REQUEST_IID";
@@ -88,8 +91,8 @@ public CIInfo buildCIInfo() {
   public PullRequestInfo buildPullRequestInfo() {
     return new PullRequestInfo(
         normalizeBranch(environment.get(GITLAB_PULL_REQUEST_BASE_BRANCH)),
-        null,
-        null,
+        environment.get(GITLAB_PULL_REQUEST_BASE_SHA),
+        environment.get(GITLAB_PULL_REQUEST_BASE_HEAD_SHA),
         new CommitInfo(environment.get(GITLAB_PULL_REQUEST_COMMIT_HEAD_SHA)),
         environment.get(GITLAB_PULL_REQUEST_NUMBER));
   }

dd-java-agent/agent-ci-visibility/src/main/java/datadog/trace/civisibility/ci/GitLabInfo.java

@@ -1080,8 +1080,10 @@
       "CI_JOB_NAME": "gitlab-job-name",
       "CI_JOB_STAGE": "gitlab-stage-name",
       "CI_JOB_URL": "https://gitlab.com/job",
+      "CI_MERGE_REQUEST_DIFF_BASE_SHA": "bf6c156e8c1ec9cf43239162bca38cad22a3f4d2",
       "CI_MERGE_REQUEST_IID": 42,
       "CI_MERGE_REQUEST_TARGET_BRANCH_NAME": "target-branch",
+      "CI_MERGE_REQUEST_TARGET_BRANCH_SHA": "eb6dda23983998409db832ad675ec18ec32a8205",
       "CI_PIPELINE_ID": "gitlab-pipeline-id",
       "CI_PIPELINE_IID": "gitlab-pipeline-number",
       "CI_PIPELINE_URL": "https://foo/repo/-/pipelines/1234",
@@ -1110,6 +1112,8 @@
       "git.commit.message": "gitlab-git-commit-message",
       "git.commit.sha": "b9f0fb3fdbb94c9d24b2c75b49663122a529e123",
       "git.pull_request.base_branch": "target-branch",
+      "git.pull_request.base_branch_head_sha": "eb6dda23983998409db832ad675ec18ec32a8205",
+      "git.pull_request.base_branch_sha": "bf6c156e8c1ec9cf43239162bca38cad22a3f4d2",
       "git.repository_url": "https://gitlab.com/repo/myrepo.git",
       "pr.number": "42"
     }