revert error changes to ConfigSetting; do this in separate PR

Author: mtoffl01

internal-api/src/main/java/datadog/trace/api/ConfigSetting.java

@@ -12,7 +12,6 @@ public final class ConfigSetting {
   public final Object value;
   public final ConfigOrigin origin;
   public final int seqId;
-  public final boolean error;
 
   public static final int DEFAULT_SEQ_ID = 1;
   private static final int ABSENT_SEQ_ID = 0;
@@ -22,24 +21,17 @@ public final class ConfigSetting {
           Arrays.asList("DD_API_KEY", "dd.api-key", "dd.profiling.api-key", "dd.profiling.apikey"));
 
   public static ConfigSetting of(String key, Object value, ConfigOrigin origin) {
-    return new ConfigSetting(key, value, origin, ABSENT_SEQ_ID, false);
+    return new ConfigSetting(key, value, origin, ABSENT_SEQ_ID);
   }
 
   public static ConfigSetting of(String key, Object value, ConfigOrigin origin, int seqId) {
-    return new ConfigSetting(key, value, origin, seqId, false);
+    return new ConfigSetting(key, value, origin, seqId);
   }
 
-  public static ConfigSetting of(
-      String key, Object value, ConfigOrigin origin, int seqId, boolean error) {
-    return new ConfigSetting(key, value, origin, seqId, error);
-  }
-
-  private ConfigSetting(String key, Object value, ConfigOrigin origin, int seqId, boolean error) {
+  private ConfigSetting(String key, Object value, ConfigOrigin origin, int seqId) {
     this.key = key;
     this.value = CONFIG_FILTER_LIST.contains(key) ? "<hidden>" : value;
     this.origin = origin;
-    this.seqId = seqId;
-    this.error = error;
   }
 
   public String normalizedKey() {
@@ -118,8 +110,7 @@ public boolean equals(Object o) {
     return key.equals(that.key)
         && Objects.equals(value, that.value)
         && origin == that.origin
-        && seqId == that.seqId
-        && error == that.error;
+        && seqId == that.seqId;
   }
 
   @Override
@@ -140,6 +131,5 @@ public String toString() {
         + ", seqId="
         + seqId
         + '}';
-    // whether to write errors
   }
 }