Add comment to the call depth usage in vert.x

manuel-alvarez-alvarez · manuel-alvarez-alvarez · commit 665badceb6f0 · 2025-01-29T12:02:52.000+01:00
diff --git a/dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/RoutingContextJsonAdvice.java b/dd-java-agent/instrumentation/vertx-web-4.0/src/main/java/datadog/trace/instrumentation/vertx_4_0/server/RoutingContextJsonAdvice.java
@@ -31,6 +31,8 @@ static void after(
       @ActiveRequestContext RequestContext reqCtx,
       @Advice.Thrown(readOnly = false) Throwable throwable) {
 
+    // in newer versions of vert.x rc.getBodyAsJson() calls internally rc.body().asJsonObject()
+    // so we need to prevent sending the body twice to the WAF
     if (CallDepthThreadLocalMap.decrementCallDepth(RoutingContext.class) != 0) {
       return;
     }

Original file line number	Diff line number	Diff line change
`@@ -31,6 +31,8 @@ static void after(`
`31`	`31`	`@ActiveRequestContext RequestContext reqCtx,`
`32`	`32`	`@Advice.Thrown(readOnly = false) Throwable throwable) {`
`33`	`33`
	`34`	`+ // in newer versions of vert.x rc.getBodyAsJson() calls internally rc.body().asJsonObject()`
	`35`	`+ // so we need to prevent sending the body twice to the WAF`
`34`	`36`	`if (CallDepthThreadLocalMap.decrementCallDepth(RoutingContext.class) != 0) {`
`35`	`37`	`return;`
`36`	`38`	`}`