Merge branch 'master' into alejandro.gonzalez/APPSEC-57815

Author: jandro996

…dSrc/src/main/kotlin/CIJobsExtensions.kt …dog/gradle/plugin/ci/CIJobsExtensions.ktbuildSrc/src/main/kotlin/CIJobsExtensions.kt renamed to buildSrc/src/main/kotlin/datadog/gradle/plugin/ci/CIJobsExtensions.kt buildSrc/src/main/kotlin/CIJobsExtensions.kt renamed to buildSrc/src/main/kotlin/datadog/gradle/plugin/ci/CIJobsExtensions.kt

@@ -30,7 +30,7 @@ class VersionSet(versions: Collection<Version>) {
       return resultSet.map { it.version }
     }
 
-    private class ParsedVersion(val version: Version) : Comparable<ParsedVersion> {
+    internal class ParsedVersion(val version: Version) : Comparable<ParsedVersion> {
         companion object {
             private val dotPattern = Regex("\\.")
             private const val VERSION_SHIFT = 12

buildSrc/src/main/kotlin/datadog/gradle/plugin/muzzle/VersionSet.kt

@@ -0,0 +1,27 @@
+package datadog.gradle.plugin.muzzle
+
+import org.eclipse.aether.artifact.Artifact
+import org.eclipse.aether.artifact.DefaultArtifact
+import org.eclipse.aether.resolution.VersionRangeRequest
+import org.gradle.internal.impldep.org.junit.Assert.assertTrue
+import org.junit.jupiter.api.Test
+
+class RangeQueryTest {
+  private val system = MuzzleMavenRepoUtils.newRepositorySystem()
+  private val session = MuzzleMavenRepoUtils.newRepositorySystemSession(system)
+
+  @Test
+  fun `test range request`() {
+    // compile group: 'org.codehaus.groovy', name: 'groovy-all', version: '2.5.0', ext: 'pom'
+    val directiveArtifact: Artifact = DefaultArtifact("org.codehaus.groovy", "groovy-all", "jar", "[2.5.0,2.5.8)")
+    val rangeRequest = VersionRangeRequest().apply {
+      repositories = MuzzleMavenRepoUtils.MUZZLE_REPOS
+      artifact = directiveArtifact
+    }
+
+    // This call makes an actual network request, which may fail if network access is limited.
+    val rangeResult = system.resolveVersionRange(session, rangeRequest)
+
+    assertTrue(rangeResult.versions.size >= 8)
+  }
+}

buildSrc/src/test/groovy/datadog/gradle/plugin/muzzle/RangeQueryTest.groovy

@@ -0,0 +1,102 @@
+package datadog.gradle.plugin.muzzle
+
+import org.eclipse.aether.version.Version
+import org.junit.jupiter.api.Assertions.assertEquals
+import org.junit.jupiter.api.Test
+
+class VersionSetTest {
+
+  @Test
+  fun `parse versions properly`() {
+    data class Case(
+      val version: Version,
+      val versionNumber: Long,
+      val ending: String
+    )
+
+    val cases = listOf(
+      Case(ver("1.2.3"), num(1, 2, 3), ""),
+      Case(ver("4.5.6-foo"), num(4, 5, 6), "foo"),
+      Case(ver("7.8.9.foo"), num(7, 8, 9), "foo"),
+      Case(ver("10.11.12.foo-bar"), num(10, 11, 12), "foo-bar"),
+      Case(ver("13.14.foo-bar"), num(13, 14, 0), "foo-bar"),
+      Case(ver("15.foo"), num(15, 0, 0), "foo"),
+      Case(ver("16-foo"), num(16, 0, 0), "foo")
+    )
+
+    for (c in cases) {
+      val parsed = VersionSet.ParsedVersion(c.version)
+      assertEquals(c.versionNumber, parsed.versionNumber, "versionNumber for ${c.version}")
+      assertEquals(c.ending, parsed.ending, "ending for ${c.version}")
+      assertEquals(
+        c.versionNumber shr 12,
+        parsed.majorMinor.toLong(),
+        "majorMinor for ${c.version}"
+      )
+    }
+  }
+
+  @Test
+  fun `select low and high from major minor`() {
+    val versionsCases = listOf(
+      listOf(
+        ver("4.5.6"),
+        ver("1.2.3")
+      ),
+      listOf(
+        ver("1.2.3"),
+        ver("1.2.1"),
+        ver("1.3.0"),
+        ver("1.2.7"),
+        ver("1.4.17"),
+        ver("1.4.1"),
+        ver("1.4.0"),
+        ver("1.4.10")
+      )
+    )
+
+    val expectedCases = listOf(
+      listOf(
+        ver("1.2.3"),
+        ver("4.5.6")
+      ),
+      listOf(
+        ver("1.2.1"),
+        ver("1.2.7"),
+        ver("1.3.0"),
+        ver("1.4.0"),
+        ver("1.4.17")
+      )
+    )
+
+    versionsCases.zip(expectedCases).forEach { (versions, expected) ->
+      val versionSet = VersionSet(versions)
+      assertEquals(expected, versionSet.lowAndHighForMajorMinor)
+    }
+  }
+
+  private fun ver(v: String): Version = TestVersion(v)
+
+  private fun num(major: Int, minor: Int, micro: Int): Long {
+    var result = major.toLong()
+    result = (((result shl 12) + minor) shl 12) + micro
+    return result
+  }
+
+  private class TestVersion(private val v: String) : Version {
+    override fun compareTo(other: Version?): Int {
+      if (other is TestVersion) {
+        return v.compareTo(other.v)
+      }
+
+      return 1
+    }
+
+    override fun equals(other: Any?): Boolean =
+      other is TestVersion && v == other.v
+
+    override fun hashCode(): Int = v.hashCode()
+
+    override fun toString(): String = v
+  }
+}

buildSrc/src/test/groovy/datadog/gradle/plugin/muzzle/VersionSetTest.groovy

@@ -13,6 +13,7 @@ dependencies {
   implementation(project(":remote-config:remote-config-core"))
   implementation(project(":internal-api"))
   implementation(project(":utils:container-utils"))
+  implementation(project(":utils:filesystem-utils"))
   implementation(project(":utils:socket-utils"))
   implementation(project(":utils:version-utils"))
 

buildSrc/src/test/kotlin/datadog/gradle/plugin/muzzle/RangeQueryTest.kt

@@ -8,6 +8,7 @@
 import com.timgroup.statsd.NoOpDirectStatsDClient;
 import com.timgroup.statsd.NonBlockingStatsDClientBuilder;
 import com.timgroup.statsd.StatsDClientErrorHandler;
+import datadog.common.filesystem.Files;
 import datadog.environment.OperatingSystem;
 import datadog.trace.api.Config;
 import datadog.trace.relocate.api.IOLogger;
@@ -186,7 +187,7 @@ private void discoverConnectionSettings() {
     }
 
     if (null == host) {
-      if (!OperatingSystem.isWindows() && new File(DEFAULT_DOGSTATSD_SOCKET_PATH).exists()) {
+      if (!OperatingSystem.isWindows() && Files.exists(new File(DEFAULT_DOGSTATSD_SOCKET_PATH))) {
         log.info("Detected {}. Using it to send StatsD data.", DEFAULT_DOGSTATSD_SOCKET_PATH);
         host = DEFAULT_DOGSTATSD_SOCKET_PATH;
         port = 0; // tells dogstatsd client to treat host as a socket path

buildSrc/src/test/kotlin/datadog/gradle/plugin/muzzle/VersionSetTest.kt

@@ -1,5 +1,6 @@
 package datadog.trace.bootstrap.debugger;
 
+import datadog.instrument.asm.Type;
 import datadog.trace.api.Config;
 import datadog.trace.bootstrap.debugger.util.TimeoutChecker;
 import datadog.trace.bootstrap.instrumentation.api.AgentSpan;
@@ -100,7 +101,7 @@ public interface ExceptionDebugger {
   public interface CodeOriginRecorder {
     String captureCodeOrigin(boolean entry);
 
-    String captureCodeOrigin(Method method, boolean entry);
+    String captureCodeOrigin(String typeName, String methodName, String descriptor, boolean entry);
   }
 
   private static volatile ProbeResolver probeResolver;
@@ -506,11 +507,27 @@ public static void captureCodeOrigin(boolean entry) {
     }
   }
 
+  public static void captureCodeOrigin(
+      String typeName, String methodName, String descriptor, boolean entry) {
+    try {
+      CodeOriginRecorder recorder = codeOriginRecorder;
+      if (recorder != null) {
+        recorder.captureCodeOrigin(typeName, methodName, descriptor, entry);
+      }
+    } catch (Exception ex) {
+      LOGGER.debug("Error in captureCodeOrigin: ", ex);
+    }
+  }
+
   public static void captureCodeOrigin(Method method, boolean entry) {
     try {
       CodeOriginRecorder recorder = codeOriginRecorder;
       if (recorder != null) {
-        recorder.captureCodeOrigin(method, entry);
+        recorder.captureCodeOrigin(
+            method.getDeclaringClass().getName(),
+            method.getName(),
+            Type.getMethodDescriptor(method),
+            entry);
       }
     } catch (Exception ex) {
       LOGGER.debug("Error in captureCodeOrigin: ", ex);

communication/build.gradle.kts

@@ -5,6 +5,7 @@
 
 import com.datadog.debugger.agent.ConfigurationUpdater;
 import com.datadog.debugger.exception.Fingerprinter;
+import com.datadog.debugger.instrumentation.Types;
 import com.datadog.debugger.probe.CodeOriginProbe;
 import com.datadog.debugger.probe.LogProbe;
 import com.datadog.debugger.probe.LogProbe.Builder;
@@ -20,7 +21,6 @@
 import datadog.trace.bootstrap.instrumentation.api.AgentTracer;
 import datadog.trace.util.AgentTaskScheduler;
 import datadog.trace.util.stacktrace.StackWalkerFactory;
-import java.lang.reflect.Method;
 import java.util.Collection;
 import java.util.Collections;
 import java.util.HashMap;
@@ -82,11 +82,13 @@ public String captureCodeOrigin(boolean entry) {
   }
 
   @Override
-  public String captureCodeOrigin(Method method, boolean entry) {
-    String fingerprint = method.toString();
+  public String captureCodeOrigin(
+      String typeName, String methodName, String descriptor, boolean entry) {
+    String fingerprint = typeName + "." + methodName + descriptor;
     CodeOriginProbe probe = probesByFingerprint.get(fingerprint);
     if (probe == null) {
-      probe = createProbe(fingerprint, entry, Where.of(method));
+      String signature = Types.descriptorToSignature(descriptor);
+      probe = createProbe(fingerprint, entry, Where.of(typeName, methodName, signature));
       LOG.debug("Creating probe for method {}", fingerprint);
     }
     return probe.getId();