Removed kafka cluster id check, as it's sometimes equal to empty string

kr-igor · kr-igor · commit 69efa0171625 · 2025-07-22T15:18:35.000-05:00
diff --git a/dd-java-agent/instrumentation/kafka-connect-0.11/src/test/groovy/ConnectWorkerInstrumentationTest.groovy b/dd-java-agent/instrumentation/kafka-connect-0.11/src/test/groovy/ConnectWorkerInstrumentationTest.groovy
@@ -280,12 +280,12 @@ class ConnectWorkerInstrumentationTest extends AgentTestRunner {
 
     StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }
     verifyAll(first) {
-      tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)
+      tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka")
     }
 
     StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }
     verifyAll(second) {
-      tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)
+      tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka")
     }
     TEST_DATA_STREAMS_WRITER.getServices().contains('file-sink-connector')
 

Original file line number	Diff line number	Diff line change
`@@ -280,12 +280,12 @@ class ConnectWorkerInstrumentationTest extends AgentTestRunner {`
`280`	`280`
`281`	`281`	`StatsGroup first = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == 0 }`
`282`	`282`	`verifyAll(first) {`
`283`		`- tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)`
	`283`	`+ tags.hasAllTags("direction:out", "topic:test-topic", "type:kafka")`
`284`	`284`	`}`
`285`	`285`
`286`	`286`	`StatsGroup second = TEST_DATA_STREAMS_WRITER.groups.find { it.parentHash == first.hash }`
`287`	`287`	`verifyAll(second) {`
`288`		`- tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka", "kafka_cluster_id:" + clusterId)`
	`288`	`+ tags.hasAllTags("direction:in", "group:connect-file-sink-connector", "topic:test-topic", "type:kafka")`
`289`	`289`	`}`
`290`	`290`	`TEST_DATA_STREAMS_WRITER.getServices().contains('file-sink-connector')`
`291`	`291`